* [PATCH] unicore32: EXPORT_SYMBOL needs export.h
@ 2011-10-18 8:51 Axel Lin
2011-10-18 10:36 ` Guan Xuetao
2011-10-18 13:32 ` Paul Gortmaker
0 siblings, 2 replies; 3+ messages in thread
From: Axel Lin @ 2011-10-18 8:51 UTC (permalink / raw)
To: linux-kernel; +Cc: Guan Xuetao, David Rientjes, Arnd Bergmann, Paul Gortmaker
Include export.h to fix below warning:
CC arch/unicore32/mm/init.o
arch/unicore32/mm/init.c:227: warning: data definition has no type or storage class
arch/unicore32/mm/init.c:227: warning: type defaults to 'int' in declaration of 'EXPORT_SYMBOL'
arch/unicore32/mm/init.c:227: warning: parameter names (without types) in function declaration
Signed-off-by: Axel Lin <axel.lin@gmail.com>
---
This patch is against linux-next 20111014.
export.h only exist in Paul's tree now.
I think this patch should route via Paul's module.h splitup tree.
Axel
arch/unicore32/mm/init.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/arch/unicore32/mm/init.c b/arch/unicore32/mm/init.c
index 2d3e711..3b379cd 100644
--- a/arch/unicore32/mm/init.c
+++ b/arch/unicore32/mm/init.c
@@ -20,6 +20,7 @@
#include <linux/memblock.h>
#include <linux/sort.h>
#include <linux/dma-mapping.h>
+#include <linux/export.h>
#include <asm/sections.h>
#include <asm/setup.h>
--
1.7.5.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] unicore32: EXPORT_SYMBOL needs export.h
2011-10-18 8:51 [PATCH] unicore32: EXPORT_SYMBOL needs export.h Axel Lin
@ 2011-10-18 10:36 ` Guan Xuetao
2011-10-18 13:32 ` Paul Gortmaker
1 sibling, 0 replies; 3+ messages in thread
From: Guan Xuetao @ 2011-10-18 10:36 UTC (permalink / raw)
To: Axel Lin; +Cc: linux-kernel, David Rientjes, Arnd Bergmann, Paul Gortmaker
It seems the same problem with cross-compiler.
And I can't produce the same warnings.
Thanks Axel.
Guan Xuetao
On Tue, 2011-10-18 at 16:51 +0800, Axel Lin wrote:
> Include export.h to fix below warning:
>
> CC arch/unicore32/mm/init.o
> arch/unicore32/mm/init.c:227: warning: data definition has no type or storage class
> arch/unicore32/mm/init.c:227: warning: type defaults to 'int' in declaration of 'EXPORT_SYMBOL'
> arch/unicore32/mm/init.c:227: warning: parameter names (without types) in function declaration
>
> Signed-off-by: Axel Lin <axel.lin@gmail.com>
> ---
> This patch is against linux-next 20111014.
> export.h only exist in Paul's tree now.
> I think this patch should route via Paul's module.h splitup tree.
>
> Axel
> arch/unicore32/mm/init.c | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/arch/unicore32/mm/init.c b/arch/unicore32/mm/init.c
> index 2d3e711..3b379cd 100644
> --- a/arch/unicore32/mm/init.c
> +++ b/arch/unicore32/mm/init.c
> @@ -20,6 +20,7 @@
> #include <linux/memblock.h>
> #include <linux/sort.h>
> #include <linux/dma-mapping.h>
> +#include <linux/export.h>
>
> #include <asm/sections.h>
> #include <asm/setup.h>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] unicore32: EXPORT_SYMBOL needs export.h
2011-10-18 8:51 [PATCH] unicore32: EXPORT_SYMBOL needs export.h Axel Lin
2011-10-18 10:36 ` Guan Xuetao
@ 2011-10-18 13:32 ` Paul Gortmaker
1 sibling, 0 replies; 3+ messages in thread
From: Paul Gortmaker @ 2011-10-18 13:32 UTC (permalink / raw)
To: Axel Lin; +Cc: linux-kernel, Guan Xuetao, David Rientjes, Arnd Bergmann
On 11-10-18 04:51 AM, Axel Lin wrote:
> Include export.h to fix below warning:
>
> CC arch/unicore32/mm/init.o
> arch/unicore32/mm/init.c:227: warning: data definition has no type or storage class
> arch/unicore32/mm/init.c:227: warning: type defaults to 'int' in declaration of 'EXPORT_SYMBOL'
> arch/unicore32/mm/init.c:227: warning: parameter names (without types) in function declaration
>
> Signed-off-by: Axel Lin <axel.lin@gmail.com>
> ---
> This patch is against linux-next 20111014.
> export.h only exist in Paul's tree now.
> I think this patch should route via Paul's module.h splitup tree.
Correct. I will add it.
Thanks.
Paul.
>
> Axel
> arch/unicore32/mm/init.c | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/arch/unicore32/mm/init.c b/arch/unicore32/mm/init.c
> index 2d3e711..3b379cd 100644
> --- a/arch/unicore32/mm/init.c
> +++ b/arch/unicore32/mm/init.c
> @@ -20,6 +20,7 @@
> #include <linux/memblock.h>
> #include <linux/sort.h>
> #include <linux/dma-mapping.h>
> +#include <linux/export.h>
>
> #include <asm/sections.h>
> #include <asm/setup.h>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2011-10-18 13:32 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-10-18 8:51 [PATCH] unicore32: EXPORT_SYMBOL needs export.h Axel Lin
2011-10-18 10:36 ` Guan Xuetao
2011-10-18 13:32 ` Paul Gortmaker
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox