Re: [PATCH] perf ui browser: Honour the xterm colors

[David Ahern <dsahern@gmail.com>]

On 10/18/2011 08:41 PM, Arnaldo Carvalho de Melo wrote:
> Em Tue, Oct 18, 2011 at 11:12:33PM -0200, Arnaldo Carvalho de Melo escreveu:
>> Em Tue, Oct 18, 2011 at 09:51:33PM -0200, Arnaldo Carvalho de Melo escreveu:
>>> Em Tue, Oct 18, 2011 at 05:13:49PM -0600, David Ahern escreveu:
>>>> Using gnome3 with Fedora 15 these last 2 color sets don't look so good.
>>>> The 'black' background is not really black - more of a gray'ish look and
>>  
>>> Yeah, I also noticed that libslang's "black" is kinda like a
>>> bright black, really strange, I need to figure this out and also how to
>>> get the colors currently set in the terminal to get this finally like
>>> --stdio.
>>
>> https://bugzilla.redhat.com/show_bug.cgi?id=426948
>>
>> I know need to continue reading to figure out how to overcome this, as
>>
>> -Out to bed now tho :-)-
> 
> Ok, the following patch, that I pushed to my perf/core branch, does the
> trick...

Indeed it does. Much better color contrasts -- for me anyways.

David


> 
> _Out to bed now really :-)_
> 
> - Arnaldo
> 
> --------------------------
> 
> perf ui browser: Honour the xterm colors
> 
> So slang after all _has_ a 'default' color, call me color blind. Change
> the default to it.
> 
> Cc: Frederic Weisbecker <fweisbec@gmail.com>
> Cc: Ingo Molnar <mingo@elte.hu>
> Cc: Mike Galbraith <efault@gmx.de>
> Cc: Paul Mackerras <paulus@samba.org>
> Cc: Peter Zijlstra <peterz@infradead.org>
> Cc: Stephane Eranian <eranian@google.com>
> Cc: Tom Zanussi <tzanussi@gmail.com>
> Link: http://lkml.kernel.org/n/tip-1dfxivxv0jhwldpds3v4zla2@git.kernel.org
> Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
> ---
>  tools/perf/util/ui/browser.c |   10 +++++-----
>  1 files changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/tools/perf/util/ui/browser.c b/tools/perf/util/ui/browser.c
> index 976b957..06fc9eb 100644
> --- a/tools/perf/util/ui/browser.c
> +++ b/tools/perf/util/ui/browser.c
> @@ -439,19 +439,19 @@ static struct ui_browser__colorset {
>  		.colorset = HE_COLORSET_TOP,
>  		.name	  = "top",
>  		.fg	  = "red",
> -		.bg	  = "black",
> +		.bg	  = "default",
>  	},
>  	{
>  		.colorset = HE_COLORSET_MEDIUM,
>  		.name	  = "medium",
>  		.fg	  = "green",
> -		.bg	  = "black",
> +		.bg	  = "default",
>  	},
>  	{
>  		.colorset = HE_COLORSET_NORMAL,
>  		.name	  = "normal",
> -		.fg	  = "brightgreen",
> -		.bg	  = "black",
> +		.fg	  = "default",
> +		.bg	  = "default",
>  	},
>  	{
>  		.colorset = HE_COLORSET_SELECTED,
> @@ -463,7 +463,7 @@ static struct ui_browser__colorset {
>  		.colorset = HE_COLORSET_CODE,
>  		.name	  = "code",
>  		.fg	  = "blue",
> -		.bg	  = "black",
> +		.bg	  = "default",
>  	},
>  	{
>  		.name = NULL,