public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: <Srinivas_G_Gowda@Dell.com>
To: <linux-kernel@vger.kernel.org>
Cc: <minyard@acm.org>
Subject: [PATCH] ipmi: This patch decreases the IPMI message transaction time in Interrupt mode
Date: Tue, 18 Oct 2011 22:31:13 -0700	[thread overview]
Message-ID: <4E9E60A1.4090408@dell.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 0 bytes --]



[-- Attachment #2: 0001-ipmi-interrupt-fast-transaction.patch --]
[-- Type: text/plain, Size: 1387 bytes --]

Subject: [PATCH] This patch  decreases the IPMI message transaction time in Interrupt mode
 ---------------------------------------------------------------------------------------------
 In function sender(), start_next_msg(smi_info) is when the driver is ready to send the data to BMC,
 but counts on the timeout to start the transaction.In interrupt mode what I observed is that driver
 simply wastes time, counting on the timer to trigger the transaction.  What I have done here is to
 cut the wait,and trigger the call to the handler.
 This patch considerably decreases the IPMI transaction time (cuts off ~9ms for a single ipmitool transaction).

 Signed-off-by: Srinivas_Gowda <srinivas_g_gowda@dell.com>
---
diff --git a/drivers/char/ipmi/ipmi_si_intf.c b/drivers/char/ipmi/ipmi_si_intf.c
index 9397ab4..5d1e0ca 100644
--- a/drivers/char/ipmi/ipmi_si_intf.c
+++ b/drivers/char/ipmi/ipmi_si_intf.c
@@ -932,8 +932,10 @@ static void sender(void                *send_info,
 	spin_unlock_irqrestore(&smi_info->msg_lock, flags);
 
 	spin_lock_irqsave(&smi_info->si_lock, flags);
-	if (smi_info->si_state == SI_NORMAL && smi_info->curr_msg == NULL)
+	if (smi_info->si_state == SI_NORMAL && smi_info->curr_msg == NULL) {
 		start_next_msg(smi_info);
+		mod_timer(&smi_info->si_timer, jiffies + 1);
+	}
 	spin_unlock_irqrestore(&smi_info->si_lock, flags);
 }
 


             reply	other threads:[~2011-10-19  5:33 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-10-19  5:31 Srinivas_G_Gowda [this message]
2011-11-25 12:21 ` [PATCH] ipmi: This patch decreases the IPMI message transaction time in Interrupt mode Srinivas_G_Gowda

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4E9E60A1.4090408@dell.com \
    --to=srinivas_g_gowda@dell.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=minyard@acm.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox