From: Jonathan Cameron <jic23@cam.ac.uk>
To: Wolfram Sang <w.sang@pengutronix.de>
Cc: David Rientjes <rientjes@google.com>,
Joe Perches <joe@perches.com>, Andy Whitcroft <apw@canonical.com>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: checkpatch WARNING: patch prefix 'b' exists, appears to be a -p0 patch
Date: Wed, 19 Oct 2011 12:32:53 +0100 [thread overview]
Message-ID: <4E9EB565.8000500@cam.ac.uk> (raw)
In-Reply-To: <20111019112220.GG3217@pengutronix.de>
[-- Attachment #1: Type: text/plain, Size: 901 bytes --]
On 10/19/11 12:22, Wolfram Sang wrote:
>> Maybe something as simple as a comment in the checkpatch source
>> to say that such a file / directory can cause false positives?
>
> I'd hope this error message would be clear enough, what do you think?
Would have told me what was going on!
Acked-by: Jonathan Cameron <jic23@cam.ac.uk>
>
> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
> index 3dfc471..19e4de7 100755
> --- a/scripts/checkpatch.pl
> +++ b/scripts/checkpatch.pl
> @@ -1506,7 +1506,7 @@ sub process {
> if (!$file && $tree && $p1_prefix ne '' &&
> -e "$root/$p1_prefix") {
> WARN("PATCH_PREFIX",
> - "patch prefix '$p1_prefix' exists, appears to be a -p0 patch\n");
> + "patch prefix '$p1_prefix' exists as file/directory. Make sure this isn't a -p0 patch\n");
> }
>
> if ($realfile =~ m@^include/asm/@) {
>
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 900 bytes --]
next prev parent reply other threads:[~2011-10-19 11:32 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-18 15:03 checkpatch WARNING: patch prefix 'b' exists, appears to be a -p0 patch Jonathan Cameron
2011-10-18 23:44 ` David Rientjes
2011-10-19 0:01 ` Joe Perches
2011-10-19 1:27 ` David Rientjes
2011-10-19 8:27 ` Jonathan Cameron
2011-10-19 10:26 ` Wolfram Sang
2011-10-19 11:04 ` Jonathan Cameron
2011-10-19 11:22 ` Wolfram Sang
2011-10-19 11:32 ` Jonathan Cameron [this message]
2011-10-19 16:17 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E9EB565.8000500@cam.ac.uk \
--to=jic23@cam.ac.uk \
--cc=apw@canonical.com \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rientjes@google.com \
--cc=w.sang@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).