Re: [PATCH 12/21 v2] m68k: drop unused Kconfig symbols

[Greg Ungerer <gerg@snapgear.com>]

Hi Paul,

On 18/10/11 22:30, Paul Bolle wrote:
> On Tue, 2011-10-18 at 22:07 +1000, Greg Ungerer wrote:
>>> - dropped SOM5282EM too (discovered this while doing this second
>>>     version, my scripts aren't smart enough too catch it)
>>
>> Hmm. I don't want to lose the SOM5282EM config option. Although it
>> isn't used inside the code it does let the configurer know that this
>> specific board is supported.
>
> Isn't there another way? You're also adding a configuration option. This
> means your configurer has to make a decision whether or not to enable
> support for that board while this decision actually has no effect.

Yes, that is the idea. The configurer doesn't need to know it has
no effect (at least currently anyway). But they know that the board
is supported.


> Apparently that support comes for free (I'm guessing once M528x support
> is enabled, I haven't checked that). Wouldn't a comment do? Or adding a
> line to some help text?
>
> In the mean time I suppose you're willing to fix this part of my patch
> yourself (ie, I don't have to redo this again).

Yes, thats fine, I will fix it and apply.

Geert: are you ok with the changes?

Thanks
Greg


------------------------------------------------------------------------
Greg Ungerer  --  Principal Engineer        EMAIL:     gerg@snapgear.com
SnapGear Group, McAfee                      PHONE:       +61 7 3435 2888
8 Gardner Close                             FAX:         +61 7 3217 5323
Milton, QLD, 4064, Australia                WEB: http://www.SnapGear.com