From: Michal Marek <mmarek@suse.cz>
To: Adrian Bunk <bunk@stusta.de>
Cc: Ingo Molnar <mingo@elte.hu>,
Arjan van de Ven <arjan@infradead.org>,
Josh Triplett <josh@joshtriplett.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
linux-kernel@vger.kernel.org,
Frederic Weisbecker <fweisbec@gmail.com>,
Sam Ravnborg <sam@ravnborg.org>
Subject: Re: Please revert "debug: Make CONFIG_EXPERT select CONFIG_DEBUG_KERNEL to unhide debug options"
Date: Fri, 21 Oct 2011 14:37:13 +0200 [thread overview]
Message-ID: <4EA16779.7060006@suse.cz> (raw)
In-Reply-To: <20111021092249.GG9819@localhost.pp.htv.fi>
On 21.10.2011 11:22, Adrian Bunk wrote:
> On Fri, Oct 21, 2011 at 10:19:29AM +0200, Michal Marek wrote:
>> On 20.10.2011 23:41, Adrian Bunk wrote:
>>> Ingo, would you accept if I would go through the Kconfig files and
>>> monitor future changes to Kconfig files in the kernel (or if Michal does
>>> it, I don't insist that it has to be me if someone else wants to do it)?
>>
>> What kind of changes do you have in mind? Sorry, I haven't followed the
>> whole thread.
>
> Checking the correctness and making things more robust.
>
> An example:
>
> config KVM
> tristate "Kernel-based Virtual Machine (KVM) support"
> ...
> # for TASKSTATS/TASK_DELAY_ACCT:
> depends on NET
> ...
> select TASKSTATS
> select TASK_DELAY_ACCT
>
> That breaks if anyone touches the dependencies of TASKSTATS
> or TASK_DELAY_ACCT.
>
> It should be solved better, my first thought would be introducing
> something like a TASK_DELAY_ACCT_AVAILABLE variable.
Right, but that's a deficiency of the kconfig solver. Catalin Marinas
has patched it to at least print a warning if a dependency of a
select-ed symbol is not set. Ideally, we should get a better solver.
Michal
Michal
next prev parent reply other threads:[~2011-10-21 12:37 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-30 13:42 Please revert "debug: Make CONFIG_EXPERT select CONFIG_DEBUG_KERNEL to unhide debug options" Adrian Bunk
2011-09-30 15:05 ` Josh Triplett
2011-09-30 15:25 ` Frederic Weisbecker
2011-09-30 15:32 ` Frederic Weisbecker
2011-09-30 15:54 ` Adrian Bunk
2011-09-30 15:50 ` Adrian Bunk
2011-10-10 7:29 ` Ingo Molnar
2011-10-10 8:48 ` Adrian Bunk
2011-10-10 9:44 ` Mike Galbraith
2011-10-10 10:21 ` Ingo Molnar
2011-10-10 12:13 ` Adrian Bunk
2011-10-12 8:38 ` Ingo Molnar
2011-10-20 21:41 ` Adrian Bunk
2011-10-21 8:19 ` Michal Marek
2011-10-21 9:22 ` Adrian Bunk
2011-10-21 12:37 ` Michal Marek [this message]
2011-10-21 16:12 ` Adrian Bunk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4EA16779.7060006@suse.cz \
--to=mmarek@suse.cz \
--cc=arjan@infradead.org \
--cc=bunk@stusta.de \
--cc=fweisbec@gmail.com \
--cc=josh@joshtriplett.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=sam@ravnborg.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox