From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754954Ab1JXLG1 (ORCPT ); Mon, 24 Oct 2011 07:06:27 -0400 Received: from mx1.redhat.com ([209.132.183.28]:36310 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754829Ab1JXLG0 (ORCPT ); Mon, 24 Oct 2011 07:06:26 -0400 Message-ID: <4EA54694.5070703@redhat.com> Date: Mon, 24 Oct 2011 13:05:56 +0200 From: Avi Kivity User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:7.0.1) Gecko/20110930 Thunderbird/7.0.1 MIME-Version: 1.0 To: "Alex,Shi" CC: Christoph Lameter , "tj@kernel.org" , "linux-kernel@vger.kernel.org" , "eric.dumazet@gmail.com" , "Huang, Ying" , "tglx@linutronix.de" , "mingo@redhat.com" , "akpm@linux-foundation.org" , "davem@davemloft.net" , "kaber@trash.net" , "a.p.zijlstra@chello.nl" , "kvm@vger.kernel.org" , "jeremy@xensource.com" Subject: Re: [PATCH 2/3] kvm: use this_cpu_xxx replace percpu_xxx funcs References: <1318237851.27949.190.camel@debian> <1318324774.27949.693.camel@debian> <1318382964.27949.782.camel@debian> <1318428673.29699.13.camel@debian> <1318908091.23426.52.camel@debian> <1319016218.23426.104.camel@debian> <4E9E97D2.1040807@redhat.com> <1319096041.23426.182.camel@debian> <1319424608.5061.25.camel@debian> In-Reply-To: <1319424608.5061.25.camel@debian> X-Enigmail-Version: 1.3.2 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/24/2011 04:50 AM, Alex,Shi wrote: > On Thu, 2011-10-20 at 15:34 +0800, Alex,Shi wrote: > > percpu_xxx funcs are duplicated with this_cpu_xxx funcs, so replace them > > for further code clean up. > > > > And in preempt safe scenario, __this_cpu_xxx funcs has a bit better > > performance since __this_cpu_xxx has no redundant preempt_disable() > > > > Avi: > Would you like to give some comments of this? > Sorry, was travelling: Acked-by: Avi Kivity -- I have a truly marvellous patch that fixes the bug which this signature is too narrow to contain.