Re: [PATCH] acer-wmi: blacklist Thinkpad edge E520

[Ike Panhc <ike.pan@canonical.com>]

On 10/25/2011 07:13 AM, Dave Jones wrote:
> On Tue, Oct 25, 2011 at 06:22:47AM +0800, joeyli wrote:
>  > 於 四，2011-10-13 於 14:51 +0800，Ike Panhc 提到：
>  > > BugLink: http://launchpad.net/bugs/836865
>  > > BugLink: http://launchpad.net/bugs/826784
>  > > 
>  > > There are reports say that acer-wmi is loaded on Thinkpad E520 which
>  > > cause wireless connection hard blocked and we can not unblock it. It
>  > > will be better not to load acer-wmi on this machine.
>  > > 
>  > > Signed-off-by: Ike Panhc <ike.pan@canonical.com>
>  > > ---
>  > >  drivers/platform/x86/acer-wmi.c |    7 +++++++
>  > >  1 files changed, 7 insertions(+), 0 deletions(-)
>  > > 
>  > > diff --git a/drivers/platform/x86/acer-wmi.c b/drivers/platform/x86/acer-wmi.c
>  > > index af2bb20..dc9a116 100644
>  > > --- a/drivers/platform/x86/acer-wmi.c
>  > > +++ b/drivers/platform/x86/acer-wmi.c
>  > > @@ -325,6 +325,13 @@ static struct dmi_system_id __devinitdata acer_blacklist[] = {
>  > >  			DMI_MATCH(DMI_PRODUCT_NAME, "AOA150"),
>  > >  		},
>  > >  	},
>  > > +	{
>  > > +		.ident = "Lenovo Thinkpad Edge E520",
>  > > +		.matches = {
>  > > +			DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"),
>  > > +			DMI_MATCH(DMI_PRODUCT_NAME, "114320U"),
>  > > +		},
>  > > +	},
>  > >  	{}
>  > >  };
>  > >  
>  > 
>  > Unfortunately didn't see any useful EC register for unblock wifi rfkill in acer-wmi, let's 
>  > add this device to blacklist.
>  > 
>  > Signed-off-by: Lee, Chun-Yi <jlee@novell.com>
> 
> We've seen similar reports from other Lenovo machines & acer-wmi in Fedora bugzilla.
> https://bugzilla.redhat.com/show_bug.cgi?id=674353 for example has people reporting
> the b450 and V460 also suffer the same issue.
> 
> (There are also a bunch of bug reports from the other *-wmi modules on various hardware.
> It seems these modules really upset rfkill).
> 
> 	Dave
> 

I've tried to find a way to prevent acer-wmi loaded if VPC2004 found in DSDT. Thinking twice, seems to do this in kernel is not a good idea because if acer-wmi is necessary in one model of ideapads then we need to re-compile kernel for testing. I think it will be better to do this in udev if possible.