linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] acer-wmi: blacklist Thinkpad edge E520
@ 2011-10-13  6:51 Ike Panhc
  2011-10-13 16:35 ` joeyli
  2011-10-24 22:22 ` joeyli
  0 siblings, 2 replies; 10+ messages in thread
From: Ike Panhc @ 2011-10-13  6:51 UTC (permalink / raw)
  To: platform-driver-x86, linux-kernel; +Cc: Matthew Garrett, Joey Lee

BugLink: http://launchpad.net/bugs/836865
BugLink: http://launchpad.net/bugs/826784

There are reports say that acer-wmi is loaded on Thinkpad E520 which
cause wireless connection hard blocked and we can not unblock it. It
will be better not to load acer-wmi on this machine.

Signed-off-by: Ike Panhc <ike.pan@canonical.com>
---
 drivers/platform/x86/acer-wmi.c |    7 +++++++
 1 files changed, 7 insertions(+), 0 deletions(-)

diff --git a/drivers/platform/x86/acer-wmi.c b/drivers/platform/x86/acer-wmi.c
index af2bb20..dc9a116 100644
--- a/drivers/platform/x86/acer-wmi.c
+++ b/drivers/platform/x86/acer-wmi.c
@@ -325,6 +325,13 @@ static struct dmi_system_id __devinitdata acer_blacklist[] = {
 			DMI_MATCH(DMI_PRODUCT_NAME, "AOA150"),
 		},
 	},
+	{
+		.ident = "Lenovo Thinkpad Edge E520",
+		.matches = {
+			DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"),
+			DMI_MATCH(DMI_PRODUCT_NAME, "114320U"),
+		},
+	},
 	{}
 };
 
-- 
1.7.5.4


^ permalink raw reply related	[flat|nested] 10+ messages in thread

* Re: [PATCH] acer-wmi: blacklist Thinkpad edge E520
  2011-10-13  6:51 [PATCH] acer-wmi: blacklist Thinkpad edge E520 Ike Panhc
@ 2011-10-13 16:35 ` joeyli
  2011-10-14  2:48   ` Ike Panhc
  2011-10-24 22:22 ` joeyli
  1 sibling, 1 reply; 10+ messages in thread
From: joeyli @ 2011-10-13 16:35 UTC (permalink / raw)
  To: Ike Panhc; +Cc: platform-driver-x86, linux-kernel, Matthew Garrett, Joey Lee

Hi Ike, 

於 四,2011-10-13 於 14:51 +0800,Ike Panhc 提到:
> BugLink: http://launchpad.net/bugs/836865
> BugLink: http://launchpad.net/bugs/826784
> 
> There are reports say that acer-wmi is loaded on Thinkpad E520 which
> cause wireless connection hard blocked and we can not unblock it. It
> will be better not to load acer-wmi on this machine.
> 
> Signed-off-by: Ike Panhc <ike.pan@canonical.com>
> ---
>  drivers/platform/x86/acer-wmi.c |    7 +++++++
>  1 files changed, 7 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/platform/x86/acer-wmi.c b/drivers/platform/x86/acer-wmi.c
> index af2bb20..dc9a116 100644
> --- a/drivers/platform/x86/acer-wmi.c
> +++ b/drivers/platform/x86/acer-wmi.c
> @@ -325,6 +325,13 @@ static struct dmi_system_id __devinitdata acer_blacklist[] = {
>  			DMI_MATCH(DMI_PRODUCT_NAME, "AOA150"),
>  		},
>  	},
> +	{
> +		.ident = "Lenovo Thinkpad Edge E520",
> +		.matches = {
> +			DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"),
> +			DMI_MATCH(DMI_PRODUCT_NAME, "114320U"),
> +		},
> +	},
>  	{}
>  };
>  

Could you please share Thinkpad edge E520's acpidump and dmidecode log
to me? 
Maybe we can capture how does it works with EC register like we support
Ideapad S205 in acer-wmi driver.

Add a machine to blacklist is a last resort, I don't want to accept it
before we try.


Thank's a lot!
Joey Lee



^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH] acer-wmi: blacklist Thinkpad edge E520
  2011-10-13 16:35 ` joeyli
@ 2011-10-14  2:48   ` Ike Panhc
  2011-10-18  1:48     ` joeyli
  0 siblings, 1 reply; 10+ messages in thread
From: Ike Panhc @ 2011-10-14  2:48 UTC (permalink / raw)
  To: joeyli; +Cc: platform-driver-x86, linux-kernel, Matthew Garrett, Joey Lee

Hi Joey,

Here you are.

https://bugs.launchpad.net/ubuntu/+source/linux/+bug/836865/+attachment/2330828/+files/AcpiTables.txt


On 10/14/2011 12:35 AM, joeyli wrote:
> Hi Ike, 
> 
> 於 四,2011-10-13 於 14:51 +0800,Ike Panhc 提到:
>> BugLink: http://launchpad.net/bugs/836865
>> BugLink: http://launchpad.net/bugs/826784
>>
>> There are reports say that acer-wmi is loaded on Thinkpad E520 which
>> cause wireless connection hard blocked and we can not unblock it. It
>> will be better not to load acer-wmi on this machine.
>>
>> Signed-off-by: Ike Panhc <ike.pan@canonical.com>
>> ---
>>  drivers/platform/x86/acer-wmi.c |    7 +++++++
>>  1 files changed, 7 insertions(+), 0 deletions(-)
>>
>> diff --git a/drivers/platform/x86/acer-wmi.c b/drivers/platform/x86/acer-wmi.c
>> index af2bb20..dc9a116 100644
>> --- a/drivers/platform/x86/acer-wmi.c
>> +++ b/drivers/platform/x86/acer-wmi.c
>> @@ -325,6 +325,13 @@ static struct dmi_system_id __devinitdata acer_blacklist[] = {
>>  			DMI_MATCH(DMI_PRODUCT_NAME, "AOA150"),
>>  		},
>>  	},
>> +	{
>> +		.ident = "Lenovo Thinkpad Edge E520",
>> +		.matches = {
>> +			DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"),
>> +			DMI_MATCH(DMI_PRODUCT_NAME, "114320U"),
>> +		},
>> +	},
>>  	{}
>>  };
>>  
> 
> Could you please share Thinkpad edge E520's acpidump and dmidecode log
> to me? 
> Maybe we can capture how does it works with EC register like we support
> Ideapad S205 in acer-wmi driver.
> 
> Add a machine to blacklist is a last resort, I don't want to accept it
> before we try.
> 
> 
> Thank's a lot!
> Joey Lee
> 
> 
> --
> To unsubscribe from this list: send the line "unsubscribe platform-driver-x86" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 


^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH] acer-wmi: blacklist Thinkpad edge E520
  2011-10-14  2:48   ` Ike Panhc
@ 2011-10-18  1:48     ` joeyli
  2011-10-18  2:20       ` Ike Panhc
  0 siblings, 1 reply; 10+ messages in thread
From: joeyli @ 2011-10-18  1:48 UTC (permalink / raw)
  To: Ike Panhc; +Cc: platform-driver-x86, linux-kernel, Matthew Garrett, Joey Lee

Hi Ike, 

Could you please attached on the "rfkill list" output when press Fn key?
Then we can check the rfkill status change.

And, 
Thinkpad E520 have AMW0 method and I thought acer-wmi query wrong EC
register address so your acer-wireless was always soft-blocked.

Does it possible kindly help me to find out which register on E520 is
mapping to wireless status? Please reference to Carlos's acer_ec.pl
tool:

http://code.google.com/p/aceracpi/wiki/EmbeddedController

Simple use:
        watch -n 1 perl acer_ec.pl regs

Then press your wireless Fn key to monitor which register changed when
you press Fn key:

e.g. the register at row B0 and column 0A is register 0xBA (0x is used
to indicate this is a hexadecimal number).

There maybe have other EC register changing when you press key, please
do a couple of times and make sure you find out the right one.

If we are lucky, we can find out one EC register mapping to your
wireless state.


Thank's
Joey Lee

於 五,2011-10-14 於 10:48 +0800,Ike Panhc 提到:
> Hi Joey,
> 
> Here you are.
> 
> https://bugs.launchpad.net/ubuntu/+source/linux/+bug/836865/+attachment/2330828/+files/AcpiTables.txt
> 
> 
> On 10/14/2011 12:35 AM, joeyli wrote:
> > Hi Ike, 
> > 
> > 於 四,2011-10-13 於 14:51 +0800,Ike Panhc 提到:
> >> BugLink: http://launchpad.net/bugs/836865
> >> BugLink: http://launchpad.net/bugs/826784
> >>
> >> There are reports say that acer-wmi is loaded on Thinkpad E520 which
> >> cause wireless connection hard blocked and we can not unblock it. It
> >> will be better not to load acer-wmi on this machine.
> >>
> >> Signed-off-by: Ike Panhc <ike.pan@canonical.com>
> >> ---
> >>  drivers/platform/x86/acer-wmi.c |    7 +++++++
> >>  1 files changed, 7 insertions(+), 0 deletions(-)
> >>
> >> diff --git a/drivers/platform/x86/acer-wmi.c b/drivers/platform/x86/acer-wmi.c
> >> index af2bb20..dc9a116 100644
> >> --- a/drivers/platform/x86/acer-wmi.c
> >> +++ b/drivers/platform/x86/acer-wmi.c
> >> @@ -325,6 +325,13 @@ static struct dmi_system_id __devinitdata acer_blacklist[] = {
> >>  			DMI_MATCH(DMI_PRODUCT_NAME, "AOA150"),
> >>  		},
> >>  	},
> >> +	{
> >> +		.ident = "Lenovo Thinkpad Edge E520",
> >> +		.matches = {
> >> +			DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"),
> >> +			DMI_MATCH(DMI_PRODUCT_NAME, "114320U"),
> >> +		},
> >> +	},
> >>  	{}
> >>  };
> >>  
> > 
> > Could you please share Thinkpad edge E520's acpidump and dmidecode log
> > to me? 
> > Maybe we can capture how does it works with EC register like we support
> > Ideapad S205 in acer-wmi driver.
> > 
> > Add a machine to blacklist is a last resort, I don't want to accept it
> > before we try.
> > 
> > 
> > Thank's a lot!
> > Joey Lee
> > 
> > 
> > --
> > To unsubscribe from this list: send the line "unsubscribe platform-driver-x86" in
> > the body of a message to majordomo@vger.kernel.org
> > More majordomo info at  http://vger.kernel.org/majordomo-info.html
> > 
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/



^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH] acer-wmi: blacklist Thinkpad edge E520
  2011-10-18  1:48     ` joeyli
@ 2011-10-18  2:20       ` Ike Panhc
  2011-10-24 22:20         ` joeyli
  0 siblings, 1 reply; 10+ messages in thread
From: Ike Panhc @ 2011-10-18  2:20 UTC (permalink / raw)
  To: joeyli; +Cc: platform-driver-x86, linux-kernel, Matthew Garrett, Joey Lee

Hi Joey,

On 10/18/2011 09:48 AM, joeyli wrote:
> Hi Ike, 
> 
> Could you please attached on the "rfkill list" output when press Fn key?
> Then we can check the rfkill status change.

The output of rfkill list is at
  https://launchpadlibrarian.net/78485925/RfKill.txt

.. and bug reporter tells me that he can not unblock wireless.
  https://bugs.launchpad.net/ubuntu/+source/linux/+bug/836865/comments/0

> 
> And, 
> Thinkpad E520 have AMW0 method and I thought acer-wmi query wrong EC
> register address so your acer-wireless was always soft-blocked.
> 
> Does it possible kindly help me to find out which register on E520 is
> mapping to wireless status? Please reference to Carlos's acer_ec.pl
> tool:
> 
> http://code.google.com/p/aceracpi/wiki/EmbeddedController
> 
> Simple use:
>         watch -n 1 perl acer_ec.pl regs
> 
> Then press your wireless Fn key to monitor which register changed when
> you press Fn key:
> 
> e.g. the register at row B0 and column 0A is register 0xBA (0x is used
> to indicate this is a hexadecimal number).
> 
> There maybe have other EC register changing when you press key, please
> do a couple of times and make sure you find out the right one.
> 
> If we are lucky, we can find out one EC register mapping to your
> wireless state.

I've asked bug reporter to do so. Unfortunately nothing useful found.

Please refer to the link below:
  https://bugs.launchpad.net/ubuntu/+source/linux/+bug/836865/comments/13
  https://bugs.launchpad.net/ubuntu/+source/linux/+bug/836865/comments/14

The full discussion is at
  https://bugs.launchpad.net/ubuntu/+source/linux/+bug/836865

> 
> 
> Thank's
> Joey Lee
> 
> 於 五,2011-10-14 於 10:48 +0800,Ike Panhc 提到:
>> Hi Joey,
>>
>> Here you are.
>>
>> https://bugs.launchpad.net/ubuntu/+source/linux/+bug/836865/+attachment/2330828/+files/AcpiTables.txt
>>
>>
>> On 10/14/2011 12:35 AM, joeyli wrote:
>>> Hi Ike, 
>>>
>>> 於 四,2011-10-13 於 14:51 +0800,Ike Panhc 提到:
>>>> BugLink: http://launchpad.net/bugs/836865
>>>> BugLink: http://launchpad.net/bugs/826784
>>>>
>>>> There are reports say that acer-wmi is loaded on Thinkpad E520 which
>>>> cause wireless connection hard blocked and we can not unblock it. It
>>>> will be better not to load acer-wmi on this machine.
>>>>
>>>> Signed-off-by: Ike Panhc <ike.pan@canonical.com>
>>>> ---
>>>>  drivers/platform/x86/acer-wmi.c |    7 +++++++
>>>>  1 files changed, 7 insertions(+), 0 deletions(-)
>>>>
>>>> diff --git a/drivers/platform/x86/acer-wmi.c b/drivers/platform/x86/acer-wmi.c
>>>> index af2bb20..dc9a116 100644
>>>> --- a/drivers/platform/x86/acer-wmi.c
>>>> +++ b/drivers/platform/x86/acer-wmi.c
>>>> @@ -325,6 +325,13 @@ static struct dmi_system_id __devinitdata acer_blacklist[] = {
>>>>  			DMI_MATCH(DMI_PRODUCT_NAME, "AOA150"),
>>>>  		},
>>>>  	},
>>>> +	{
>>>> +		.ident = "Lenovo Thinkpad Edge E520",
>>>> +		.matches = {
>>>> +			DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"),
>>>> +			DMI_MATCH(DMI_PRODUCT_NAME, "114320U"),
>>>> +		},
>>>> +	},
>>>>  	{}
>>>>  };
>>>>  
>>>
>>> Could you please share Thinkpad edge E520's acpidump and dmidecode log
>>> to me? 
>>> Maybe we can capture how does it works with EC register like we support
>>> Ideapad S205 in acer-wmi driver.
>>>
>>> Add a machine to blacklist is a last resort, I don't want to accept it
>>> before we try.
>>>
>>>
>>> Thank's a lot!
>>> Joey Lee
>>>
>>>
>>> --
>>> To unsubscribe from this list: send the line "unsubscribe platform-driver-x86" in
>>> the body of a message to majordomo@vger.kernel.org
>>> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>>>
>>
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
>> the body of a message to majordomo@vger.kernel.org
>> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>> Please read the FAQ at  http://www.tux.org/lkml/
> 
> 
> --
> To unsubscribe from this list: send the line "unsubscribe platform-driver-x86" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 


^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH] acer-wmi: blacklist Thinkpad edge E520
  2011-10-18  2:20       ` Ike Panhc
@ 2011-10-24 22:20         ` joeyli
  0 siblings, 0 replies; 10+ messages in thread
From: joeyli @ 2011-10-24 22:20 UTC (permalink / raw)
  To: Ike Panhc; +Cc: platform-driver-x86, linux-kernel, Matthew Garrett, Joey Lee

Hi Ike, 

於 二,2011-10-18 於 10:20 +0800,Ike Panhc 提到:
> Hi Joey,
> 
> On 10/18/2011 09:48 AM, joeyli wrote:
> > Hi Ike, 
> > 
> > Could you please attached on the "rfkill list" output when press Fn key?
> > Then we can check the rfkill status change.
> 
> The output of rfkill list is at
>   https://launchpadlibrarian.net/78485925/RfKill.txt
> 
> .. and bug reporter tells me that he can not unblock wireless.
>   https://bugs.launchpad.net/ubuntu/+source/linux/+bug/836865/comments/0
> 
> > 
> > And, 
> > Thinkpad E520 have AMW0 method and I thought acer-wmi query wrong EC
> > register address so your acer-wireless was always soft-blocked.
> > 
> > Does it possible kindly help me to find out which register on E520 is
> > mapping to wireless status? Please reference to Carlos's acer_ec.pl
> > tool:
> > 
> > http://code.google.com/p/aceracpi/wiki/EmbeddedController
> > 
> > Simple use:
> >         watch -n 1 perl acer_ec.pl regs
> > 
> > Then press your wireless Fn key to monitor which register changed when
> > you press Fn key:
> > 
> > e.g. the register at row B0 and column 0A is register 0xBA (0x is used
> > to indicate this is a hexadecimal number).
> > 
> > There maybe have other EC register changing when you press key, please
> > do a couple of times and make sure you find out the right one.
> > 
> > If we are lucky, we can find out one EC register mapping to your
> > wireless state.
> 
> I've asked bug reporter to do so. Unfortunately nothing useful found.
> 
> Please refer to the link below:
>   https://bugs.launchpad.net/ubuntu/+source/linux/+bug/836865/comments/13
>   https://bugs.launchpad.net/ubuntu/+source/linux/+bug/836865/comments/14
> 
> The full discussion is at
>   https://bugs.launchpad.net/ubuntu/+source/linux/+bug/836865
> 

Bad! 

I also didn't see useful things from DSDT, looks like the control
doesn't through EC.

Let's add this device to blacklist!


Thank's
Joey Lee



^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH] acer-wmi: blacklist Thinkpad edge E520
  2011-10-13  6:51 [PATCH] acer-wmi: blacklist Thinkpad edge E520 Ike Panhc
  2011-10-13 16:35 ` joeyli
@ 2011-10-24 22:22 ` joeyli
  2011-10-24 23:13   ` Dave Jones
  1 sibling, 1 reply; 10+ messages in thread
From: joeyli @ 2011-10-24 22:22 UTC (permalink / raw)
  To: Ike Panhc; +Cc: platform-driver-x86, linux-kernel, Matthew Garrett, Joey Lee

於 四,2011-10-13 於 14:51 +0800,Ike Panhc 提到:
> BugLink: http://launchpad.net/bugs/836865
> BugLink: http://launchpad.net/bugs/826784
> 
> There are reports say that acer-wmi is loaded on Thinkpad E520 which
> cause wireless connection hard blocked and we can not unblock it. It
> will be better not to load acer-wmi on this machine.
> 
> Signed-off-by: Ike Panhc <ike.pan@canonical.com>
> ---
>  drivers/platform/x86/acer-wmi.c |    7 +++++++
>  1 files changed, 7 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/platform/x86/acer-wmi.c b/drivers/platform/x86/acer-wmi.c
> index af2bb20..dc9a116 100644
> --- a/drivers/platform/x86/acer-wmi.c
> +++ b/drivers/platform/x86/acer-wmi.c
> @@ -325,6 +325,13 @@ static struct dmi_system_id __devinitdata acer_blacklist[] = {
>  			DMI_MATCH(DMI_PRODUCT_NAME, "AOA150"),
>  		},
>  	},
> +	{
> +		.ident = "Lenovo Thinkpad Edge E520",
> +		.matches = {
> +			DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"),
> +			DMI_MATCH(DMI_PRODUCT_NAME, "114320U"),
> +		},
> +	},
>  	{}
>  };
>  

Unfortunately didn't see any useful EC register for unblock wifi rfkill in acer-wmi, let's 
add this device to blacklist.

Signed-off-by: Lee, Chun-Yi <jlee@novell.com>


Thank's a lot!
Joey Lee


^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH] acer-wmi: blacklist Thinkpad edge E520
  2011-10-24 22:22 ` joeyli
@ 2011-10-24 23:13   ` Dave Jones
  2011-10-25  2:57     ` Ike Panhc
  2011-11-06  9:29     ` joeyli
  0 siblings, 2 replies; 10+ messages in thread
From: Dave Jones @ 2011-10-24 23:13 UTC (permalink / raw)
  To: joeyli
  Cc: Ike Panhc, platform-driver-x86, linux-kernel, Matthew Garrett,
	Joey Lee

On Tue, Oct 25, 2011 at 06:22:47AM +0800, joeyli wrote:
 > 於 四,2011-10-13 於 14:51 +0800,Ike Panhc 提到:
 > > BugLink: http://launchpad.net/bugs/836865
 > > BugLink: http://launchpad.net/bugs/826784
 > > 
 > > There are reports say that acer-wmi is loaded on Thinkpad E520 which
 > > cause wireless connection hard blocked and we can not unblock it. It
 > > will be better not to load acer-wmi on this machine.
 > > 
 > > Signed-off-by: Ike Panhc <ike.pan@canonical.com>
 > > ---
 > >  drivers/platform/x86/acer-wmi.c |    7 +++++++
 > >  1 files changed, 7 insertions(+), 0 deletions(-)
 > > 
 > > diff --git a/drivers/platform/x86/acer-wmi.c b/drivers/platform/x86/acer-wmi.c
 > > index af2bb20..dc9a116 100644
 > > --- a/drivers/platform/x86/acer-wmi.c
 > > +++ b/drivers/platform/x86/acer-wmi.c
 > > @@ -325,6 +325,13 @@ static struct dmi_system_id __devinitdata acer_blacklist[] = {
 > >  			DMI_MATCH(DMI_PRODUCT_NAME, "AOA150"),
 > >  		},
 > >  	},
 > > +	{
 > > +		.ident = "Lenovo Thinkpad Edge E520",
 > > +		.matches = {
 > > +			DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"),
 > > +			DMI_MATCH(DMI_PRODUCT_NAME, "114320U"),
 > > +		},
 > > +	},
 > >  	{}
 > >  };
 > >  
 > 
 > Unfortunately didn't see any useful EC register for unblock wifi rfkill in acer-wmi, let's 
 > add this device to blacklist.
 > 
 > Signed-off-by: Lee, Chun-Yi <jlee@novell.com>

We've seen similar reports from other Lenovo machines & acer-wmi in Fedora bugzilla.
https://bugzilla.redhat.com/show_bug.cgi?id=674353 for example has people reporting
the b450 and V460 also suffer the same issue.

(There are also a bunch of bug reports from the other *-wmi modules on various hardware.
It seems these modules really upset rfkill).

	Dave


^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH] acer-wmi: blacklist Thinkpad edge E520
  2011-10-24 23:13   ` Dave Jones
@ 2011-10-25  2:57     ` Ike Panhc
  2011-11-06  9:29     ` joeyli
  1 sibling, 0 replies; 10+ messages in thread
From: Ike Panhc @ 2011-10-25  2:57 UTC (permalink / raw)
  To: Dave Jones, joeyli, platform-driver-x86, linux-kernel,
	Matthew Garrett, Joey Lee

On 10/25/2011 07:13 AM, Dave Jones wrote:
> On Tue, Oct 25, 2011 at 06:22:47AM +0800, joeyli wrote:
>  > 於 四,2011-10-13 於 14:51 +0800,Ike Panhc 提到:
>  > > BugLink: http://launchpad.net/bugs/836865
>  > > BugLink: http://launchpad.net/bugs/826784
>  > > 
>  > > There are reports say that acer-wmi is loaded on Thinkpad E520 which
>  > > cause wireless connection hard blocked and we can not unblock it. It
>  > > will be better not to load acer-wmi on this machine.
>  > > 
>  > > Signed-off-by: Ike Panhc <ike.pan@canonical.com>
>  > > ---
>  > >  drivers/platform/x86/acer-wmi.c |    7 +++++++
>  > >  1 files changed, 7 insertions(+), 0 deletions(-)
>  > > 
>  > > diff --git a/drivers/platform/x86/acer-wmi.c b/drivers/platform/x86/acer-wmi.c
>  > > index af2bb20..dc9a116 100644
>  > > --- a/drivers/platform/x86/acer-wmi.c
>  > > +++ b/drivers/platform/x86/acer-wmi.c
>  > > @@ -325,6 +325,13 @@ static struct dmi_system_id __devinitdata acer_blacklist[] = {
>  > >  			DMI_MATCH(DMI_PRODUCT_NAME, "AOA150"),
>  > >  		},
>  > >  	},
>  > > +	{
>  > > +		.ident = "Lenovo Thinkpad Edge E520",
>  > > +		.matches = {
>  > > +			DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"),
>  > > +			DMI_MATCH(DMI_PRODUCT_NAME, "114320U"),
>  > > +		},
>  > > +	},
>  > >  	{}
>  > >  };
>  > >  
>  > 
>  > Unfortunately didn't see any useful EC register for unblock wifi rfkill in acer-wmi, let's 
>  > add this device to blacklist.
>  > 
>  > Signed-off-by: Lee, Chun-Yi <jlee@novell.com>
> 
> We've seen similar reports from other Lenovo machines & acer-wmi in Fedora bugzilla.
> https://bugzilla.redhat.com/show_bug.cgi?id=674353 for example has people reporting
> the b450 and V460 also suffer the same issue.
> 
> (There are also a bunch of bug reports from the other *-wmi modules on various hardware.
> It seems these modules really upset rfkill).
> 
> 	Dave
> 

I've tried to find a way to prevent acer-wmi loaded if VPC2004 found in DSDT. Thinking twice, seems to do this in kernel is not a good idea because if acer-wmi is necessary in one model of ideapads then we need to re-compile kernel for testing. I think it will be better to do this in udev if possible.

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH] acer-wmi: blacklist Thinkpad edge E520
  2011-10-24 23:13   ` Dave Jones
  2011-10-25  2:57     ` Ike Panhc
@ 2011-11-06  9:29     ` joeyli
  1 sibling, 0 replies; 10+ messages in thread
From: joeyli @ 2011-11-06  9:29 UTC (permalink / raw)
  To: Dave Jones
  Cc: Ike Panhc, platform-driver-x86, linux-kernel, Matthew Garrett,
	Joey Lee

Hi Dave, 

Sorry for I am late to reply you!

於 一,2011-10-24 於 19:13 -0400,Dave Jones 提到:
> On Tue, Oct 25, 2011 at 06:22:47AM +0800, joeyli wrote:
>  > 於 四,2011-10-13 於 14:51 +0800,Ike Panhc 提到:
>  > > BugLink: http://launchpad.net/bugs/836865
>  > > BugLink: http://launchpad.net/bugs/826784
>  > > 
>  > > There are reports say that acer-wmi is loaded on Thinkpad E520 which
>  > > cause wireless connection hard blocked and we can not unblock it. It
>  > > will be better not to load acer-wmi on this machine.
>  > > 
>  > > Signed-off-by: Ike Panhc <ike.pan@canonical.com>
>  > > ---
>  > >  drivers/platform/x86/acer-wmi.c |    7 +++++++
>  > >  1 files changed, 7 insertions(+), 0 deletions(-)
>  > > 
>  > > diff --git a/drivers/platform/x86/acer-wmi.c b/drivers/platform/x86/acer-wmi.c
>  > > index af2bb20..dc9a116 100644
>  > > --- a/drivers/platform/x86/acer-wmi.c
>  > > +++ b/drivers/platform/x86/acer-wmi.c
>  > > @@ -325,6 +325,13 @@ static struct dmi_system_id __devinitdata acer_blacklist[] = {
>  > >  			DMI_MATCH(DMI_PRODUCT_NAME, "AOA150"),
>  > >  		},
>  > >  	},
>  > > +	{
>  > > +		.ident = "Lenovo Thinkpad Edge E520",
>  > > +		.matches = {
>  > > +			DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"),
>  > > +			DMI_MATCH(DMI_PRODUCT_NAME, "114320U"),
>  > > +		},
>  > > +	},
>  > >  	{}
>  > >  };
>  > >  
>  > 
>  > Unfortunately didn't see any useful EC register for unblock wifi rfkill in acer-wmi, let's 
>  > add this device to blacklist.
>  > 
>  > Signed-off-by: Lee, Chun-Yi <jlee@novell.com>
> 
> We've seen similar reports from other Lenovo machines & acer-wmi in Fedora bugzilla.
> https://bugzilla.redhat.com/show_bug.cgi?id=674353 for example has people reporting
> the b450 and V460 also suffer the same issue.
> 
> (There are also a bunch of bug reports from the other *-wmi modules on various hardware.
> It seems these modules really upset rfkill).
> 
> 	Dave
> 

I just go to brc#674353 to check the DSDT from B450, I thought we can
try the wireless quirk type 2 (offset 0x71 in EC OperationRegion), I
will attach a patch to redhat bugzilla, let's talk on bugzilla.

And, 
I didn't see the DSDT from Lenovo V640, maybe we also can find out a
useful EC register reflect to wireless status.


Thank's a lot!
Joey Lee



^ permalink raw reply	[flat|nested] 10+ messages in thread

end of thread, other threads:[~2011-11-06  9:30 UTC | newest]

Thread overview: 10+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-10-13  6:51 [PATCH] acer-wmi: blacklist Thinkpad edge E520 Ike Panhc
2011-10-13 16:35 ` joeyli
2011-10-14  2:48   ` Ike Panhc
2011-10-18  1:48     ` joeyli
2011-10-18  2:20       ` Ike Panhc
2011-10-24 22:20         ` joeyli
2011-10-24 22:22 ` joeyli
2011-10-24 23:13   ` Dave Jones
2011-10-25  2:57     ` Ike Panhc
2011-11-06  9:29     ` joeyli

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).