From: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
To: Kyle Moffett <Kyle.D.Moffett@boeing.com>
Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
"David S. Miller" <davem@davemloft.net>,
Nobuhiro Iwamatsu <nobuhiro.iwamatsu.yj@renesas.com>,
Kuninori Morimoto <morimoto.kuninori@renesas.com>
Subject: Re: [RFC PATCH 11/17] sh_eth: Don't unnecessarily reset the PHY
Date: Tue, 25 Oct 2011 20:11:46 +0900 [thread overview]
Message-ID: <4EA69972.4090004@renesas.com> (raw)
In-Reply-To: <1319144425-15547-12-git-send-email-Kyle.D.Moffett@boeing.com>
Hi,
2011/10/21 6:00, Kyle Moffett wrote:
> The PHY is already reset during driver probing, and this manual reset
> afterwards will wipe out board-specific PHY fixups and driver-specific
> phy->drv->config_init() register tweaks.
Thank you for your patch. I think so.
However, the patch cannot work correctly on my environment.
> Signed-off-by: Kyle Moffett <Kyle.D.Moffett@boeing.com>
> ---
> drivers/net/sh_eth.c | 19 +------------------
> 1 files changed, 1 insertions(+), 18 deletions(-)
>
> diff --git a/drivers/net/sh_eth.c b/drivers/net/sh_eth.c
> index 1c1666e..7ef4378 100644
> --- a/drivers/net/sh_eth.c
> +++ b/drivers/net/sh_eth.c
> @@ -1235,23 +1235,6 @@ static int sh_eth_phy_init(struct net_device *ndev)
> return 0;
> }
>
> -/* PHY control start function */
> -static int sh_eth_phy_start(struct net_device *ndev)
> -{
> - struct sh_eth_private *mdp = netdev_priv(ndev);
> - int ret;
> -
> - ret = sh_eth_phy_init(ndev);
> - if (ret)
> - return ret;
> -
> - /* reset phy - this also wakes it from PDOWN */
> - phy_write(mdp->phydev, MII_BMCR, BMCR_RESET);
> - phy_start(mdp->phydev);
I think that the driver needs the phy_start().
So, I removed the phy_write() only. Then, the driver could work correctly.
Therefore, I would to remove the following code only.
Do you think about this?
> - /* reset phy - this also wakes it from PDOWN */
> - phy_write(mdp->phydev, MII_BMCR, BMCR_RESET);
Thanks,
Yoshihiro Shimoda
next prev parent reply other threads:[~2011-10-25 11:11 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-20 21:00 [RFC PATCH 0/17] Miscellaneous generic PHY layer improvements Kyle Moffett
2011-10-20 21:00 ` [RFC PATCH 01/17] et1011c: Replaced PHY driver by a small dm646x board fixup Kyle Moffett
2011-10-20 21:00 ` [RFC PATCH 02/17] of_mdio: Don't phy_scan_fixups() twice Kyle Moffett
2011-10-25 4:56 ` Grant Likely
2011-10-20 21:00 ` [RFC PATCH 03/17] greth: Allow PHYs to override ->read_status Kyle Moffett
2011-10-20 21:00 ` [RFC PATCH 04/17] phy/icplus: Fix read_status/config_aneg error handling Kyle Moffett
2011-10-20 21:00 ` [RFC PATCH 05/17] phy_driver: Make .read_status()/.config_aneg() optional Kyle Moffett
2011-10-20 21:10 ` Mike Frysinger
2011-10-20 21:14 ` Mike Frysinger
2011-10-21 5:13 ` Kyle Moffett
2011-10-25 7:06 ` Mike Frysinger
2011-10-20 21:00 ` [RFC PATCH 06/17] phy_driver: Add and use phy_driver_[un]register_multiple() Kyle Moffett
2011-10-20 21:15 ` Mike Frysinger
2011-10-25 5:00 ` Grant Likely
2011-10-25 5:41 ` Mike Frysinger
2011-11-03 22:46 ` Andy Fleming
2011-10-20 21:00 ` [RFC PATCH 07/17] phy: Unify PHY reset, initialization, and fixup handling Kyle Moffett
2011-10-20 21:00 ` [RFC PATCH 08/17] drivers/net/bfin_mac: Don't unnecessarily reset the PHY Kyle Moffett
2011-10-25 6:59 ` Mike Frysinger
2011-10-25 7:26 ` Zhang, Sonic
2011-10-20 21:00 ` [RFC PATCH 09/17] mv643xx_eth: Use standardized phy_init_hw() for PHY reset Kyle Moffett
2011-10-20 21:00 ` [RFC PATCH 10/17] pxa186_eth: " Kyle Moffett
2011-10-20 21:00 ` [RFC PATCH 11/17] sh_eth: Don't unnecessarily reset the PHY Kyle Moffett
2011-10-25 11:11 ` Yoshihiro Shimoda [this message]
2011-10-25 16:00 ` Moffett, Kyle D
2011-10-20 21:00 ` [RFC PATCH 12/17] tc35815: Use standard phy_init_hw() instead of BMCR_RESET bit Kyle Moffett
2011-10-20 21:00 ` [RFC PATCH 13/17] mpc836x: Move board-specific bcm5481 fixup out of the PHY driver Kyle Moffett
2011-10-20 21:00 ` [RFC PATCH 14/17] lxt973: Clean up fixed-mode fiber PHY handling Kyle Moffett
2011-10-20 21:00 ` [RFC PATCH 15/17] phy_device: Add "port" and "transciever" fields Kyle Moffett
2011-10-20 23:27 ` Ben Hutchings
2011-10-21 7:12 ` Kyle Moffett
2011-10-20 21:00 ` [RFC PATCH 16/17] phy_device: Add phy_setmask helper function Kyle Moffett
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4EA69972.4090004@renesas.com \
--to=yoshihiro.shimoda.uh@renesas.com \
--cc=Kyle.D.Moffett@boeing.com \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=morimoto.kuninori@renesas.com \
--cc=netdev@vger.kernel.org \
--cc=nobuhiro.iwamatsu.yj@renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).