From: Eial Czerwacki <eial@scalemp.com>
To: David Rientjes <rientjes@google.com>
Cc: linux-kernel@vger.kernel.org,
"Shai Fultheim (Shai@ScaleMP.com)" <Shai@scalemp.com>
Subject: Re: [PATCH] APICID: Avoid false sharing on the read mostly x86_cpu_to_apicid
Date: Wed, 26 Oct 2011 09:01:24 +0200 [thread overview]
Message-ID: <4EA7B044.5030200@scalemp.com> (raw)
In-Reply-To: <alpine.DEB.2.00.1110252345260.20273@chino.kir.corp.google.com>
On 10/26/2011 08:47 AM, David Rientjes wrote:
> On Wed, 26 Oct 2011, Eial Czerwacki wrote:
>
>>>> Signed-off-by: Eial Czerwacki<eial@scalemp.com>
>>>> Signed-off-by: Shai Fultheim<shai@scalemp.com>
>>>> Author: Ravikiran Thirumalai<kiran@scalex86.org>
>>>
>>> If the author isn't you, then the patch should start with a single line
>>> that says "From: name <email>" of the author followed by a blank line.
>>> It's also strange that the author doesn't have a sign-off line.
>>>
>>
>>
>> the author is mentioned after the last sign-off.
>>
>
> That's not the way it's done, as I said, the patch needs to start with a
> single line like this:
>
> From: Ravikiran Thirumalai <kiran@scalex86.org>
>
> ...
>
> and if that person signed it off, then it needs to appear as
>
> Signed-off-by: ...
>
> as the first one in the chain. Please see part 15 of section 1 of
> Documentation/SubmittingPatches.
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
>
sure, thanks got the info
Eial.
next prev parent reply other threads:[~2011-10-26 7:01 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <4EA66960.7050907@scalemp.com>
[not found] ` <9B14D1490DDECA4E974F6B9FC9EBAB3140CD274367@VMBX108.ihostexchange.net>
2011-10-25 11:49 ` [PATCH] APICID: Avoid false sharing on the read mostly x86_cpu_to_apicid Eial Czerwacki
2011-10-26 6:21 ` David Rientjes
2011-10-26 6:41 ` Eial Czerwacki
2011-10-26 6:47 ` David Rientjes
2011-10-26 7:01 ` Eial Czerwacki [this message]
2011-10-26 8:20 ` Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4EA7B044.5030200@scalemp.com \
--to=eial@scalemp.com \
--cc=Shai@scalemp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rientjes@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).