From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933637Ab1JZShT (ORCPT ); Wed, 26 Oct 2011 14:37:19 -0400 Received: from oproxy9.bluehost.com ([69.89.24.6]:48099 "HELO oproxy9.bluehost.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1755038Ab1JZShQ (ORCPT ); Wed, 26 Oct 2011 14:37:16 -0400 Message-ID: <4EA85353.4060101@xenotime.net> Date: Wed, 26 Oct 2011 11:37:07 -0700 From: Randy Dunlap Organization: YPO4 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:7.0.1) Gecko/20111001 Thunderbird/7.0.1 MIME-Version: 1.0 To: Stephen Rothwell CC: linux-next@vger.kernel.org, LKML , Linus , "linux-pci@vger.kernel.org" , Joerg Roedel , Yu Zhao Subject: Re: linux-next: Tree for Oct 25 (pci/ats.c) References: <20111025203628.40a1b8a475e32053aa34dabe@canb.auug.org.au> In-Reply-To: <20111025203628.40a1b8a475e32053aa34dabe@canb.auug.org.au> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-Identified-User: {1807:box742.bluehost.com:xenotime:xenotime.net} {sentby:smtp auth 50.53.38.135 authed with rdunlap@xenotime.net} Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/25/11 02:36, Stephen Rothwell wrote: > Hi all, When CONFIG_PCI_IOV is not enabled: (probably because PCI_PRI selects PCI_ATS even when PCI_IOV is not enabled) drivers/pci/ats.c:37:5: error: 'struct pci_dev' has no member named 'ats' drivers/pci/ats.c:44:11: error: 'struct pci_dev' has no member named 'ats' drivers/pci/ats.c:45:5: error: 'struct pci_dev' has no member named 'ats' drivers/pci/ats.c:55:5: error: redefinition of 'pci_enable_ats' drivers/pci/ats.c:60:2: error: 'struct pci_dev' has no member named 'ats' drivers/pci/ats.c:60:2: error: 'struct pci_dev' has no member named 'ats' drivers/pci/ats.c:66:52: error: 'struct pci_dev' has no member named 'physfn' drivers/pci/ats.c:68:3: error: 'struct pci_dev' has no member named 'sriov' drivers/pci/ats.c:69:11: error: 'struct pci_dev' has no member named 'ats' drivers/pci/ats.c:70:13: error: 'struct pci_dev' has no member named 'ats' drivers/pci/ats.c:75:8: error: 'struct pci_dev' has no member named 'ats' drivers/pci/ats.c:76:21: error: 'struct pci_dev' has no member named 'sriov' drivers/pci/ats.c:90:32: error: 'struct pci_dev' has no member named 'ats' drivers/pci/ats.c:92:5: error: 'struct pci_dev' has no member named 'ats' drivers/pci/ats.c:102:6: error: redefinition of 'pci_disable_ats' drivers/pci/ats.c:106:2: error: 'struct pci_dev' has no member named 'ats' drivers/pci/ats.c:106:2: error: 'struct pci_dev' has no member named 'ats' drivers/pci/ats.c:108:31: error: 'struct pci_dev' has no member named 'ats' drivers/pci/ats.c:110:32: error: 'struct pci_dev' has no member named 'ats' drivers/pci/ats.c:112:5: error: 'struct pci_dev' has no member named 'ats' drivers/pci/ats.c:115:52: error: 'struct pci_dev' has no member named 'physfn' drivers/pci/ats.c:117:3: error: 'struct pci_dev' has no member named 'sriov' drivers/pci/ats.c:118:7: error: 'struct pci_dev' has no member named 'ats' drivers/pci/ats.c:119:12: error: 'struct pci_dev' has no member named 'ats' drivers/pci/ats.c:121:21: error: 'struct pci_dev' has no member named 'sriov' drivers/pci/ats.c:141:5: error: redefinition of 'pci_ats_queue_depth' drivers/pci/ats.c:149:9: error: 'struct pci_dev' has no member named 'ats' next-2011-1025/drivers/pci/ats.c:150:13: error: 'struct pci_dev' has no member named 'ats' Looks like ats.c also needs to #include : drivers/pci/ats.c:96:1: warning: type defaults to 'int' in declaration of 'EXPORT_SYMBOL_GPL' [-Wimplicit-int] drivers/pci/ats.c:127:1: warning: type defaults to 'int' in declaration of 'EXPORT_SYMBOL_GPL' [-Wimplicit-int] drivers/pci/ats.c:161:1: warning: type defaults to 'int' in declaration of 'EXPORT_SYMBOL_GPL' [-Wimplicit-int] drivers/pci/ats.c:194:1: warning: type defaults to 'int' in declaration of 'EXPORT_SYMBOL_GPL' [-Wimplicit-int] drivers/pci/ats.c:215:1: warning: type defaults to 'int' in declaration of 'EXPORT_SYMBOL_GPL' [-Wimplicit-int] drivers/pci/ats.c:236:1: warning: type defaults to 'int' in declaration of 'EXPORT_SYMBOL_GPL' [-Wimplicit-int] drivers/pci/ats.c:264:1: warning: type defaults to 'int' in declaration of 'EXPORT_SYMBOL_GPL' [-Wimplicit-int] drivers/pci/ats.c:295:1: warning: type defaults to 'int' in declaration of 'EXPORT_SYMBOL_GPL' [-Wimplicit-int] drivers/pci/ats.c:325:1: warning: type defaults to 'int' in declaration of 'EXPORT_SYMBOL_GPL' [-Wimplicit-int] -- ~Randy *** Remember to use Documentation/SubmitChecklist when testing your code ***