From: Adam Jackson <ajax@redhat.com>
To: Jesse Barnes <jbarnes@virtuousgeek.org>
Cc: Keith Packard <keithp@keithp.com>,
intel-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org,
dri-devel@lists.freedesktop.org
Subject: Re: [Intel-gfx] [PATCH 3/7] drm/i915: Treat PCH eDP like DP in most places
Date: Wed, 02 Nov 2011 13:13:52 -0400 [thread overview]
Message-ID: <4EB17A50.6050804@redhat.com> (raw)
In-Reply-To: <20111102092019.3a635632@jbarnes-desktop>
On 11/2/11 12:20 PM, Jesse Barnes wrote:
> @@ -766,10 +766,10 @@ intel_dp_set_m_n(struct drm_crtc *crtc, struct drm_display_mode *mode,
> continue;
>
> intel_dp = enc_to_intel_dp(encoder);
> - if (intel_dp->base.type == INTEL_OUTPUT_DISPLAYPORT) {
> + if (intel_dp->base.type == INTEL_OUTPUT_DISPLAYPORT || is_pch_edp(intel_dp)) {
> lane_count = intel_dp->lane_count;
> break;
> - } else if (is_edp(intel_dp)) {
> + } else if (is_cpu_edp(intel_dp)) {
> lane_count = dev_priv->edp.lanes;
> break;
> }
>
> I guess this means we can't trust the BIOS settings for PCH eDP?
Given the choice of trusting DPCD or the VBT, I'd definitely prefer DPCD.
- ajax
next prev parent reply other threads:[~2011-11-02 17:13 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-02 6:20 [PATCH 0/7] drm/i915: Fix PCH eDP support for SNB Keith Packard
2011-11-02 6:20 ` [PATCH 1/7] drm/i915: Move common PCH_PP_CONTROL setup to ironlake_get_pp_control Keith Packard
2011-11-02 16:02 ` [Intel-gfx] " Jesse Barnes
2011-11-02 16:13 ` Keith Packard
2011-11-02 6:20 ` [PATCH 2/7] drm/i915: Remove link_status field from intel_dp structure Keith Packard
2011-11-02 16:13 ` [Intel-gfx] " Jesse Barnes
2011-11-02 6:20 ` [PATCH 3/7] drm/i915: Treat PCH eDP like DP in most places Keith Packard
2011-11-02 15:29 ` [Intel-gfx] " Adam Jackson
2011-11-02 16:55 ` Keith Packard
2011-11-02 17:35 ` Keith Packard
2011-11-02 16:20 ` Jesse Barnes
2011-11-02 17:10 ` Keith Packard
2011-11-02 17:13 ` Adam Jackson [this message]
2011-11-02 17:31 ` Keith Packard
2011-11-02 19:36 ` Adam Jackson
2011-11-02 20:05 ` Keith Packard
2011-11-02 20:35 ` Adam Jackson
2011-11-02 21:13 ` Keith Packard
2011-11-02 21:16 ` Adam Jackson
2011-11-02 18:54 ` Keith Packard
2011-11-02 19:07 ` Alex Deucher
2011-11-02 6:20 ` [PATCH 4/7] drm/i915: Let panel power sequencing hardware do its job Keith Packard
2011-11-02 7:31 ` Keith Packard
2011-11-02 16:23 ` [Intel-gfx] " Jesse Barnes
2011-11-02 17:14 ` Keith Packard
2011-11-02 17:37 ` Keith Packard
2011-11-03 19:57 ` Jesse Barnes
2011-11-03 22:01 ` Keith Packard
2011-11-02 6:20 ` [PATCH 5/7] drm/i915: Make DP prepare/commit consistent with DP dpms Keith Packard
2011-11-03 20:00 ` [Intel-gfx] " Jesse Barnes
2011-11-03 22:30 ` Keith Packard
2011-11-03 22:41 ` Jesse Barnes
2011-11-03 22:59 ` Keith Packard
2011-11-02 6:20 ` [PATCH 6/7] drm/i915: Try harder during dp pattern 1 link training Keith Packard
2011-11-02 9:12 ` Chris Wilson
2011-11-02 17:20 ` Keith Packard
2011-11-02 17:38 ` Keith Packard
2011-11-03 20:03 ` [Intel-gfx] " Jesse Barnes
2011-11-03 22:32 ` Keith Packard
2011-11-02 6:20 ` [PATCH 7/7] drm/i915: Remove trailing white space Keith Packard
2011-11-03 20:03 ` [Intel-gfx] " Jesse Barnes
2011-11-03 22:36 ` Keith Packard
2011-11-03 22:48 ` Keith Packard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4EB17A50.6050804@redhat.com \
--to=ajax@redhat.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jbarnes@virtuousgeek.org \
--cc=keithp@keithp.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox