Re: [PATCH] [RESEND] media: tea5764: reconcile Kconfig symbol and macro

Mauro Carvalho Chehab
2011-11-03T18:34:38Z

Em 30-10-2011 15:31, Paul Bolle escreveu:
> On Sun, 2011-10-30 at 10:24 -0700, Randy Dunlap wrote:
>> On 10/30/11 10:12, Paul Bolle wrote:
>>> 2) I'm not sure why things are done that way. Why can't builtin drivers
>>> and loadable drivers default to identical values? But perhaps I'm just
>>> misunderstanding the code.
>>
>> They could default to identical values.
>
> That would make the cleaning up I'm trying to do now somewhat easier. It
> would allow to simplify the drivers a bit too.
>
>> Maybe someone thinks that
>> it's more difficult to pass parameters to builtin drivers so they
>> just try to use some sane defaults for them instead, whereas it's
>> easy (easier) to pass parameters to loadable modules. ??
>
> Perhaps Mauro or the people at linux-media know the reasoning here. Or
> they can show us that I didn't parse the code correctly, of course.

I can't remember the dirty details about this driver, sorry. The first
patch on it might shed some light:

commit 46a60cfef581307d8273919182ae939d44ff7cca
Author: Fabio Belavenuto <belavenuto@gmail.com>
Date: Tue Dec 30 19:27:09 2008 -0300

V4L/DVB (10155): Add TEA5764 radio driver

Add support for radio driver TEA5764 from NXP.
This chip is connected in pxa I2C bus in EZX phones
from Motorola, the chip is used in phone model A1200.
This driver is for OpenEZX project (www.openezx.org)
Tested with A1200 phone, openezx kernel and fm-tools

[mchehab@redhat.com: Fixed CodingStyle and solved some merge conflicts]
Signed-off-by: Fabio Belavenuto <belavenuto@gmail.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>

>From the above, I _suspect_ that the default (whatever it is) is due to
the Motorola A1200 phone. Not sure if it is compiled as module or as builtin
at OpenEZX.

>
>
> Paul Bolle
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-media" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html