Re: [PATCH] [RESEND] media: tea5764: reconcile Kconfig symbol and macro

Randy Dunlap
2011-10-30T16:43:16Z

On 10/30/11 05:08, Paul Bolle wrote:
> The Kconfig symbol RADIO_TEA5764_XTAL is unused. The code does use a
> RADIO_TEA5764_XTAL macro, but does that rather peculiar. But there seems
> to be a way to keep both. (The easiest way out would be to rip out both
> the Kconfig symbol and the macro.)
>
> Note there's also a module parameter 'use_xtal' to influence all this.

It's curious that the module parameter is only available when the driver
is builtin (=y) but not built as a loadable module (=m):

config RADIO_TEA5764_XTAL
bool "TEA5764 crystal reference"
depends on RADIO_TEA5764=y
default y

>
> Signed-off-by: Paul Bolle <pebolle@tiscali.nl>
> ---
> I didn't dare to submit this a trivial patch. This is still untested. By
> the way, is xtal a common abbreviation of crystal?

Yes, it is.

Acked-by: Randy Dunlap <rdunlap@xenotime.net>

Thanks.

> drivers/media/radio/radio-tea5764.c | 4 +++-
> 1 files changed, 3 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/media/radio/radio-tea5764.c b/drivers/media/radio/radio-tea5764.c
> index 95ddcc4..db20904 100644
> --- a/drivers/media/radio/radio-tea5764.c
> +++ b/drivers/media/radio/radio-tea5764.c
> @@ -128,8 +128,10 @@ struct tea5764_write_regs {
> u16 rdsbbl; /* PAUSEDET & RDSBBL */
> } __attribute__ ((packed));
>
> -#ifndef RADIO_TEA5764_XTAL
> +#ifdef CONFIG_RADIO_TEA5764_XTAL
> #define RADIO_TEA5764_XTAL 1
> +#else
> +#define RADIO_TEA5764_XTAL 0
> #endif
>
> static int radio_nr = -1;

--
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***