From: David Smith <dsmith@redhat.com>
To: Pedro Alves <pedro@codesourcery.com>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Steven Rostedt <rostedt@goodmis.org>, Ingo Molnar <mingo@elte.hu>,
Peter Zijlstra <a.p.zijlstra@chello.nl>
Subject: Re: [RFC PATCH v2] Tracepoint: add exec tracepoint
Date: Fri, 04 Nov 2011 10:24:48 -0500 [thread overview]
Message-ID: <4EB403C0.9030503@redhat.com> (raw)
In-Reply-To: <201111041208.38163.pedro@codesourcery.com>
On 11/04/2011 07:08 AM, Pedro Alves wrote:
> On Thursday 03 November 2011 15:59:48, David Smith wrote:
>> + if (depth == 0) {
>> + trace_sched_process_exec(current, bprm);
>> ptrace_event(PTRACE_EVENT_EXEC,
>> old_pid);
>> + }
>
> Won't tracepoints be interested in the old pid as well? Or does bprm
> carry that info? That was only recently added to the ptrace event,
> which probably postdates your original patch.
Looking back at commit bb188d7 and the reasons why 'old_pid' was added,
it seems like a good idea to go ahead and add 'old_pid' to the
tracepoint as well.
v3 coming up...
Thanks for looking at this.
--
David Smith
dsmith@redhat.com
Red Hat
http://www.redhat.com
256.217.0141 (direct)
256.837.0057 (fax)
next prev parent reply other threads:[~2011-11-04 15:25 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-03 15:59 [RFC PATCH v2] Tracepoint: add exec tracepoint David Smith
2011-11-04 12:08 ` Pedro Alves
2011-11-04 15:24 ` David Smith [this message]
2011-11-07 12:56 ` Peter Zijlstra
2011-11-07 15:57 ` David Smith
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4EB403C0.9030503@redhat.com \
--to=dsmith@redhat.com \
--cc=a.p.zijlstra@chello.nl \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=pedro@codesourcery.com \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox