From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756009Ab1KDRHg (ORCPT ); Fri, 4 Nov 2011 13:07:36 -0400 Received: from mail.candelatech.com ([208.74.158.172]:60446 "EHLO ns3.lanforge.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751219Ab1KDRHf (ORCPT ); Fri, 4 Nov 2011 13:07:35 -0400 Message-ID: <4EB41BC5.4010304@candelatech.com> Date: Fri, 04 Nov 2011 10:07:17 -0700 From: Ben Greear Organization: Candela Technologies User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:7.0) Gecko/20110927 Thunderbird/7.0 MIME-Version: 1.0 To: Johannes Berg CC: Linus Torvalds , David Miller , "Grumbach, Emmanuel" , "Guy, Wey-Yi W" , "John W. Linville" , "akpm@linux-foundation.org" , "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Stanislaw Gruszka Subject: Re: [GIT] Networking References: <20111025.063206.2273357152859701628.davem@davemloft.net> <1320426222.3969.121.camel@jlt3.sipsolutions.net> In-Reply-To: <1320426222.3969.121.camel@jlt3.sipsolutions.net> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/04/2011 10:03 AM, Johannes Berg wrote: > On Tue, 2011-10-25 at 12:26 +0000, Linus Torvalds wrote: >> On Tue, Oct 25, 2011 at 12:32 PM, David Miller wrote: >>> >>> The most visible thing in here is the reorganization of the drivers >>> under drivers/net. >> >> Nope, the most visible thing are some new annoying warnings, that seem >> absolutely broken. >> >> At the very minimum, that WARN_ON(1) should be a WARN_ON_ONCE() or >> something like that. Because showing it over an dover again is not >> helpful. >> >> Added the people who signed off on the changes to the affected files, >> since they hopefully know why this happens and can fix it.. > > Sorry for the late reply. > > I think this was actually caused by some changes from Ben Greear > "optimising" stuff in net/mac80211/work.c and keeping the wrong channel, > Stanislaw was also looking at this at some point I think. I agree that > it would be good to change to WARN_ON_ONCE(), will do that. > > The warning itself has been around forever, but the fact that it > triggers now is probably related to the channel work& band switches. There are patches for the work_work bugs I introduced, and they are in wireless-testing, and were CC'd to stable as far as I can tell. Thanks, Ben -- Ben Greear Candela Technologies Inc http://www.candelatech.com