* [PATCH 1/2] gpiolib: output basic details and consolidate gpio device drivers
@ 2011-11-05 21:27 Hartmut Knaack
2011-11-06 18:33 ` Grant Likely
0 siblings, 1 reply; 2+ messages in thread
From: Hartmut Knaack @ 2011-11-05 21:27 UTC (permalink / raw)
To: Grant Likely; +Cc: linux-kernel
This patch adds a kernel message, containing GPIO range and device name on successful device registration.
Signed-off-by: Hartmut Knaack <knaack.h@gmx.de>
-------------------------------------------------------------
diff --git a/drivers/gpio/gpiolib.c b/drivers/gpio/gpiolib.c
index a971e3d..d919ac6 100644
--- a/drivers/gpio/gpiolib.c
+++ b/drivers/gpio/gpiolib.c
@@ -1088,6 +1088,10 @@ unlock:
status = gpiochip_export(chip);
if (status)
goto fail;
+
+ pr_info("gpiochip_add: registered GPIOs %d to %d on device: %s\n",
+ chip->base, chip->base + chip->ngpio - 1,
+ chip->label ? : "generic");
return 0;
fail:
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 1/2] gpiolib: output basic details and consolidate gpio device drivers
2011-11-05 21:27 [PATCH 1/2] gpiolib: output basic details and consolidate gpio device drivers Hartmut Knaack
@ 2011-11-06 18:33 ` Grant Likely
0 siblings, 0 replies; 2+ messages in thread
From: Grant Likely @ 2011-11-06 18:33 UTC (permalink / raw)
To: Hartmut Knaack; +Cc: linux-kernel
On Sat, Nov 05, 2011 at 10:27:51PM +0100, Hartmut Knaack wrote:
> This patch adds a kernel message, containing GPIO range and device name on successful device registration.
>
> Signed-off-by: Hartmut Knaack <knaack.h@gmx.de>
> -------------------------------------------------------------
For next time; the divider between commit text and patch must be
exactly 3 '-' characters long, no more, no less. Otherwise the tools
don't handle it properly.
> diff --git a/drivers/gpio/gpiolib.c b/drivers/gpio/gpiolib.c
> index a971e3d..d919ac6 100644
> --- a/drivers/gpio/gpiolib.c
> +++ b/drivers/gpio/gpiolib.c
> @@ -1088,6 +1088,10 @@ unlock:
> status = gpiochip_export(chip);
> if (status)
> goto fail;
> +
Whitespace error.
Otherwise looks good. I'm picking it up and squashing it together
with the second patch.
> + pr_info("gpiochip_add: registered GPIOs %d to %d on device: %s\n",
> + chip->base, chip->base + chip->ngpio - 1,
> + chip->label ? : "generic");
>
> return 0;
> fail:
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-11-06 18:33 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-11-05 21:27 [PATCH 1/2] gpiolib: output basic details and consolidate gpio device drivers Hartmut Knaack
2011-11-06 18:33 ` Grant Likely
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox