From: Len Brown <lenb@kernel.org>
To: "Yu, Fenghua" <fenghua.yu@intel.com>
Cc: Thomas Gleixner <tglx@linutronix.de>, Ingo Molnar <mingo@elte.hu>,
H Peter Anvin <hpa@zytor.com>,
Zwane Mwaikambo <zwane@arm.linux.org.uk>,
"Luck, Tony" <tony.luck@intel.com>,
"Mallick, Asit K" <asit.k.mallick@intel.com>,
"Siddha, Suresh B" <suresh.b.siddha@intel.com>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 6/8] x86, topology.c: Enable CPU0 online/offline
Date: Sun, 06 Nov 2011 21:11:02 -0500 [thread overview]
Message-ID: <4EB73E36.1040602@kernel.org> (raw)
In-Reply-To: <493994B35A117E4F832F97C4719C4C04013E1A6784@orsmsx505.amr.corp.intel.com>
On 11/03/2011 06:47 PM, Yu, Fenghua wrote:
>>> + bsp_hotplug [X86] BSP (aka CPU0) is hotpluggable.
>>> + Suspend/resume depends on BSP. It's said some PCI
>>> + quirks depend on BSP too. But not sure which quirks.
>>
>> Right, not sure what breaks. Go ahead and watch your machine explode.
>>
>>> + If don't care the dependencies, you can turn on
>>> + bsp_ hotplug. Suspend will fail if BSP is offlined
>> and
>>> + you need to online BSP before suspend/resume.
>>
>> And you forgot poweroff and reboot, which have similar dependencies on
>> some machines. That whole low level ACPI stuff is sensitive.
>
> I tested poweroff, shutdown, and reboot with various reboot_type on a few different platforms. I haven't seen poweroff and reboot issues after CPU0 is offline.
>
> Do you have specific platforms that I can test poweroff and reboot dependency on CPU0?
> Or we just assume there are some platforms out there that depend on CPU0 for poweroff/reboot?
A classic Linux/ACPI failure happened when HT first shipped.
Some platforms stopped powering off or rebooting 50% of the time.
It turned out that SMM on those machines assumed
it would be triggered from CPU0 and not CPU1.
the original code should have worked, of course,
and most of the time it did -- but some systems broke.
The same will probably happen here.
-Len
next prev parent reply other threads:[~2011-11-07 2:11 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-05 16:39 [PATCH 0/8] Online/offline BSP on x86 Fenghua Yu
2011-10-05 16:39 ` [PATCH 1/8] x86, apic.c: Disable irq0 if CPU enables ARAT for local apic timer Fenghua Yu
2011-10-05 18:47 ` Thomas Gleixner
2011-10-05 19:12 ` Yu, Fenghua
2011-10-05 19:38 ` Thomas Gleixner
2011-10-05 20:11 ` Yu, Fenghua
2011-10-06 2:43 ` Andi Kleen
2011-10-05 16:39 ` [PATCH 2/8] x86/mtrr/main.c: Ask the first online CPU to save mtrr Fenghua Yu
2011-10-05 19:03 ` Srivatsa S. Bhat
2011-10-05 16:39 ` [PATCH 3/8] x86, i387.c: thread xstate is initialized only on BSP once Fenghua Yu
2011-10-05 18:49 ` Thomas Gleixner
2011-10-05 19:53 ` Yu, Fenghua
2011-10-05 16:39 ` [PATCH 4/8] kernel/workqueue.c: unbound work queue rescuer runs on first cpu in cpumask_online_cpu Fenghua Yu
2011-10-05 18:52 ` Thomas Gleixner
2011-10-05 19:19 ` Peter Zijlstra
2011-10-05 20:00 ` Tejun Heo
2011-10-05 16:39 ` [PATCH 5/8] x86, common.c, smpboot.c: Init BSP during BSP online and don't offline BSP if irq is bound to it Fenghua Yu
2011-10-05 19:13 ` Thomas Gleixner
2011-10-05 16:39 ` [PATCH 6/8] x86, topology.c: Enable CPU0 online/offline Fenghua Yu
2011-10-05 19:20 ` Thomas Gleixner
2011-10-05 23:05 ` Yu, Fenghua
2011-11-03 22:47 ` Yu, Fenghua
2011-11-07 2:11 ` Len Brown [this message]
2011-11-07 21:02 ` Yu, Fenghua
2011-10-05 16:39 ` [PATCH 7/8] kernel/power/main.c: Not suspend/resume if CPU0 is offlined Fenghua Yu
2011-10-05 18:37 ` Srivatsa S. Bhat
2011-10-05 19:22 ` Thomas Gleixner
2011-10-05 16:39 ` [PATCH 8/8] kernel/cpu.c: Define bsp_hotpluggable variable Fenghua Yu
2011-10-05 19:25 ` Thomas Gleixner
2011-10-05 20:25 ` Yu, Fenghua
2011-10-05 21:19 ` Thomas Gleixner
2011-10-05 19:16 ` [PATCH 0/8] Online/offline BSP on x86 Peter Zijlstra
2011-10-05 19:22 ` Yu, Fenghua
2011-10-05 19:28 ` Peter Zijlstra
2011-10-05 20:29 ` Yu, Fenghua
2011-10-05 20:37 ` Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4EB73E36.1040602@kernel.org \
--to=lenb@kernel.org \
--cc=asit.k.mallick@intel.com \
--cc=fenghua.yu@intel.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=suresh.b.siddha@intel.com \
--cc=tglx@linutronix.de \
--cc=tony.luck@intel.com \
--cc=zwane@arm.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox