Re: WARNING: at drivers/scsi/scsi_lib.c:1704

[Hannes Reinecke <hare@suse.de>]

On 11/08/2011 01:03 AM, Stephen Rothwell wrote:
> Hi James,
>
> On Mon, 07 Nov 2011 08:51:24 -0600 James Bottomley<James.Bottomley@HansenPartnership.com>  wrote:
>>
>> Actually, I don't think it's anything to do with this: it's Anton's
>> fault
>>
>> commit f7c9c6bb14f3104608a3a83cadea10a6943d2804
>> Author: Anton Blanchard<anton@samba.org>
>> Date:   Thu Nov 3 08:56:22 2011 +1100
>>
>>      [SCSI] Fix block queue and elevator memory leak in scsi_alloc_sdev
>>
>> Doesn't completely do the teardown.  The true fix is to do a proper
>> teardown instead of hand rolling it.  Does this fix it for you?
>
> I don't get the WARNING any more, but now get lots of:
>
> scsi: killing requests for dead queue
>
Yeah, that is really annoying.
And what's more the printk is wrong, as it doesn't indicate
that we've actually killed requests. It's just announcing that we 
might start killing requests, provided the request_queue isn't empty.

I'll be sending a patch.

Cheers,

Hannes
-- 
Dr. Hannes Reinecke		      zSeries & Storage
hare@suse.de			      +49 911 74053 688
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: J. Hawn, J. Guild, F. Imendörffer, HRB 16746 (AG Nürnberg)