Re: [PATCH] Kbuild: append missing-syscalls to the default target list

[David Daney <ddaney.cavm@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 1394 bytes --]

On 11/08/2011 12:25 AM, Michal Marek wrote:
> On 8.11.2011 00:33, Ralf Baechle wrote:
>> On Mon, Nov 07, 2011 at 10:19:00PM +0100, Michal Marek wrote:
>>
>>> Wild guess - does this patch help?
>>>
>>>
>>> diff --git a/Kbuild b/Kbuild
>>> index 4caab4f..77c191a 100644
>>> --- a/Kbuild
>>> +++ b/Kbuild
>>> @@ -94,7 +94,7 @@ targets += missing-syscalls
>>>   quiet_cmd_syscalls = CALL    $<
>>>         cmd_syscalls = $(CONFIG_SHELL) $<  $(CC) $(c_flags)
>>>
>>> -missing-syscalls: scripts/checksyscalls.sh $(offsets-file) FORCE
>>> +missing-syscalls: scripts/checksyscalls.sh $(offsets-file) $(bounds-file) FORCE
>>>   	$(call cmd,syscalls)
>>>
>>>   # Keep these two files during make clean
>>
>> No, it didn't.
>>
>>> If not, please attach logs of make V=1 with clean Linus' tree and with
>>> 5f7efb4c6da9f90cb306923ced2a6494d065a595 reverted.
>>
>> $ git checkout 31555213f03bca37d2c02e10946296052f4ecfcd
>> $ git revert 5f7efb4c6da9f90cb306923ced2a6494d065a595
>> $ make ARCH=mips ip27_defconfig
>> $ make ARCH=mips V=1 2>&1 | tee log
>
> Thanks, can you also post a log without the revert?
>

The problem is that compiler options meant to be used only for the 
compiling done by scripts/checksyscalls.sh are now leaking into the 
compilation of other parts of the kernel (asm-offsets.c), where they 
wreak havoc.

Something like the attached is what I think needs to be done.

David Daney

[-- Attachment #2: 0001-kbuild-Fix-missing-system-calls-check-on-mips.patch --]
[-- Type: text/plain, Size: 1481 bytes --]

>From e23608d2612092a8576d408425f6719f0860f5ff Mon Sep 17 00:00:00 2001
From: David Daney <david.daney@cavium.com>
Date: Tue, 8 Nov 2011 10:20:10 -0800
Subject: [PATCH] kbuild: Fix missing system calls check on mips.

Signed-off-by: David Daney <david.daney@cavium.com>
---
 Kbuild             |    2 +-
 arch/mips/Makefile |    4 ++--
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/Kbuild b/Kbuild
index 4caab4f..b8b708a 100644
--- a/Kbuild
+++ b/Kbuild
@@ -92,7 +92,7 @@ always += missing-syscalls
 targets += missing-syscalls
 
 quiet_cmd_syscalls = CALL    $<
-      cmd_syscalls = $(CONFIG_SHELL) $< $(CC) $(c_flags)
+      cmd_syscalls = $(CONFIG_SHELL) $< $(CC) $(c_flags) $(missing_syscalls_flags)
 
 missing-syscalls: scripts/checksyscalls.sh $(offsets-file) FORCE
 	$(call cmd,syscalls)
diff --git a/arch/mips/Makefile b/arch/mips/Makefile
index 9b4cb00..0be3186 100644
--- a/arch/mips/Makefile
+++ b/arch/mips/Makefile
@@ -286,11 +286,11 @@ CLEAN_FILES += vmlinux.32 vmlinux.64
 archprepare:
 ifdef CONFIG_MIPS32_N32
 	@echo '  Checking missing-syscalls for N32'
-	$(Q)$(MAKE) $(build)=. missing-syscalls ccflags-y="-mabi=n32"
+	$(Q)$(MAKE) $(build)=. missing-syscalls missing_syscalls_flags="-mabi=n32"
 endif
 ifdef CONFIG_MIPS32_O32
 	@echo '  Checking missing-syscalls for O32'
-	$(Q)$(MAKE) $(build)=. missing-syscalls ccflags-y="-mabi=32"
+	$(Q)$(MAKE) $(build)=. missing-syscalls missing_syscalls_flags="-mabi=32"
 endif
 
 install:
-- 
1.7.2.3