Re: [PATCH V3 2/4] drivers/i2c/busses/i2c-at91.c: add new driver

Felipe Balbi
2011-11-08T15:23:53Z

[-- Attachment #1: Type: text/plain, Size: 687 bytes --]

On Tue, Nov 08, 2011 at 04:15:10PM +0100, Nicolas Ferre wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> On 11/08/2011 03:41 PM, Felipe Balbi :
>
> >> + if (cpu_is_at91rm9200()) { /* AT91RM9200 Errata #22 */
> >
> > I don't think you should be using cpu_is_* on drivers.
>
> It is a common pattern in at91 drivers and has worked for ages.
> Do you think it is related to the need to be able to compile the
> driver for any SoC in the case of multi-SoC zImage support?

we have drivers compiling on multiple OMAP versions without those hacks.
Generally, we check the IP revision for that. Don't you have a Revision
register of some sort ?

--
balbi

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]