From: Jarkko Nikula <jarkko.nikula@bitmer.com>
To: "Péter Ujfalusi" <peter.ujfalusi@ti.com>
Cc: linux-kernel@vger.kernel.org,
Samuel Ortiz <sameo@linux.intel.com>,
stable@vger.kernel.org
Subject: Re: [PATCH] mfd: twl4030-audio: Fix audio codec breakage
Date: Fri, 11 Nov 2011 10:46:30 +0200 [thread overview]
Message-ID: <4EBCE0E6.5020202@bitmer.com> (raw)
In-Reply-To: <1848643.7W84dlC6t3@barack>
On 11/02/2011 09:41 AM, Péter Ujfalusi wrote:
> On Wednesday 19 October 2011 11:44:05 Jarkko Nikula wrote:
>> Commit 57fe725 ("MFD: twl4030-codec -> twl4030-audio: Rename the driver")
>> broke the device registration for twl4030 codec if twl6040 is not set.
>>
>> Reason for breakage is that commit didn't update the changed config name for
>> macro twl_has_codec().
>>
>> Signed-off-by: Jarkko Nikula<jarkko.nikula@bitmer.com>
>> Cc: Peter Ujfalusi<peter.ujfalusi@ti.com>
>> ---
>> I don't know is this too late for 3.1 or would it be better to queue for
>> stable when it's out? Anyway breakage happened in 3.1-rc cycle and
>> unfortunately I noticed it only now.
>
> Thanks Jarkko for noticing this. I have overlooked it probably because I'm
> using omap2plus_defconf for most of the time.
>
> The breakage also present in 3.0. Can we queue this patch for stable 3.0.x,
> and 3.1.x?
>
> Acked-by: Peter Ujfalusi<peter.ujfalusi@ti.com>
>
Actually this is already fixed by f09ee04 ("mfd: Fix twl4030
dependencies for audio codec") which is now in 3.2-rc. Is that commit
queued for stable too?
--
Jarkko
next prev parent reply other threads:[~2011-11-11 8:46 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-19 8:44 [PATCH] mfd: twl4030-audio: Fix audio codec breakage Jarkko Nikula
2011-10-19 20:08 ` David Rientjes
2011-11-02 7:41 ` Péter Ujfalusi
2011-11-11 8:46 ` Jarkko Nikula [this message]
2011-11-16 23:45 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4EBCE0E6.5020202@bitmer.com \
--to=jarkko.nikula@bitmer.com \
--cc=linux-kernel@vger.kernel.org \
--cc=peter.ujfalusi@ti.com \
--cc=sameo@linux.intel.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox