From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757137Ab1KKLh1 (ORCPT ); Fri, 11 Nov 2011 06:37:27 -0500 Received: from eu1sys200aog101.obsmtp.com ([207.126.144.111]:50479 "EHLO eu1sys200aog101.obsmtp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754261Ab1KKLh0 (ORCPT ); Fri, 11 Nov 2011 06:37:26 -0500 Message-ID: <4EBD08E7.3080608@st.com> Date: Fri, 11 Nov 2011 17:07:11 +0530 From: Viresh Kumar User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:6.0) Gecko/20110812 Thunderbird/6.0 MIME-Version: 1.0 To: Rabin Vincent Cc: Linus WALLEIJ , "linux-kernel@vger.kernel.org" , "sameo@linux.intel.com" , Armando VISCONTI , Shiraz HASHIM , Vipin KUMAR , Rajeev KUMAR , Deepak SIKRI , Vipul Kumar SAMAR , Amit VIRDI , Pratyush ANAND , Bhupesh SHARMA , "viresh.linux@gmail.com" , Bhavna YADAV , Vincenzo FRASCINO , Mirko GARDI , Srinidhi KASAGAR Subject: Re: [PATCH 0/2] mfd/stmpe: Add SPI interface support References: <4EBCF8FC.5020504@st.com> In-Reply-To: Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/11/2011 5:02 PM, Rabin Vincent wrote: > On Fri, Nov 11, 2011 at 15:59, Viresh Kumar wrote: >> On 11/11/2011 3:13 PM, Rabin Vincent wrote: >>> Could you instead convert stmpe to use the register map API, and then >>> add the SPI interface? Converting to regmap should both simplify the >>> existing code as well as make it possible to add the second interface >>> with fewer lines of code. >> >> Sorry Rabin, but i couldn't get your comment completely. :( >> Can you please spend few lines on "what do you mean by register map API"? > > drivers/base/regmap, added in b83a313bf25 ("regmap: Add generic > non-memory mapped register access API"). > > Several MFDs are already using it (git grep regmap drivers/mfd/), and > patches to convert more are making the rounds on the lists. Ok. Got it now. :) Can we get this patchset pushed as it is and i will do this regmap stuff later in a separate patchset? Actually i am a bit busy currently with some other activities and can come back to it after some time. -- viresh