From: Jens Axboe <jaxboe@fusionio.com>
To: Linus Walleij <linus.walleij@stericsson.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Rabin Vincent <rabin.vincent@stericsson.com>,
"stable@kernel.org" <stable@kernel.org>,
Linus Walleij <linus.walleij@linaro.org>
Subject: Re: [PATCH] backing-dev: ensure wakeup_timer is deleted
Date: Fri, 11 Nov 2011 13:28:03 +0100 [thread overview]
Message-ID: <4EBD14D3.5090002@fusionio.com> (raw)
In-Reply-To: <1320916025-20264-1-git-send-email-linus.walleij@stericsson.com>
On 2011-11-10 10:07, Linus Walleij wrote:
> diff --git a/mm/backing-dev.c b/mm/backing-dev.c
> index a086064..71034f4 100644
> --- a/mm/backing-dev.c
> +++ b/mm/backing-dev.c
> @@ -724,6 +724,14 @@ void bdi_destroy(struct backing_dev_info *bdi)
>
> bdi_unregister(bdi);
>
> + /*
> + * If bdi_unregister() had already been called earlier, the
> + * wakeup_timer could still be armed because bdi_prune_sb()
> + * can race with the bdi_wakeup_thread_delayed() calls from
> + * __mark_inode_dirty().
> + */
> + del_timer_sync(&bdi->wb.wakeup_timer);
> +
> for (i = 0; i < NR_BDI_STAT_ITEMS; i++)
> percpu_counter_destroy(&bdi->bdi_stat[i]);
Thanks, makes sense, applied.
--
Jens Axboe
prev parent reply other threads:[~2011-11-11 12:28 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-10 9:07 [PATCH] backing-dev: ensure wakeup_timer is deleted Linus Walleij
2011-11-11 12:28 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4EBD14D3.5090002@fusionio.com \
--to=jaxboe@fusionio.com \
--cc=akpm@linux-foundation.org \
--cc=linus.walleij@linaro.org \
--cc=linus.walleij@stericsson.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rabin.vincent@stericsson.com \
--cc=stable@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox