Re: [PATCH v2 14/14] Change CPUACCT to default n

[Glauber Costa <glommer@parallels.com>]

On 11/11/2011 07:33 PM, Paul Turner wrote:
> On 11/01/2011 02:19 PM, Glauber Costa wrote:
>> Now that we're providing all cpuacct capability in cpu cgroup,
>> default CPUACCT to n. We still maintain it for compatiblity for
>> anyone that need an independent set of tasks to be managed by it
>> relatively to cpu cgroup, but encourage the use of cpucgroup for that.
>>
>> Proposing schedule of deprecation for 3.5
>>
>
>
> I'd like to see a little more separation beyond 1 linear series here.
>
>
> We're doing the following things
>
> 1. Migrating the existing cpuacct functionality into cpu
> 2. Deprecating cpuacct
> 3. Adding new functionality
>
> I would like to consider (3) separately from 1/2 which we can and should
> accomplish immediately due to the over-head it's currently introducing.
> It seems less than optimal to hinge resolving that on reaching agreement
> for the new bits.
>
> It also helps that the the migrated functionality in (1) is just
> exporting state that is already being maintained by cpu so those changes
> end up being quite small and non-invasive.

So you'd like me to submit a new series, that does not do per-cgroup 
/proc/stat first?

> - Paul
>
>> Signed-off-by: Glauber Costa<glommer@parallels.com>
>> CC: Balbir Singh<bsingharora@gmail.com>
>> ---
>> Documentation/feature-removal-schedule.txt | 8 ++++++++
>> init/Kconfig | 1 +
>> 2 files changed, 9 insertions(+), 0 deletions(-)
>>
>> diff --git a/Documentation/feature-removal-schedule.txt
>> b/Documentation/feature-removal-schedule.txt
>> index d5ac362..91165fe 100644
>> --- a/Documentation/feature-removal-schedule.txt
>> +++ b/Documentation/feature-removal-schedule.txt
>> @@ -609,3 +609,11 @@ When: 3.5
>> Why: The iwlagn module has been renamed iwlwifi. The alias will be around
>> for backward compatibility for several cycles and then dropped.
>> Who: Don Fry<donald.h.fry@intel.com>
>> +
>> +----------------------------
>> +
>> +What: cpuacct cgroup
>> +When: 3.5
>> +Why: Same functionality is provided by the CGROUP_SCHED, with a lower
>> + footprint.
>> +Who: Glauber Costa<glommer@parallels.com>
>> diff --git a/init/Kconfig b/init/Kconfig
>> index 31ba0fd..d3d958b 100644
>> --- a/init/Kconfig
>> +++ b/init/Kconfig
>> @@ -626,6 +626,7 @@ config PROC_PID_CPUSET
>>
>> config CGROUP_CPUACCT
>> bool "Simple CPU accounting cgroup subsystem"
>> + default n
>> help
>> Provides a simple Resource Controller for monitoring the
>> total CPU consumed by the tasks in a cgroup.
>