* [PATCH] staging: iio: drop "select IIO_SIMPLE_DUMMY_EVGEN"
@ 2011-11-13 13:05 Paul Bolle
2011-11-13 13:08 ` Jonathan Cameron
0 siblings, 1 reply; 2+ messages in thread
From: Paul Bolle @ 2011-11-13 13:05 UTC (permalink / raw)
To: Jonathan Cameron, Greg Kroah-Hartman; +Cc: devel, linux-kernel
Commit e6477000fc ("staging:iio:dummy Add event support + fake event
generator") added "select IIO_SIMPLE_DUMMY_EVGEN if [...]". But there
is no Kconfig symbol named IIO_SIMPLE_DUMMY_EVGEN. The select statement
for that symbol is a nop. Drop it.
Signed-off-by: Paul Bolle <pebolle@tiscali.nl>
---
0) Tested with "make menuconfig" before and after applying this patch.
Identical .config files were generated, as was expected.
1) The "select IIO_DUMMY_EVGEN" of the IIO_SIMPLE_DUMMY_EVENTS Kconfig
entry probably does what was intended here. Maybe that's why no one
noticed.
drivers/staging/iio/Kconfig | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/drivers/staging/iio/Kconfig b/drivers/staging/iio/Kconfig
index 4ec9118..90162aa 100644
--- a/drivers/staging/iio/Kconfig
+++ b/drivers/staging/iio/Kconfig
@@ -76,7 +76,6 @@ config IIO_DUMMY_EVGEN
config IIO_SIMPLE_DUMMY
tristate "An example driver with no hardware requirements"
- select IIO_SIMPLE_DUMMY_EVGEN if IIO_SIMPLE_DUMMY_EVENTS
help
Driver intended mainly as documentation for how to write
a driver. May also be useful for testing userspace code
--
1.7.4.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] staging: iio: drop "select IIO_SIMPLE_DUMMY_EVGEN"
2011-11-13 13:05 [PATCH] staging: iio: drop "select IIO_SIMPLE_DUMMY_EVGEN" Paul Bolle
@ 2011-11-13 13:08 ` Jonathan Cameron
0 siblings, 0 replies; 2+ messages in thread
From: Jonathan Cameron @ 2011-11-13 13:08 UTC (permalink / raw)
To: Paul Bolle; +Cc: Greg Kroah-Hartman, devel, linux-kernel
On 11/13/2011 01:05 PM, Paul Bolle wrote:
> Commit e6477000fc ("staging:iio:dummy Add event support + fake event
> generator") added "select IIO_SIMPLE_DUMMY_EVGEN if [...]". But there
> is no Kconfig symbol named IIO_SIMPLE_DUMMY_EVGEN. The select statement
> for that symbol is a nop. Drop it.
Yes, you are quite right. Looks like some dead logic from an earlier
version. My mistake.
>
> Signed-off-by: Paul Bolle <pebolle@tiscali.nl>
Acked-by: Jonathan Cameron <jic23@camd.ac.uk>
> ---
> 0) Tested with "make menuconfig" before and after applying this patch.
> Identical .config files were generated, as was expected.
>
> 1) The "select IIO_DUMMY_EVGEN" of the IIO_SIMPLE_DUMMY_EVENTS Kconfig
> entry probably does what was intended here. Maybe that's why no one
> noticed.
Indeed it does.
>
> drivers/staging/iio/Kconfig | 1 -
> 1 files changed, 0 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/staging/iio/Kconfig b/drivers/staging/iio/Kconfig
> index 4ec9118..90162aa 100644
> --- a/drivers/staging/iio/Kconfig
> +++ b/drivers/staging/iio/Kconfig
> @@ -76,7 +76,6 @@ config IIO_DUMMY_EVGEN
>
> config IIO_SIMPLE_DUMMY
> tristate "An example driver with no hardware requirements"
> - select IIO_SIMPLE_DUMMY_EVGEN if IIO_SIMPLE_DUMMY_EVENTS
> help
> Driver intended mainly as documentation for how to write
> a driver. May also be useful for testing userspace code
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-11-13 13:08 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-11-13 13:05 [PATCH] staging: iio: drop "select IIO_SIMPLE_DUMMY_EVGEN" Paul Bolle
2011-11-13 13:08 ` Jonathan Cameron
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox