From: Sergei Shtylyov <sshtylyov@mvista.com>
To: Tonylijo <mail@tonylijo.in>
Cc: Felipe Balbi <balbi@ti.com>, Greg Kroah-Hartman <gregkh@suse.de>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] usb : gadget : usbstring : fix style problems
Date: Wed, 16 Nov 2011 16:08:35 +0400 [thread overview]
Message-ID: <4EC3A7C3.8010802@mvista.com> (raw)
In-Reply-To: <1321418582.2443.4.camel@debian1.ic>
Hello.
On 16-11-2011 8:43, Tonylijo wrote:
> Minor fixes for problems found by checkpatch.pl in usbstring.c.
> Signed-off-by: Tonylijo Jose<mail@tonylijo.in>
> ---
> diff --git a/drivers/usb/gadget/usbstring.c
> b/drivers/usb/gadget/usbstring.c
> index 58c4d37..2bdc56a 100644
> --- a/drivers/usb/gadget/usbstring.c
> +++ b/drivers/usb/gadget/usbstring.c
[...]
> @@ -102,17 +104,17 @@ fail:
> * characters (which are also widely used in C strings).
> */
> int
> -usb_gadget_get_string (struct usb_gadget_strings *table, int id, u8
> *buf)
> +usb_gadget_get_string(struct usb_gadget_strings *table, int id, u8
> *buf)
The patch was line-wrapped by your mailer. Seems easy to fix though...
> @@ -124,13 +126,13 @@ usb_gadget_get_string (struct usb_gadget_strings
> *table, int id, u8 *buf)
> return -EINVAL;
>
> /* string descriptors have length, tag, then UTF16-LE text */
> - len = min ((size_t) 126, strlen (s->s));
> - memset (buf + 2, 0, 2 * len); /* zero all the bytes */
> + len = min((size_t) 126, strlen(s->s));
Worth converting to min_t() probably...
WBR, Sergei
prev parent reply other threads:[~2011-11-16 12:09 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-16 4:43 [PATCH] usb : gadget : usbstring : fix style problems Tonylijo
2011-11-16 11:09 ` Felipe Balbi
2011-11-17 10:45 ` Tonylijo
2011-11-16 12:08 ` Sergei Shtylyov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4EC3A7C3.8010802@mvista.com \
--to=sshtylyov@mvista.com \
--cc=balbi@ti.com \
--cc=gregkh@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mail@tonylijo.in \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox