From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752967Ab1KPTfs (ORCPT ); Wed, 16 Nov 2011 14:35:48 -0500 Received: from terminus.zytor.com ([198.137.202.10]:59606 "EHLO mail.zytor.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752334Ab1KPTfr (ORCPT ); Wed, 16 Nov 2011 14:35:47 -0500 Message-ID: <4EC41060.2040501@zytor.com> Date: Wed, 16 Nov 2011 11:34:56 -0800 From: "H. Peter Anvin" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:7.0.1) Gecko/20110930 Thunderbird/7.0.1 MIME-Version: 1.0 To: "Luck, Tony" CC: Linus Torvalds , Ingo Molnar , Thomas Gleixner , Fenghua Yu , Matt Mackall , Herbert Xu , "Theodore Ts'o" , Jeff Garzik , Arjan van de Ven , linux-kernel@vger.kernel.org Subject: Re: [PATCH] fix typo/thinko in get_random_bytes() References: <4ec4061010261a4cb0@agluck-desktop.sc.intel.com> In-Reply-To: <4ec4061010261a4cb0@agluck-desktop.sc.intel.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/16/2011 10:50 AM, Luck, Tony wrote: > If there is an architecture-specific random number generator we use > it to acquire randomness one "long" at a time. We should put these > random words into consecutive words in the result buffer - not just > overwrite the first word again and again. > > Signed-off-by: Tony Luck Ouch. Good catch. This, I guess, is the downside of doing this only on the kernel paths... made this kind of errors harder to catch. Acked-by: H. Peter Anvin Linus, do you want to take this one or should I put it in the urgent queue in tip? -hpa -- H. Peter Anvin, Intel Open Source Technology Center I work for Intel. I don't speak on their behalf.