From: Randy Dunlap <rdunlap@xenotime.net>
To: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: linux-next@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>,
Linux RDMA <linux-rdma@vger.kernel.org>,
Bart Van Assche <bvanassche@acm.org>
Subject: Re: linux-next: Tree for Nov 16 (infiniband: ib_srpt.c)
Date: Wed, 16 Nov 2011 18:34:09 -0800 [thread overview]
Message-ID: <4EC472A1.6000407@xenotime.net> (raw)
In-Reply-To: <20111116133342.3eb15cac16f4c081dc6ed009@canb.auug.org.au>
On 11/15/2011 06:33 PM, Stephen Rothwell wrote:
> Hi all,
When CONFIG_BUG is not enabled:
next-2011-1116/drivers/infiniband/ulp/srpt/ib_srpt.c: In function 'srpt_cm_dreq_recv':
next-2011-1116/drivers/infiniband/ulp/srpt/ib_srpt.c:2761:3: error: implicit declaration of function '__WARN'
jbd2 has a similar issue (still unpatched). One of the comments in that thread
was that ext4 probably should use WARN_ON() instead of __WARN().
Or (Arnd said):
Hmm, my feeling is that we shouldn't do that either, and that jbd2 should
be changed. If we want a function that does what __WARN() does today, we
should probably make a conscious decision about what we want it to be called
and not have it start with "__". <end Arnd>
--
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***
next prev parent reply other threads:[~2011-11-17 2:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-16 2:33 linux-next: Tree for Nov 16 Stephen Rothwell
2011-11-17 2:34 ` Randy Dunlap [this message]
2011-11-17 18:51 ` linux-next: Tree for Nov 16 (infiniband: ib_srpt.c) Bart Van Assche
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4EC472A1.6000407@xenotime.net \
--to=rdunlap@xenotime.net \
--cc=bvanassche@acm.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).