From: "H. Peter Anvin" <hpa@zytor.com>
To: wangyanqing <Udknight@gmail.com>,
torvalds@linux-foundation.org, castet.matthieu@free.fr,
akpm@linux-foundation.org, x86@kernel.org, spock@gentoo.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] x86: remove NX from video bios area
Date: Thu, 17 Nov 2011 06:56:46 -0800 [thread overview]
Message-ID: <4EC520AE.3070409@zytor.com> (raw)
In-Reply-To: <20111117082624.GA4136@udknight.homenetwork>
On 11/17/2011 12:26 AM, wangyanqing wrote:
>
> +/*we hope this the right video bios range*/
> +#define VIDEO_BIOS_BEGIN 0x000c0000
> +#define VIDEO_BIOS_END 0x000c7fff
> +
> #define BIOS_ROM_BASE 0xffe00000
> #define BIOS_ROM_END 0xffffffff
Ick. This feels increasingly hacky, especially since the above is known
to not be the video BIOS range on a lot of reasons.
There is something much more fundamentally wrong here, including why X
permission is needed for uvesafb at all.
-hpa
--
H. Peter Anvin, Intel Open Source Technology Center
I work for Intel. I don't speak on their behalf.
next prev parent reply other threads:[~2011-11-17 14:57 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-17 8:26 [PATCH v2] x86: remove NX from video bios area wangyanqing
2011-11-17 14:56 ` H. Peter Anvin [this message]
2011-11-18 4:45 ` wangyanqing
2011-11-18 5:02 ` H. Peter Anvin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4EC520AE.3070409@zytor.com \
--to=hpa@zytor.com \
--cc=Udknight@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=castet.matthieu@free.fr \
--cc=linux-kernel@vger.kernel.org \
--cc=spock@gentoo.org \
--cc=torvalds@linux-foundation.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox