From: Chen Gong <gong.chen@linux.intel.com>
To: Kees Cook <keescook@chromium.org>
Cc: linux-kernel@vger.kernel.org, Greg Kroah-Hartman <gregkh@suse.de>,
Andrew Morton <akpm@linux-foundation.org>,
Arnd Bergmann <arnd@arndb.de>,
Nicolas Pitre <nicolas.pitre@linaro.org>,
Marco Stornelli <marco.stornelli@gmail.com>,
Paul Gortmaker <paul.gortmaker@windriver.com>
Subject: Re: [PATCH 1/2] ramoops: use pstore interface
Date: Fri, 18 Nov 2011 10:47:47 +0800 [thread overview]
Message-ID: <4EC5C753.6040904@linux.intel.com> (raw)
In-Reply-To: <CAGXu5jJfhLjBN4hEUNv5DaivJJaX5=15+JaC0VEON+mfDSeF+A@mail.gmail.com>
[...]
>>> + /* TODO(kees): It shouldn't be possible to remove ramoops since
>>> + * pstore doesn't support unregistering yet. When it does, remove
>>> + * this early return and add the unregister where noted below.
>>> + */
>>> + return -EBUSY;
>>
>> This style is not reasonable. Maybe it should have a better wrap.
>
> I'm not sure I understand what you mean. It's wrapped roughly to
> column 75 already. What would be better for this comment? Or did you
> mean I shouldn't have unreachable code?
I mean you shouldn't write unreachable codes. It looks weird.
>
>> BTW, you need to update Documentation/ramoops.txt
>
> Ah! Yes, thanks for the reminder.
>
> -Kees
>
next prev parent reply other threads:[~2011-11-18 2:47 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-16 21:25 [PATCH 0/2] ramoops: use pstore interface Kees Cook
2011-11-16 21:25 ` [PATCH 1/2] " Kees Cook
2011-11-17 5:35 ` Chen Gong
2011-11-17 18:10 ` Kees Cook
2011-11-18 2:47 ` Chen Gong [this message]
2011-11-17 15:07 ` Arnd Bergmann
2011-11-17 18:19 ` Kees Cook
2011-11-16 21:25 ` [PATCH 2/2] ramoops: remove module parameters Kees Cook
-- strict thread matches above, loose matches on Subject: below --
2011-11-18 19:31 [PATCH 0/2 v2] ramoops: use pstore interface Kees Cook
2011-11-18 19:31 ` [PATCH 1/2] " Kees Cook
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4EC5C753.6040904@linux.intel.com \
--to=gong.chen@linux.intel.com \
--cc=akpm@linux-foundation.org \
--cc=arnd@arndb.de \
--cc=gregkh@suse.de \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marco.stornelli@gmail.com \
--cc=nicolas.pitre@linaro.org \
--cc=paul.gortmaker@windriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).