* [PATCH] I2C: Make i2cdev_detach_adapter static
@ 2011-11-18 8:42 Shubhrajyoti D
2011-11-18 9:43 ` Jean Delvare
0 siblings, 1 reply; 3+ messages in thread
From: Shubhrajyoti D @ 2011-11-18 8:42 UTC (permalink / raw)
To: linux-i2c; +Cc: linux-kernel, Shubhrajyoti D
The function i2cdev_detach_adapter is used only in i2c-dev file
making it static.
Also removes the following sparse warning
drivers/i2c/i2c-dev.c:582:5: warning: symbol 'i2cdev_notifier_call'
was not declared. Should it be static?
Signed-off-by: Shubhrajyoti D <shubhrajyoti@ti.com>
---
drivers/i2c/i2c-dev.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/i2c/i2c-dev.c b/drivers/i2c/i2c-dev.c
index c90ce50..57a45ce 100644
--- a/drivers/i2c/i2c-dev.c
+++ b/drivers/i2c/i2c-dev.c
@@ -579,7 +579,7 @@ static int i2cdev_detach_adapter(struct device *dev, void *dummy)
return 0;
}
-int i2cdev_notifier_call(struct notifier_block *nb, unsigned long action,
+static int i2cdev_notifier_call(struct notifier_block *nb, unsigned long action,
void *data)
{
struct device *dev = data;
--
1.7.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] I2C: Make i2cdev_detach_adapter static
2011-11-18 8:42 [PATCH] I2C: Make i2cdev_detach_adapter static Shubhrajyoti D
@ 2011-11-18 9:43 ` Jean Delvare
2011-11-18 10:47 ` Shubhrajyoti
0 siblings, 1 reply; 3+ messages in thread
From: Jean Delvare @ 2011-11-18 9:43 UTC (permalink / raw)
To: Shubhrajyoti D; +Cc: linux-i2c, linux-kernel
On Fri, 18 Nov 2011 14:12:11 +0530, Shubhrajyoti D wrote:
> The function i2cdev_detach_adapter is used only in i2c-dev file
> making it static.
This description doesn't match what the patch actually does. Please
resubmit with proper subject and description.
> Also removes the following sparse warning
>
> drivers/i2c/i2c-dev.c:582:5: warning: symbol 'i2cdev_notifier_call'
> was not declared. Should it be static?
>
> Signed-off-by: Shubhrajyoti D <shubhrajyoti@ti.com>
> ---
> drivers/i2c/i2c-dev.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/i2c/i2c-dev.c b/drivers/i2c/i2c-dev.c
> index c90ce50..57a45ce 100644
> --- a/drivers/i2c/i2c-dev.c
> +++ b/drivers/i2c/i2c-dev.c
> @@ -579,7 +579,7 @@ static int i2cdev_detach_adapter(struct device *dev, void *dummy)
> return 0;
> }
>
> -int i2cdev_notifier_call(struct notifier_block *nb, unsigned long action,
> +static int i2cdev_notifier_call(struct notifier_block *nb, unsigned long action,
> void *data)
> {
> struct device *dev = data;
--
Jean Delvare
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] I2C: Make i2cdev_detach_adapter static
2011-11-18 9:43 ` Jean Delvare
@ 2011-11-18 10:47 ` Shubhrajyoti
0 siblings, 0 replies; 3+ messages in thread
From: Shubhrajyoti @ 2011-11-18 10:47 UTC (permalink / raw)
To: Jean Delvare; +Cc: linux-i2c, linux-kernel
On Friday 18 November 2011 03:13 PM, Jean Delvare wrote:
> On Fri, 18 Nov 2011 14:12:11 +0530, Shubhrajyoti D wrote:
>> The function i2cdev_detach_adapter is used only in i2c-dev file
>> making it static.
> This description doesn't match what the patch actually does. Please
> resubmit with proper subject and description.
Yes will correct it.
>> Also removes the following sparse warning
>>
>> drivers/i2c/i2c-dev.c:582:5: warning: symbol 'i2cdev_notifier_call'
>> was not declared. Should it be static?
>>
>> Signed-off-by: Shubhrajyoti D <shubhrajyoti@ti.com>
>> ---
>> drivers/i2c/i2c-dev.c | 2 +-
>> 1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/drivers/i2c/i2c-dev.c b/drivers/i2c/i2c-dev.c
>> index c90ce50..57a45ce 100644
>> --- a/drivers/i2c/i2c-dev.c
>> +++ b/drivers/i2c/i2c-dev.c
>> @@ -579,7 +579,7 @@ static int i2cdev_detach_adapter(struct device *dev, void *dummy)
>> return 0;
>> }
>>
>> -int i2cdev_notifier_call(struct notifier_block *nb, unsigned long action,
>> +static int i2cdev_notifier_call(struct notifier_block *nb, unsigned long action,
>> void *data)
>> {
>> struct device *dev = data;
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2011-11-18 10:48 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-11-18 8:42 [PATCH] I2C: Make i2cdev_detach_adapter static Shubhrajyoti D
2011-11-18 9:43 ` Jean Delvare
2011-11-18 10:47 ` Shubhrajyoti
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox