From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753511Ab1KTL3U (ORCPT ); Sun, 20 Nov 2011 06:29:20 -0500 Received: from mx1.redhat.com ([209.132.183.28]:63555 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753085Ab1KTL3T (ORCPT ); Sun, 20 Nov 2011 06:29:19 -0500 Message-ID: <4EC8E48B.9080204@redhat.com> Date: Sun, 20 Nov 2011 13:29:15 +0200 From: Avi Kivity User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:7.0.1) Gecko/20110930 Thunderbird/7.0.1 MIME-Version: 1.0 To: Xiao Guangrong CC: Marcelo Tosatti , LKML , KVM Subject: Re: [PATCH v2 0/6] KVM: optimize memslots searching References: <4EC6226B.3080408@linux.vnet.ibm.com> In-Reply-To: <4EC6226B.3080408@linux.vnet.ibm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/18/2011 11:16 AM, Xiao Guangrong wrote: > This is the more work base on my v1 patchset which is posted some months ago, > it can be found at: > https://lkml.org/lkml/2011/2/22/68 > > Change log: > - sort memslots base on its size and do the line search instead of binary > search base on gfn, it is from Avi's idea. > - in order to reduce cache footprint, memslots are sorted in the array of > kvm->memslots->memslots[] and introduce a table to map slot id to index in > the array > > There is the performance result: > > autotest for RHEL.6.1 setup/boot/reboot/shutdown(average): > ept=1: before: 449.5 after: 447.8 > ept=0: before: 532.7 after: 529.8 > > kernbench(average): > ept=1: before: 127.94 after: 126.98 > ept=0: before: 196.85 after: 189.66 Looks good, had a couple of comments but they're really minor. -- error compiling committee.c: too many arguments to function