Re: [PATCH] kconfig: Fix checking return value of 'fwrite'

Reinhard Tartler
2011-11-23T06:34:13Z

On Mi, Nov 23, 2011 at 06:53:51 (CET), Jean Sacren wrote:

> From: Michal Marek <mmarek@suse.cz>
> Date: Sun, 20 Nov 2011 14:24:35 +0100
>>
>> On 7.10.2011 05:29, Arnaud Lacombe wrote:
>> > Hi,
>> >
>> > 2011/10/6 Reinhard Tartler <Reinhard.Tartler@informatik.uni-erlangen.de>:
>> >> fwrite indicates '1' written member if a zero-length string is written.
>> > you forgot the "Signed-off-by: " part :)
>>
>> Reinhard, can I assume
>>
>> Signed-off-by: Reinhard Tartler
>> <Reinhard.Tartler@informatik.uni-erlangen.de>
>>
>> ? The patch is otherwise correct.
>
> I have two reasons to oppose this patch.
>
> 1. If 'len' value is zero, there is an issue already and it should be
> taken care of _before_ calling fwrite().

So you're saying the function assumes a non-empty string? Why? It is a
simple "writing-helper" and this seems a perfectly valid corner case to
me. Can you perhaps elaborate why you consider this corner case invalid
and require (possibly out-of-tree) callers to check this for themselves?

> 2. xfwrite() doesn't fix anything except for the compiler warning. It
> assumes this world is perfect and it's definitely not a place to take
> care of the zero-length string.

It seems to me that you rather oppose to the introduction of xfwrite()
than to the patch here at hand. Is that correct?

Cheers,
Reinhard

--
Reinhard Tartler Department of Computer Science IV
Martensstr 1, 91058 Erlangen Germany, University of Erlangen-Nuremberg