From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758685Ab1KVVin (ORCPT ); Tue, 22 Nov 2011 16:38:43 -0500 Received: from mail-yx0-f174.google.com ([209.85.213.174]:34974 "EHLO mail-yx0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757481Ab1KVVil (ORCPT ); Tue, 22 Nov 2011 16:38:41 -0500 Message-ID: <4ECC165D.60300@gmail.com> Date: Tue, 22 Nov 2011 13:38:37 -0800 From: David Daney User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.15) Gecko/20101027 Fedora/3.0.10-1.fc12 Thunderbird/3.0.10 MIME-Version: 1.0 To: Michal Marek CC: David Daney , "linux-mips@linux-mips.org" , "ralf@linux-mips.org" , "linux-kernel@vger.kernel.org" , "linux-arch@vger.kernel.org" , "linux-embedded@vger.kernel.org" , "x86@kernel.org" , David Daney Subject: Re: [PATCH RFC 3/5] kbuild/extable: Hook up sortextable into the build system. References: <1321645068-20475-1-git-send-email-ddaney.cavm@gmail.com> <1321645068-20475-4-git-send-email-ddaney.cavm@gmail.com> <4EC9046C.3050708@suse.cz> In-Reply-To: <4EC9046C.3050708@suse.cz> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/20/2011 05:45 AM, Michal Marek wrote: > On 18.11.2011 20:37, David Daney wrote: >> + $(if $(CONFIG_BUILDTIME_EXTABLE_SORT), \ >> + $(Q)$(if $($(quiet)cmd_sortextable), \ >> + echo ' $($(quiet)cmd_sortextable) vmlinux'&&) \ >> + $(cmd_sortextable) vmlinux) > > Why do you opencode $(call cmd,sortextable) here? > Mostly just mimicking the other code in the vicinity. I will try to improve it in the next version of the patch. Thanks, David Daney