From: Robert Hancock <hancockrwd@gmail.com>
To: David Miller <davem@davemloft.net>
Cc: michael@alpha-unix.de, linux-kernel@vger.kernel.org
Subject: Re: Kernelpanic on eeePC and MSI Wind (both using rt2800pci) with Linux 3.x
Date: Tue, 22 Nov 2011 19:49:33 -0600 [thread overview]
Message-ID: <4ECC512D.2010002@gmail.com> (raw)
In-Reply-To: <20111122.155557.1954460980055957565.davem@davemloft.net>
On 11/22/2011 02:55 PM, David Miller wrote:
> From: Michael Basse<michael@alpha-unix.de>
> Date: Tue, 22 Nov 2011 21:49:49 +0100
>
>> Hi,
>>
>> just for the record. This thread is hopefully providing a patch
>>
>> http://thread.gmane.org/gmane.linux.kernel.wireless.general/80759
>>
>> already built the kernel and doing some testing now.
>
> That patch is wrong, it returns IRQ_HANDLED when it can't tell if the
> chip generated the interrupt or not.
>
> Therefore, if any other device shares that interrupt line it's
> interrupts can be lost when this case triggers.
>
> This has to be fixed another way.
Huh? IRQ_HANDLED is the "safe" return value when you don't know for sure
whether your device generated the interrupt. Returning that doesn't
prevent other handlers on the same IRQ from being called.
next prev parent reply other threads:[~2011-11-23 1:49 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-04 15:10 Kernelpanic on eeePC and MSI Wind (both using rt2800pci) with Linux 3.x Michael Basse
2011-11-07 0:25 ` Michael Basse
2011-11-13 9:52 ` Michael Basse
2011-11-22 20:49 ` Michael Basse
2011-11-22 20:55 ` David Miller
2011-11-23 1:49 ` Robert Hancock [this message]
2011-11-23 4:21 ` David Miller
2011-11-23 5:48 ` Robert Hancock
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4ECC512D.2010002@gmail.com \
--to=hancockrwd@gmail.com \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=michael@alpha-unix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox