From: Viresh Kumar <viresh.kumar@st.com>
To: Vinod Koul <vinod.koul@intel.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Armando VISCONTI <armando.visconti@st.com>,
Shiraz HASHIM <shiraz.hashim@st.com>,
Vipin KUMAR <vipin.kumar@st.com>,
Rajeev KUMAR <rajeev-dlh.kumar@st.com>,
Deepak SIKRI <deepak.sikri@st.com>,
Vipul Kumar SAMAR <vipulkumar.samar@st.com>,
Amit VIRDI <Amit.VIRDI@st.com>,
Pratyush ANAND <pratyush.anand@st.com>,
Bhupesh SHARMA <bhupesh.sharma@st.com>,
"viresh.linux@gmail.com" <viresh.linux@gmail.com>,
Bhavna YADAV <bhavna.yadav@st.com>,
Vincenzo FRASCINO <Vincenzo.FRASCINO@st.com>,
Mirko GARDI <mirko.gardi@st.com>
Subject: Re: [PATCH] dmaengine/dw_dmac: Reconfigure interrupt and chan_cfg register on resume
Date: Wed, 23 Nov 2011 16:41:48 +0530 [thread overview]
Message-ID: <4ECCD4F4.8080903@st.com> (raw)
In-Reply-To: <1322045375.1516.249.camel@vkoul-udesk3>
On 11/23/2011 4:19 PM, Vinod Koul wrote:
> then why not perform save and restore in your suspend and restore
> callbacks. That way you don't pay penalty of doing that in every alloc
> as you seem to be doing now?
Not actually. I am not saving anything to be restored after suspend.
There are few things (configuring CFG regs and enabling interrupts),
which are done earlier on alloc_channels. As this will not be called after
resume, so we need to set them again.
What i have done is, removed all this stuff from alloc channels and moved it
to dwc_dostart(). Here, i am checking if channel is already programmed or not.
If not (Can happen only in two cases: On resume and other on fresh channel alloc),
i configure them. So there is no save/restore actually done.
--
viresh
next prev parent reply other threads:[~2011-11-23 11:12 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-17 10:31 [PATCH] dmaengine/dw_dmac: Reconfigure interrupt and chan_cfg register on resume Viresh Kumar
2011-11-22 4:13 ` Vinod Koul
2011-11-22 6:20 ` Viresh Kumar
2011-11-23 10:49 ` Vinod Koul
2011-11-23 11:11 ` Viresh Kumar [this message]
2011-11-23 11:32 ` Vinod Koul
2011-11-23 11:40 ` Viresh Kumar
2011-11-28 3:20 ` Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4ECCD4F4.8080903@st.com \
--to=viresh.kumar@st.com \
--cc=Amit.VIRDI@st.com \
--cc=Vincenzo.FRASCINO@st.com \
--cc=armando.visconti@st.com \
--cc=bhavna.yadav@st.com \
--cc=bhupesh.sharma@st.com \
--cc=deepak.sikri@st.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mirko.gardi@st.com \
--cc=pratyush.anand@st.com \
--cc=rajeev-dlh.kumar@st.com \
--cc=shiraz.hashim@st.com \
--cc=vinod.koul@intel.com \
--cc=vipin.kumar@st.com \
--cc=vipulkumar.samar@st.com \
--cc=viresh.linux@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox