* [PATCH 02/11] TTY: Remove redundant spi driver bus initialization
2011-11-24 15:29 [PATCH 01/11] RTC: Remove redundant spi driver bus initialization Lars-Peter Clausen
@ 2011-11-24 15:29 ` Lars-Peter Clausen
2011-11-27 4:17 ` Greg KH
2011-11-24 15:29 ` [PATCH 03/11] Input: " Lars-Peter Clausen
` (8 subsequent siblings)
9 siblings, 1 reply; 23+ messages in thread
From: Lars-Peter Clausen @ 2011-11-24 15:29 UTC (permalink / raw)
To: linux-kernel; +Cc: Lars-Peter Clausen, open list:SERIAL DRIVERS
In ancient times it was necessary to manually initialize the bus field of an
spi_driver to spi_bus_type. These days this is done in spi_driver_register(),
so we can drop the manual assignment.
The patch was generated using the following coccinelle semantic patch:
// <smpl>
@@
identifier _driver;
@@
struct spi_driver _driver = {
.driver = {
- .bus = &spi_bus_type,
},
};
// </smpl>
Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>
Cc: Alan Cox <alan@linux.intel.com> (maintainer:SERIAL DRIVERS)
Cc: linux-serial@vger.kernel.org (open list:SERIAL DRIVERS)
---
drivers/tty/serial/ifx6x60.c | 1 -
drivers/tty/serial/max3100.c | 1 -
drivers/tty/serial/max3107-aava.c | 1 -
drivers/tty/serial/max3107.c | 1 -
drivers/tty/serial/mrst_max3110.c | 1 -
5 files changed, 0 insertions(+), 5 deletions(-)
diff --git a/drivers/tty/serial/ifx6x60.c b/drivers/tty/serial/ifx6x60.c
index 426434e..7e925e2 100644
--- a/drivers/tty/serial/ifx6x60.c
+++ b/drivers/tty/serial/ifx6x60.c
@@ -1334,7 +1334,6 @@ MODULE_DEVICE_TABLE(spi, ifx_id_table);
static const struct spi_driver ifx_spi_driver = {
.driver = {
.name = DRVNAME,
- .bus = &spi_bus_type,
.pm = &ifx_spi_pm,
.owner = THIS_MODULE},
.probe = ifx_spi_spi_probe,
diff --git a/drivers/tty/serial/max3100.c b/drivers/tty/serial/max3100.c
index 8a6cc8c..b4902b9 100644
--- a/drivers/tty/serial/max3100.c
+++ b/drivers/tty/serial/max3100.c
@@ -901,7 +901,6 @@ static int max3100_resume(struct spi_device *spi)
static struct spi_driver max3100_driver = {
.driver = {
.name = "max3100",
- .bus = &spi_bus_type,
.owner = THIS_MODULE,
},
diff --git a/drivers/tty/serial/max3107-aava.c b/drivers/tty/serial/max3107-aava.c
index 90c40f2..aae772a 100644
--- a/drivers/tty/serial/max3107-aava.c
+++ b/drivers/tty/serial/max3107-aava.c
@@ -315,7 +315,6 @@ static int __devinit max3107_probe_aava(struct spi_device *spi)
static struct spi_driver max3107_driver = {
.driver = {
.name = "aava-max3107",
- .bus = &spi_bus_type,
.owner = THIS_MODULE,
},
.probe = max3107_probe_aava,
diff --git a/drivers/tty/serial/max3107.c b/drivers/tty/serial/max3107.c
index 7827000..17c7ba8 100644
--- a/drivers/tty/serial/max3107.c
+++ b/drivers/tty/serial/max3107.c
@@ -1181,7 +1181,6 @@ static int max3107_probe_generic(struct spi_device *spi)
static struct spi_driver max3107_driver = {
.driver = {
.name = "max3107",
- .bus = &spi_bus_type,
.owner = THIS_MODULE,
},
.probe = max3107_probe_generic,
diff --git a/drivers/tty/serial/mrst_max3110.c b/drivers/tty/serial/mrst_max3110.c
index 4c309e8..df2a224 100644
--- a/drivers/tty/serial/mrst_max3110.c
+++ b/drivers/tty/serial/mrst_max3110.c
@@ -876,7 +876,6 @@ static int __devexit serial_m3110_remove(struct spi_device *dev)
static struct spi_driver uart_max3110_driver = {
.driver = {
.name = "spi_max3111",
- .bus = &spi_bus_type,
.owner = THIS_MODULE,
},
.probe = serial_m3110_probe,
--
1.7.7.1
^ permalink raw reply related [flat|nested] 23+ messages in thread* Re: [PATCH 02/11] TTY: Remove redundant spi driver bus initialization
2011-11-24 15:29 ` [PATCH 02/11] TTY: " Lars-Peter Clausen
@ 2011-11-27 4:17 ` Greg KH
0 siblings, 0 replies; 23+ messages in thread
From: Greg KH @ 2011-11-27 4:17 UTC (permalink / raw)
To: Lars-Peter Clausen; +Cc: linux-kernel, open list:SERIAL DRIVERS
On Thu, Nov 24, 2011 at 04:29:12PM +0100, Lars-Peter Clausen wrote:
> In ancient times it was necessary to manually initialize the bus field of an
> spi_driver to spi_bus_type. These days this is done in spi_driver_register(),
> so we can drop the manual assignment.
>
> The patch was generated using the following coccinelle semantic patch:
> // <smpl>
> @@
> identifier _driver;
> @@
> struct spi_driver _driver = {
> .driver = {
> - .bus = &spi_bus_type,
> },
> };
> // </smpl>
>
> Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>
> Cc: Alan Cox <alan@linux.intel.com> (maintainer:SERIAL DRIVERS)
> Cc: linux-serial@vger.kernel.org (open list:SERIAL DRIVERS)
The () isn't needed, or nice, as I now need to edit this file by hand
and remove that text. When applying 400+ patches in a single day, it
gets old fast...
thanks,
greg k-h
^ permalink raw reply [flat|nested] 23+ messages in thread
* [PATCH 03/11] Input: Remove redundant spi driver bus initialization
2011-11-24 15:29 [PATCH 01/11] RTC: Remove redundant spi driver bus initialization Lars-Peter Clausen
2011-11-24 15:29 ` [PATCH 02/11] TTY: " Lars-Peter Clausen
@ 2011-11-24 15:29 ` Lars-Peter Clausen
2011-11-24 15:29 ` [PATCH 04/11] hwmon: " Lars-Peter Clausen
` (7 subsequent siblings)
9 siblings, 0 replies; 23+ messages in thread
From: Lars-Peter Clausen @ 2011-11-24 15:29 UTC (permalink / raw)
To: linux-kernel
Cc: Lars-Peter Clausen, Dmitry Torokhov, Michael Hennerich,
linux-input
In ancient times it was necessary to manually initialize the bus field of an
spi_driver to spi_bus_type. These days this is done in spi_driver_register(),
so we can drop the manual assignment.
The patch was generated using the following coccinelle semantic patch:
// <smpl>
@@
identifier _driver;
@@
struct spi_driver _driver = {
.driver = {
- .bus = &spi_bus_type,
},
};
// </smpl>
Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: Michael Hennerich <michael.hennerich@analog.com>
Cc: linux-input@vger.kernel.org
---
drivers/input/misc/adxl34x-spi.c | 1 -
drivers/input/touchscreen/ad7877.c | 1 -
drivers/input/touchscreen/ad7879-spi.c | 1 -
drivers/input/touchscreen/ads7846.c | 1 -
4 files changed, 0 insertions(+), 4 deletions(-)
diff --git a/drivers/input/misc/adxl34x-spi.c b/drivers/input/misc/adxl34x-spi.c
index f29de22..34d401e 100644
--- a/drivers/input/misc/adxl34x-spi.c
+++ b/drivers/input/misc/adxl34x-spi.c
@@ -122,7 +122,6 @@ static SIMPLE_DEV_PM_OPS(adxl34x_spi_pm, adxl34x_spi_suspend,
static struct spi_driver adxl34x_driver = {
.driver = {
.name = "adxl34x",
- .bus = &spi_bus_type,
.owner = THIS_MODULE,
.pm = &adxl34x_spi_pm,
},
diff --git a/drivers/input/touchscreen/ad7877.c b/drivers/input/touchscreen/ad7877.c
index 2da9f18..42ae7a2 100644
--- a/drivers/input/touchscreen/ad7877.c
+++ b/drivers/input/touchscreen/ad7877.c
@@ -853,7 +853,6 @@ static SIMPLE_DEV_PM_OPS(ad7877_pm, ad7877_suspend, ad7877_resume);
static struct spi_driver ad7877_driver = {
.driver = {
.name = "ad7877",
- .bus = &spi_bus_type,
.owner = THIS_MODULE,
.pm = &ad7877_pm,
},
diff --git a/drivers/input/touchscreen/ad7879-spi.c b/drivers/input/touchscreen/ad7879-spi.c
index 8f391ff..9b2e1c2 100644
--- a/drivers/input/touchscreen/ad7879-spi.c
+++ b/drivers/input/touchscreen/ad7879-spi.c
@@ -150,7 +150,6 @@ static int __devexit ad7879_spi_remove(struct spi_device *spi)
static struct spi_driver ad7879_spi_driver = {
.driver = {
.name = "ad7879",
- .bus = &spi_bus_type,
.owner = THIS_MODULE,
.pm = &ad7879_pm_ops,
},
diff --git a/drivers/input/touchscreen/ads7846.c b/drivers/input/touchscreen/ads7846.c
index 4cedae6..23fd901 100644
--- a/drivers/input/touchscreen/ads7846.c
+++ b/drivers/input/touchscreen/ads7846.c
@@ -1426,7 +1426,6 @@ static int __devexit ads7846_remove(struct spi_device *spi)
static struct spi_driver ads7846_driver = {
.driver = {
.name = "ads7846",
- .bus = &spi_bus_type,
.owner = THIS_MODULE,
.pm = &ads7846_pm,
},
--
1.7.7.1
^ permalink raw reply related [flat|nested] 23+ messages in thread* [PATCH 04/11] hwmon: Remove redundant spi driver bus initialization
2011-11-24 15:29 [PATCH 01/11] RTC: Remove redundant spi driver bus initialization Lars-Peter Clausen
2011-11-24 15:29 ` [PATCH 02/11] TTY: " Lars-Peter Clausen
2011-11-24 15:29 ` [PATCH 03/11] Input: " Lars-Peter Clausen
@ 2011-11-24 15:29 ` Lars-Peter Clausen
2011-11-25 9:58 ` Guenter Roeck
2011-11-25 17:29 ` Guenter Roeck
2011-11-24 15:29 ` [PATCH 05/11] mfd: " Lars-Peter Clausen
` (6 subsequent siblings)
9 siblings, 2 replies; 23+ messages in thread
From: Lars-Peter Clausen @ 2011-11-24 15:29 UTC (permalink / raw)
To: linux-kernel; +Cc: Lars-Peter Clausen, Jean Delvare, Guenter Roeck, lm-sensors
In ancient times it was necessary to manually initialize the bus field of an
spi_driver to spi_bus_type. These days this is done in spi_driver_register(),
so we can drop the manual assignment.
The patch was generated using the following coccinelle semantic patch:
// <smpl>
@@
identifier _driver;
@@
struct spi_driver _driver = {
.driver = {
- .bus = &spi_bus_type,
},
};
// </smpl>
Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>
Cc: Jean Delvare <khali@linux-fr.org>
Cc: Guenter Roeck <guenter.roeck@ericsson.com>
Cc: lm-sensors@lm-sensors.org
---
drivers/hwmon/ad7314.c | 1 -
drivers/hwmon/ads7871.c | 1 -
2 files changed, 0 insertions(+), 2 deletions(-)
diff --git a/drivers/hwmon/ad7314.c b/drivers/hwmon/ad7314.c
index 318e38e..5d760f3 100644
--- a/drivers/hwmon/ad7314.c
+++ b/drivers/hwmon/ad7314.c
@@ -160,7 +160,6 @@ MODULE_DEVICE_TABLE(spi, ad7314_id);
static struct spi_driver ad7314_driver = {
.driver = {
.name = "ad7314",
- .bus = &spi_bus_type,
.owner = THIS_MODULE,
},
.probe = ad7314_probe,
diff --git a/drivers/hwmon/ads7871.c b/drivers/hwmon/ads7871.c
index 5231934..04450f8 100644
--- a/drivers/hwmon/ads7871.c
+++ b/drivers/hwmon/ads7871.c
@@ -227,7 +227,6 @@ static int __devexit ads7871_remove(struct spi_device *spi)
static struct spi_driver ads7871_driver = {
.driver = {
.name = DEVICE_NAME,
- .bus = &spi_bus_type,
.owner = THIS_MODULE,
},
--
1.7.7.1
^ permalink raw reply related [flat|nested] 23+ messages in thread* Re: [PATCH 04/11] hwmon: Remove redundant spi driver bus initialization
2011-11-24 15:29 ` [PATCH 04/11] hwmon: " Lars-Peter Clausen
@ 2011-11-25 9:58 ` Guenter Roeck
2011-11-25 13:02 ` Jean Delvare
2011-11-25 17:29 ` Guenter Roeck
1 sibling, 1 reply; 23+ messages in thread
From: Guenter Roeck @ 2011-11-25 9:58 UTC (permalink / raw)
To: Lars-Peter Clausen
Cc: linux-kernel@vger.kernel.org, Jean Delvare,
lm-sensors@lm-sensors.org
On Thu, Nov 24, 2011 at 10:29:14AM -0500, Lars-Peter Clausen wrote:
> In ancient times it was necessary to manually initialize the bus field of an
> spi_driver to spi_bus_type. These days this is done in spi_driver_register(),
s/spi_driver_register/spi_register_driver/
Otherwise
Acked-by: Guenter Roeck <guenter.roeck@ericsson.com>
Jean, ok if I take this and the others, or do you want to handle it ?
Guenter
> so we can drop the manual assignment.
>
> The patch was generated using the following coccinelle semantic patch:
> // <smpl>
> @@
> identifier _driver;
> @@
> struct spi_driver _driver = {
> .driver = {
> - .bus = &spi_bus_type,
> },
> };
> // </smpl>
>
> Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>
> Cc: Jean Delvare <khali@linux-fr.org>
> Cc: Guenter Roeck <guenter.roeck@ericsson.com>
> Cc: lm-sensors@lm-sensors.org
> ---
> drivers/hwmon/ad7314.c | 1 -
> drivers/hwmon/ads7871.c | 1 -
> 2 files changed, 0 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/hwmon/ad7314.c b/drivers/hwmon/ad7314.c
> index 318e38e..5d760f3 100644
> --- a/drivers/hwmon/ad7314.c
> +++ b/drivers/hwmon/ad7314.c
> @@ -160,7 +160,6 @@ MODULE_DEVICE_TABLE(spi, ad7314_id);
> static struct spi_driver ad7314_driver = {
> .driver = {
> .name = "ad7314",
> - .bus = &spi_bus_type,
> .owner = THIS_MODULE,
> },
> .probe = ad7314_probe,
> diff --git a/drivers/hwmon/ads7871.c b/drivers/hwmon/ads7871.c
> index 5231934..04450f8 100644
> --- a/drivers/hwmon/ads7871.c
> +++ b/drivers/hwmon/ads7871.c
> @@ -227,7 +227,6 @@ static int __devexit ads7871_remove(struct spi_device *spi)
> static struct spi_driver ads7871_driver = {
> .driver = {
> .name = DEVICE_NAME,
> - .bus = &spi_bus_type,
> .owner = THIS_MODULE,
> },
>
> --
> 1.7.7.1
>
>
--
Guenter Roeck
Distinguished Engineer
PDU IP Systems
^ permalink raw reply [flat|nested] 23+ messages in thread* Re: [PATCH 04/11] hwmon: Remove redundant spi driver bus initialization
2011-11-25 9:58 ` Guenter Roeck
@ 2011-11-25 13:02 ` Jean Delvare
0 siblings, 0 replies; 23+ messages in thread
From: Jean Delvare @ 2011-11-25 13:02 UTC (permalink / raw)
To: Guenter Roeck; +Cc: Lars-Peter Clausen, linux-kernel, lm-sensors
On Fri, 25 Nov 2011 01:58:23 -0800, Guenter Roeck wrote:
> On Thu, Nov 24, 2011 at 10:29:14AM -0500, Lars-Peter Clausen wrote:
> > In ancient times it was necessary to manually initialize the bus field of an
> > spi_driver to spi_bus_type. These days this is done in spi_driver_register(),
>
> s/spi_driver_register/spi_register_driver/
>
> Otherwise
>
> Acked-by: Guenter Roeck <guenter.roeck@ericsson.com>
>
> Jean, ok if I take this and the others, or do you want to handle it ?
Please take them.
Thanks,
--
Jean Delvare
^ permalink raw reply [flat|nested] 23+ messages in thread
* Re: [PATCH 04/11] hwmon: Remove redundant spi driver bus initialization
2011-11-24 15:29 ` [PATCH 04/11] hwmon: " Lars-Peter Clausen
2011-11-25 9:58 ` Guenter Roeck
@ 2011-11-25 17:29 ` Guenter Roeck
1 sibling, 0 replies; 23+ messages in thread
From: Guenter Roeck @ 2011-11-25 17:29 UTC (permalink / raw)
To: Lars-Peter Clausen
Cc: linux-kernel@vger.kernel.org, Jean Delvare,
lm-sensors@lm-sensors.org
On Thu, Nov 24, 2011 at 10:29:14AM -0500, Lars-Peter Clausen wrote:
> In ancient times it was necessary to manually initialize the bus field of an
> spi_driver to spi_bus_type. These days this is done in spi_driver_register(),
> so we can drop the manual assignment.
>
> The patch was generated using the following coccinelle semantic patch:
> // <smpl>
> @@
> identifier _driver;
> @@
> struct spi_driver _driver = {
> .driver = {
> - .bus = &spi_bus_type,
> },
> };
> // </smpl>
>
> Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>
> Cc: Jean Delvare <khali@linux-fr.org>
> Cc: Guenter Roeck <guenter.roeck@ericsson.com>
> Cc: lm-sensors@lm-sensors.org
Applied.
Thanks,
Guenter
^ permalink raw reply [flat|nested] 23+ messages in thread
* [PATCH 05/11] mfd: Remove redundant spi driver bus initialization
2011-11-24 15:29 [PATCH 01/11] RTC: Remove redundant spi driver bus initialization Lars-Peter Clausen
` (2 preceding siblings ...)
2011-11-24 15:29 ` [PATCH 04/11] hwmon: " Lars-Peter Clausen
@ 2011-11-24 15:29 ` Lars-Peter Clausen
2011-11-24 15:29 ` Mark Brown
2011-12-12 14:42 ` Samuel Ortiz
2011-11-24 15:29 ` [PATCH 06/11] mtd: " Lars-Peter Clausen
` (5 subsequent siblings)
9 siblings, 2 replies; 23+ messages in thread
From: Lars-Peter Clausen @ 2011-11-24 15:29 UTC (permalink / raw)
To: linux-kernel; +Cc: Lars-Peter Clausen, Samuel Ortiz, Mark Brown
In ancient times it was necessary to manually initialize the bus field of an
spi_driver to spi_bus_type. These days this is done in spi_driver_register(),
so we can drop the manual assignment.
The patch was generated using the following coccinelle semantic patch:
// <smpl>
@@
identifier _driver;
@@
struct spi_driver _driver = {
.driver = {
- .bus = &spi_bus_type,
},
};
// </smpl>
Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>
Cc: Samuel Ortiz <sameo@linux.intel.com>
Cc: Mark Brown <broonie@opensource.wolfsonmicro.com>
---
drivers/mfd/mc13xxx-core.c | 1 -
drivers/mfd/tps65912-spi.c | 1 -
drivers/mfd/wm831x-spi.c | 1 -
3 files changed, 0 insertions(+), 3 deletions(-)
diff --git a/drivers/mfd/mc13xxx-core.c b/drivers/mfd/mc13xxx-core.c
index e9619ac..4417380 100644
--- a/drivers/mfd/mc13xxx-core.c
+++ b/drivers/mfd/mc13xxx-core.c
@@ -805,7 +805,6 @@ static struct spi_driver mc13xxx_driver = {
.id_table = mc13xxx_device_id,
.driver = {
.name = "mc13xxx",
- .bus = &spi_bus_type,
.owner = THIS_MODULE,
},
.probe = mc13xxx_probe,
diff --git a/drivers/mfd/tps65912-spi.c b/drivers/mfd/tps65912-spi.c
index 6d71e0d..27d3302 100644
--- a/drivers/mfd/tps65912-spi.c
+++ b/drivers/mfd/tps65912-spi.c
@@ -111,7 +111,6 @@ static int __devexit tps65912_spi_remove(struct spi_device *spi)
static struct spi_driver tps65912_spi_driver = {
.driver = {
.name = "tps65912",
- .bus = &spi_bus_type,
.owner = THIS_MODULE,
},
.probe = tps65912_spi_probe,
diff --git a/drivers/mfd/wm831x-spi.c b/drivers/mfd/wm831x-spi.c
index 8d6a9a9..37b3756 100644
--- a/drivers/mfd/wm831x-spi.c
+++ b/drivers/mfd/wm831x-spi.c
@@ -95,7 +95,6 @@ MODULE_DEVICE_TABLE(spi, wm831x_spi_id);
static struct spi_driver wm831x_spi_driver = {
.driver = {
.name = "wm831x",
- .bus = &spi_bus_type,
.owner = THIS_MODULE,
.pm = &wm831x_spi_pm,
},
--
1.7.7.1
^ permalink raw reply related [flat|nested] 23+ messages in thread* Re: [PATCH 05/11] mfd: Remove redundant spi driver bus initialization
2011-11-24 15:29 ` [PATCH 05/11] mfd: " Lars-Peter Clausen
@ 2011-11-24 15:29 ` Mark Brown
2011-12-12 14:42 ` Samuel Ortiz
1 sibling, 0 replies; 23+ messages in thread
From: Mark Brown @ 2011-11-24 15:29 UTC (permalink / raw)
To: Lars-Peter Clausen; +Cc: linux-kernel, Samuel Ortiz
On Thu, Nov 24, 2011 at 04:29:15PM +0100, Lars-Peter Clausen wrote:
> In ancient times it was necessary to manually initialize the bus field of an
> spi_driver to spi_bus_type. These days this is done in spi_driver_register(),
> so we can drop the manual assignment.
Acked-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
^ permalink raw reply [flat|nested] 23+ messages in thread
* Re: [PATCH 05/11] mfd: Remove redundant spi driver bus initialization
2011-11-24 15:29 ` [PATCH 05/11] mfd: " Lars-Peter Clausen
2011-11-24 15:29 ` Mark Brown
@ 2011-12-12 14:42 ` Samuel Ortiz
1 sibling, 0 replies; 23+ messages in thread
From: Samuel Ortiz @ 2011-12-12 14:42 UTC (permalink / raw)
To: Lars-Peter Clausen; +Cc: linux-kernel, Mark Brown
Hi Lars,
On Thu, Nov 24, 2011 at 04:29:15PM +0100, Lars-Peter Clausen wrote:
> In ancient times it was necessary to manually initialize the bus field of an
> spi_driver to spi_bus_type. These days this is done in spi_driver_register(),
> so we can drop the manual assignment.
Thanks for the cleanup, I applied this one.
Cheers,
Samuel.
--
Intel Open Source Technology Centre
http://oss.intel.com/
^ permalink raw reply [flat|nested] 23+ messages in thread
* [PATCH 06/11] mtd: Remove redundant spi driver bus initialization
2011-11-24 15:29 [PATCH 01/11] RTC: Remove redundant spi driver bus initialization Lars-Peter Clausen
` (3 preceding siblings ...)
2011-11-24 15:29 ` [PATCH 05/11] mfd: " Lars-Peter Clausen
@ 2011-11-24 15:29 ` Lars-Peter Clausen
2011-12-01 7:58 ` Artem Bityutskiy
2011-11-24 15:29 ` [PATCH 07/11] mmc: " Lars-Peter Clausen
` (4 subsequent siblings)
9 siblings, 1 reply; 23+ messages in thread
From: Lars-Peter Clausen @ 2011-11-24 15:29 UTC (permalink / raw)
To: linux-kernel
Cc: Lars-Peter Clausen, David Woodhouse, Artem Bityutskiy, linux-mtd
In ancient times it was necessary to manually initialize the bus field of an
spi_driver to spi_bus_type. These days this is done in spi_driver_register(),
so we can drop the manual assignment.
The patch was generated using the following coccinelle semantic patch:
// <smpl>
@@
identifier _driver;
@@
struct spi_driver _driver = {
.driver = {
- .bus = &spi_bus_type,
},
};
// </smpl>
Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>
Cc: David Woodhouse <dwmw2@infradead.org>
Cc: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
Cc: linux-mtd@lists.infradead.org
---
drivers/mtd/devices/m25p80.c | 1 -
drivers/mtd/devices/mtd_dataflash.c | 1 -
drivers/mtd/devices/sst25l.c | 1 -
3 files changed, 0 insertions(+), 3 deletions(-)
diff --git a/drivers/mtd/devices/m25p80.c b/drivers/mtd/devices/m25p80.c
index 884904d..7c60ddd 100644
--- a/drivers/mtd/devices/m25p80.c
+++ b/drivers/mtd/devices/m25p80.c
@@ -992,7 +992,6 @@ static int __devexit m25p_remove(struct spi_device *spi)
static struct spi_driver m25p80_driver = {
.driver = {
.name = "m25p80",
- .bus = &spi_bus_type,
.owner = THIS_MODULE,
},
.id_table = m25p_ids,
diff --git a/drivers/mtd/devices/mtd_dataflash.c b/drivers/mtd/devices/mtd_dataflash.c
index d75c7af..236057e 100644
--- a/drivers/mtd/devices/mtd_dataflash.c
+++ b/drivers/mtd/devices/mtd_dataflash.c
@@ -936,7 +936,6 @@ static int __devexit dataflash_remove(struct spi_device *spi)
static struct spi_driver dataflash_driver = {
.driver = {
.name = "mtd_dataflash",
- .bus = &spi_bus_type,
.owner = THIS_MODULE,
.of_match_table = dataflash_dt_ids,
},
diff --git a/drivers/mtd/devices/sst25l.c b/drivers/mtd/devices/sst25l.c
index d38ef3b..e45f62e 100644
--- a/drivers/mtd/devices/sst25l.c
+++ b/drivers/mtd/devices/sst25l.c
@@ -444,7 +444,6 @@ static int __devexit sst25l_remove(struct spi_device *spi)
static struct spi_driver sst25l_driver = {
.driver = {
.name = "sst25l",
- .bus = &spi_bus_type,
.owner = THIS_MODULE,
},
.probe = sst25l_probe,
--
1.7.7.1
^ permalink raw reply related [flat|nested] 23+ messages in thread* Re: [PATCH 06/11] mtd: Remove redundant spi driver bus initialization
2011-11-24 15:29 ` [PATCH 06/11] mtd: " Lars-Peter Clausen
@ 2011-12-01 7:58 ` Artem Bityutskiy
0 siblings, 0 replies; 23+ messages in thread
From: Artem Bityutskiy @ 2011-12-01 7:58 UTC (permalink / raw)
To: Lars-Peter Clausen
Cc: linux-kernel, Artem Bityutskiy, David Woodhouse, linux-mtd
On Thu, 2011-11-24 at 16:29 +0100, Lars-Peter Clausen wrote:
> In ancient times it was necessary to manually initialize the bus field of an
> spi_driver to spi_bus_type. These days this is done in spi_driver_register(),
> so we can drop the manual assignment.
Pushed to l2-mtd-2.6.git, thanks!
Artem.
^ permalink raw reply [flat|nested] 23+ messages in thread
* [PATCH 07/11] mmc: Remove redundant spi driver bus initialization
2011-11-24 15:29 [PATCH 01/11] RTC: Remove redundant spi driver bus initialization Lars-Peter Clausen
` (4 preceding siblings ...)
2011-11-24 15:29 ` [PATCH 06/11] mtd: " Lars-Peter Clausen
@ 2011-11-24 15:29 ` Lars-Peter Clausen
2011-12-01 18:39 ` Chris Ball
2011-11-24 15:29 ` [PATCH 08/11] blacklight: " Lars-Peter Clausen
` (3 subsequent siblings)
9 siblings, 1 reply; 23+ messages in thread
From: Lars-Peter Clausen @ 2011-11-24 15:29 UTC (permalink / raw)
To: linux-kernel; +Cc: Lars-Peter Clausen, Chris Ball, linux-mmc
In ancient times it was necessary to manually initialize the bus field of an
spi_driver to spi_bus_type. These days this is done in spi_driver_register(),
so we can drop the manual assignment.
The patch was generated using the following coccinelle semantic patch:
// <smpl>
@@
identifier _driver;
@@
struct spi_driver _driver = {
.driver = {
- .bus = &spi_bus_type,
},
};
// </smpl>
Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>
Cc: Chris Ball <cjb@laptop.org>
Cc: linux-mmc@vger.kernel.org
---
drivers/mmc/host/mmc_spi.c | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/drivers/mmc/host/mmc_spi.c b/drivers/mmc/host/mmc_spi.c
index 92946b8..273306c 100644
--- a/drivers/mmc/host/mmc_spi.c
+++ b/drivers/mmc/host/mmc_spi.c
@@ -1525,7 +1525,6 @@ static struct of_device_id mmc_spi_of_match_table[] __devinitdata = {
static struct spi_driver mmc_spi_driver = {
.driver = {
.name = "mmc_spi",
- .bus = &spi_bus_type,
.owner = THIS_MODULE,
.of_match_table = mmc_spi_of_match_table,
},
--
1.7.7.1
^ permalink raw reply related [flat|nested] 23+ messages in thread* Re: [PATCH 07/11] mmc: Remove redundant spi driver bus initialization
2011-11-24 15:29 ` [PATCH 07/11] mmc: " Lars-Peter Clausen
@ 2011-12-01 18:39 ` Chris Ball
0 siblings, 0 replies; 23+ messages in thread
From: Chris Ball @ 2011-12-01 18:39 UTC (permalink / raw)
To: Lars-Peter Clausen; +Cc: linux-kernel, linux-mmc
Hi Lars,
On Thu, Nov 24 2011, Lars-Peter Clausen wrote:
> In ancient times it was necessary to manually initialize the bus field of an
> spi_driver to spi_bus_type. These days this is done in spi_driver_register(),
> so we can drop the manual assignment.
>
> The patch was generated using the following coccinelle semantic patch:
> // <smpl>
> @@
> identifier _driver;
> @@
> struct spi_driver _driver = {
> .driver = {
> - .bus = &spi_bus_type,
> },
> };
> // </smpl>
>
> Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>
> Cc: Chris Ball <cjb@laptop.org>
> Cc: linux-mmc@vger.kernel.org
> ---
> drivers/mmc/host/mmc_spi.c | 1 -
> 1 files changed, 0 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/mmc/host/mmc_spi.c b/drivers/mmc/host/mmc_spi.c
> index 92946b8..273306c 100644
> --- a/drivers/mmc/host/mmc_spi.c
> +++ b/drivers/mmc/host/mmc_spi.c
> @@ -1525,7 +1525,6 @@ static struct of_device_id mmc_spi_of_match_table[] __devinitdata = {
> static struct spi_driver mmc_spi_driver = {
> .driver = {
> .name = "mmc_spi",
> - .bus = &spi_bus_type,
> .owner = THIS_MODULE,
> .of_match_table = mmc_spi_of_match_table,
> },
Thanks, pushed to mmc-next for 3.3.
- Chris.
--
Chris Ball <cjb@laptop.org> <http://printf.net/>
One Laptop Per Child
^ permalink raw reply [flat|nested] 23+ messages in thread
* [PATCH 08/11] blacklight: Remove redundant spi driver bus initialization
2011-11-24 15:29 [PATCH 01/11] RTC: Remove redundant spi driver bus initialization Lars-Peter Clausen
` (5 preceding siblings ...)
2011-11-24 15:29 ` [PATCH 07/11] mmc: " Lars-Peter Clausen
@ 2011-11-24 15:29 ` Lars-Peter Clausen
2011-11-24 15:29 ` [PATCH 09/11] video: " Lars-Peter Clausen
` (2 subsequent siblings)
9 siblings, 0 replies; 23+ messages in thread
From: Lars-Peter Clausen @ 2011-11-24 15:29 UTC (permalink / raw)
To: linux-kernel; +Cc: Lars-Peter Clausen, Richard Purdie, Andrew Morton
In ancient times it was necessary to manually initialize the bus field of an
spi_driver to spi_bus_type. These days this is done in spi_driver_register(),
so we can drop the manual assignment.
The patch was generated using the following coccinelle semantic patch:
// <smpl>
@@
identifier _driver;
@@
struct spi_driver _driver = {
.driver = {
- .bus = &spi_bus_type,
},
};
// </smpl>
Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>
Cc: Richard Purdie <rpurdie@rpsys.net>
Cc: Andrew Morton <akpm@linux-foundation.org>
---
drivers/video/backlight/ams369fg06.c | 1 -
drivers/video/backlight/ld9040.c | 1 -
drivers/video/backlight/ltv350qv.c | 1 -
drivers/video/backlight/s6e63m0.c | 1 -
4 files changed, 0 insertions(+), 4 deletions(-)
diff --git a/drivers/video/backlight/ams369fg06.c b/drivers/video/backlight/ams369fg06.c
index 7838a23..901024b 100644
--- a/drivers/video/backlight/ams369fg06.c
+++ b/drivers/video/backlight/ams369fg06.c
@@ -619,7 +619,6 @@ static void ams369fg06_shutdown(struct spi_device *spi)
static struct spi_driver ams369fg06_driver = {
.driver = {
.name = "ams369fg06",
- .bus = &spi_bus_type,
.owner = THIS_MODULE,
},
.probe = ams369fg06_probe,
diff --git a/drivers/video/backlight/ld9040.c b/drivers/video/backlight/ld9040.c
index da9a5ce..158ba52 100644
--- a/drivers/video/backlight/ld9040.c
+++ b/drivers/video/backlight/ld9040.c
@@ -799,7 +799,6 @@ static void ld9040_shutdown(struct spi_device *spi)
static struct spi_driver ld9040_driver = {
.driver = {
.name = "ld9040",
- .bus = &spi_bus_type,
.owner = THIS_MODULE,
},
.probe = ld9040_probe,
diff --git a/drivers/video/backlight/ltv350qv.c b/drivers/video/backlight/ltv350qv.c
index cca43c0..707e66f 100644
--- a/drivers/video/backlight/ltv350qv.c
+++ b/drivers/video/backlight/ltv350qv.c
@@ -310,7 +310,6 @@ static void ltv350qv_shutdown(struct spi_device *spi)
static struct spi_driver ltv350qv_driver = {
.driver = {
.name = "ltv350qv",
- .bus = &spi_bus_type,
.owner = THIS_MODULE,
},
diff --git a/drivers/video/backlight/s6e63m0.c b/drivers/video/backlight/s6e63m0.c
index e132157..6fb9187 100644
--- a/drivers/video/backlight/s6e63m0.c
+++ b/drivers/video/backlight/s6e63m0.c
@@ -899,7 +899,6 @@ static void s6e63m0_shutdown(struct spi_device *spi)
static struct spi_driver s6e63m0_driver = {
.driver = {
.name = "s6e63m0",
- .bus = &spi_bus_type,
.owner = THIS_MODULE,
},
.probe = s6e63m0_probe,
--
1.7.7.1
^ permalink raw reply related [flat|nested] 23+ messages in thread* [PATCH 09/11] video: Remove redundant spi driver bus initialization
2011-11-24 15:29 [PATCH 01/11] RTC: Remove redundant spi driver bus initialization Lars-Peter Clausen
` (6 preceding siblings ...)
2011-11-24 15:29 ` [PATCH 08/11] blacklight: " Lars-Peter Clausen
@ 2011-11-24 15:29 ` Lars-Peter Clausen
2011-11-29 10:19 ` Tomi Valkeinen
2011-12-04 0:36 ` Florian Tobias Schandinat
2011-11-24 15:29 ` [PATCH 10/11] wireless: " Lars-Peter Clausen
2011-11-24 15:29 ` [PATCH 11/11] can: " Lars-Peter Clausen
9 siblings, 2 replies; 23+ messages in thread
From: Lars-Peter Clausen @ 2011-11-24 15:29 UTC (permalink / raw)
To: linux-kernel
Cc: Lars-Peter Clausen, Tomi Valkeinen, Florian Tobias Schandinat,
linux-fbdev, linux-omap
In ancient times it was necessary to manually initialize the bus field of an
spi_driver to spi_bus_type. These days this is done in spi_driver_register(),
so we can drop the manual assignment.
The patch was generated using the following coccinelle semantic patch:
// <smpl>
@@
identifier _driver;
@@
struct spi_driver _driver = {
.driver = {
- .bus = &spi_bus_type,
},
};
// </smpl>
Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>
Cc: Tomi Valkeinen <tomi.valkeinen@ti.com>
Cc: Florian Tobias Schandinat <FlorianSchandinat@gmx.de>
Cc: linux-fbdev@vger.kernel.org
Cc: linux-omap@vger.kernel.org
---
drivers/video/omap/lcd_mipid.c | 1 -
drivers/video/omap2/displays/panel-acx565akm.c | 1 -
drivers/video/omap2/displays/panel-n8x0.c | 1 -
.../omap2/displays/panel-nec-nl8048hl11-01b.c | 1 -
.../video/omap2/displays/panel-tpo-td043mtea1.c | 1 -
5 files changed, 0 insertions(+), 5 deletions(-)
diff --git a/drivers/video/omap/lcd_mipid.c b/drivers/video/omap/lcd_mipid.c
index eb381db..8d546dd 100644
--- a/drivers/video/omap/lcd_mipid.c
+++ b/drivers/video/omap/lcd_mipid.c
@@ -603,7 +603,6 @@ static int mipid_spi_remove(struct spi_device *spi)
static struct spi_driver mipid_spi_driver = {
.driver = {
.name = MIPID_MODULE_NAME,
- .bus = &spi_bus_type,
.owner = THIS_MODULE,
},
.probe = mipid_spi_probe,
diff --git a/drivers/video/omap2/displays/panel-acx565akm.c b/drivers/video/omap2/displays/panel-acx565akm.c
index dbd59b8..51a87e1 100644
--- a/drivers/video/omap2/displays/panel-acx565akm.c
+++ b/drivers/video/omap2/displays/panel-acx565akm.c
@@ -803,7 +803,6 @@ static int acx565akm_spi_remove(struct spi_device *spi)
static struct spi_driver acx565akm_spi_driver = {
.driver = {
.name = "acx565akm",
- .bus = &spi_bus_type,
.owner = THIS_MODULE,
},
.probe = acx565akm_spi_probe,
diff --git a/drivers/video/omap2/displays/panel-n8x0.c b/drivers/video/omap2/displays/panel-n8x0.c
index 150e8ba..dc9408d 100644
--- a/drivers/video/omap2/displays/panel-n8x0.c
+++ b/drivers/video/omap2/displays/panel-n8x0.c
@@ -708,7 +708,6 @@ static int mipid_spi_remove(struct spi_device *spi)
static struct spi_driver mipid_spi_driver = {
.driver = {
.name = "lcd_mipid",
- .bus = &spi_bus_type,
.owner = THIS_MODULE,
},
.probe = mipid_spi_probe,
diff --git a/drivers/video/omap2/displays/panel-nec-nl8048hl11-01b.c b/drivers/video/omap2/displays/panel-nec-nl8048hl11-01b.c
index 2ba9d0c..8365e77 100644
--- a/drivers/video/omap2/displays/panel-nec-nl8048hl11-01b.c
+++ b/drivers/video/omap2/displays/panel-nec-nl8048hl11-01b.c
@@ -303,7 +303,6 @@ static struct spi_driver nec_8048_spi_driver = {
.resume = nec_8048_spi_resume,
.driver = {
.name = "nec_8048_spi",
- .bus = &spi_bus_type,
.owner = THIS_MODULE,
},
};
diff --git a/drivers/video/omap2/displays/panel-tpo-td043mtea1.c b/drivers/video/omap2/displays/panel-tpo-td043mtea1.c
index 2462b9e..e6649aa 100644
--- a/drivers/video/omap2/displays/panel-tpo-td043mtea1.c
+++ b/drivers/video/omap2/displays/panel-tpo-td043mtea1.c
@@ -512,7 +512,6 @@ static int __devexit tpo_td043_spi_remove(struct spi_device *spi)
static struct spi_driver tpo_td043_spi_driver = {
.driver = {
.name = "tpo_td043mtea1_panel_spi",
- .bus = &spi_bus_type,
.owner = THIS_MODULE,
},
.probe = tpo_td043_spi_probe,
--
1.7.7.1
^ permalink raw reply related [flat|nested] 23+ messages in thread* Re: [PATCH 09/11] video: Remove redundant spi driver bus initialization
2011-11-24 15:29 ` [PATCH 09/11] video: " Lars-Peter Clausen
@ 2011-11-29 10:19 ` Tomi Valkeinen
2011-12-04 0:36 ` Florian Tobias Schandinat
1 sibling, 0 replies; 23+ messages in thread
From: Tomi Valkeinen @ 2011-11-29 10:19 UTC (permalink / raw)
To: Lars-Peter Clausen
Cc: linux-kernel, Florian Tobias Schandinat, linux-fbdev, linux-omap
[-- Attachment #1: Type: text/plain, Size: 791 bytes --]
On Thu, 2011-11-24 at 16:29 +0100, Lars-Peter Clausen wrote:
> In ancient times it was necessary to manually initialize the bus field of an
> spi_driver to spi_bus_type. These days this is done in spi_driver_register(),
> so we can drop the manual assignment.
>
> The patch was generated using the following coccinelle semantic patch:
> // <smpl>
> @@
> identifier _driver;
> @@
> struct spi_driver _driver = {
> .driver = {
> - .bus = &spi_bus_type,
> },
> };
> // </smpl>
>
> Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>
> Cc: Tomi Valkeinen <tomi.valkeinen@ti.com>
> Cc: Florian Tobias Schandinat <FlorianSchandinat@gmx.de>
> Cc: linux-fbdev@vger.kernel.org
> Cc: linux-omap@vger.kernel.org
Acked-by: Tomi Valkeinen <tomi.valkeinen@ti.com>
Tomi
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 23+ messages in thread* Re: [PATCH 09/11] video: Remove redundant spi driver bus initialization
2011-11-24 15:29 ` [PATCH 09/11] video: " Lars-Peter Clausen
2011-11-29 10:19 ` Tomi Valkeinen
@ 2011-12-04 0:36 ` Florian Tobias Schandinat
1 sibling, 0 replies; 23+ messages in thread
From: Florian Tobias Schandinat @ 2011-12-04 0:36 UTC (permalink / raw)
To: Lars-Peter Clausen; +Cc: linux-kernel, Tomi Valkeinen, linux-fbdev, linux-omap
On 11/24/2011 03:29 PM, Lars-Peter Clausen wrote:
> In ancient times it was necessary to manually initialize the bus field of an
> spi_driver to spi_bus_type. These days this is done in spi_driver_register(),
> so we can drop the manual assignment.
>
> The patch was generated using the following coccinelle semantic patch:
> // <smpl>
> @@
> identifier _driver;
> @@
> struct spi_driver _driver = {
> .driver = {
> - .bus = &spi_bus_type,
> },
> };
> // </smpl>
>
> Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>
> Cc: Tomi Valkeinen <tomi.valkeinen@ti.com>
> Cc: Florian Tobias Schandinat <FlorianSchandinat@gmx.de>
> Cc: linux-fbdev@vger.kernel.org
> Cc: linux-omap@vger.kernel.org
Applied this patch.
Thanks,
Florian Tobias Schandinat
> ---
> drivers/video/omap/lcd_mipid.c | 1 -
> drivers/video/omap2/displays/panel-acx565akm.c | 1 -
> drivers/video/omap2/displays/panel-n8x0.c | 1 -
> .../omap2/displays/panel-nec-nl8048hl11-01b.c | 1 -
> .../video/omap2/displays/panel-tpo-td043mtea1.c | 1 -
> 5 files changed, 0 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/video/omap/lcd_mipid.c b/drivers/video/omap/lcd_mipid.c
> index eb381db..8d546dd 100644
> --- a/drivers/video/omap/lcd_mipid.c
> +++ b/drivers/video/omap/lcd_mipid.c
> @@ -603,7 +603,6 @@ static int mipid_spi_remove(struct spi_device *spi)
> static struct spi_driver mipid_spi_driver = {
> .driver = {
> .name = MIPID_MODULE_NAME,
> - .bus = &spi_bus_type,
> .owner = THIS_MODULE,
> },
> .probe = mipid_spi_probe,
> diff --git a/drivers/video/omap2/displays/panel-acx565akm.c b/drivers/video/omap2/displays/panel-acx565akm.c
> index dbd59b8..51a87e1 100644
> --- a/drivers/video/omap2/displays/panel-acx565akm.c
> +++ b/drivers/video/omap2/displays/panel-acx565akm.c
> @@ -803,7 +803,6 @@ static int acx565akm_spi_remove(struct spi_device *spi)
> static struct spi_driver acx565akm_spi_driver = {
> .driver = {
> .name = "acx565akm",
> - .bus = &spi_bus_type,
> .owner = THIS_MODULE,
> },
> .probe = acx565akm_spi_probe,
> diff --git a/drivers/video/omap2/displays/panel-n8x0.c b/drivers/video/omap2/displays/panel-n8x0.c
> index 150e8ba..dc9408d 100644
> --- a/drivers/video/omap2/displays/panel-n8x0.c
> +++ b/drivers/video/omap2/displays/panel-n8x0.c
> @@ -708,7 +708,6 @@ static int mipid_spi_remove(struct spi_device *spi)
> static struct spi_driver mipid_spi_driver = {
> .driver = {
> .name = "lcd_mipid",
> - .bus = &spi_bus_type,
> .owner = THIS_MODULE,
> },
> .probe = mipid_spi_probe,
> diff --git a/drivers/video/omap2/displays/panel-nec-nl8048hl11-01b.c b/drivers/video/omap2/displays/panel-nec-nl8048hl11-01b.c
> index 2ba9d0c..8365e77 100644
> --- a/drivers/video/omap2/displays/panel-nec-nl8048hl11-01b.c
> +++ b/drivers/video/omap2/displays/panel-nec-nl8048hl11-01b.c
> @@ -303,7 +303,6 @@ static struct spi_driver nec_8048_spi_driver = {
> .resume = nec_8048_spi_resume,
> .driver = {
> .name = "nec_8048_spi",
> - .bus = &spi_bus_type,
> .owner = THIS_MODULE,
> },
> };
> diff --git a/drivers/video/omap2/displays/panel-tpo-td043mtea1.c b/drivers/video/omap2/displays/panel-tpo-td043mtea1.c
> index 2462b9e..e6649aa 100644
> --- a/drivers/video/omap2/displays/panel-tpo-td043mtea1.c
> +++ b/drivers/video/omap2/displays/panel-tpo-td043mtea1.c
> @@ -512,7 +512,6 @@ static int __devexit tpo_td043_spi_remove(struct spi_device *spi)
> static struct spi_driver tpo_td043_spi_driver = {
> .driver = {
> .name = "tpo_td043mtea1_panel_spi",
> - .bus = &spi_bus_type,
> .owner = THIS_MODULE,
> },
> .probe = tpo_td043_spi_probe,
^ permalink raw reply [flat|nested] 23+ messages in thread
* [PATCH 10/11] wireless: Remove redundant spi driver bus initialization
2011-11-24 15:29 [PATCH 01/11] RTC: Remove redundant spi driver bus initialization Lars-Peter Clausen
` (7 preceding siblings ...)
2011-11-24 15:29 ` [PATCH 09/11] video: " Lars-Peter Clausen
@ 2011-11-24 15:29 ` Lars-Peter Clausen
2011-11-28 7:20 ` Luciano Coelho
2011-11-24 15:29 ` [PATCH 11/11] can: " Lars-Peter Clausen
9 siblings, 1 reply; 23+ messages in thread
From: Lars-Peter Clausen @ 2011-11-24 15:29 UTC (permalink / raw)
To: linux-kernel
Cc: Lars-Peter Clausen, Dan Williams, John W. Linville,
Christian Lamparter, Luciano Coelho, libertas-dev, linux-wireless
In ancient times it was necessary to manually initialize the bus field of an
spi_driver to spi_bus_type. These days this is done in spi_driver_register(),
so we can drop the manual assignment.
The patch was generated using the following coccinelle semantic patch:
// <smpl>
@@
identifier _driver;
@@
struct spi_driver _driver = {
.driver = {
- .bus = &spi_bus_type,
},
};
// </smpl>
Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>
Cc: Dan Williams <dcbw@redhat.com>
Cc: "John W. Linville" <linville@tuxdriver.com>
Cc: Christian Lamparter <chunkeey@googlemail.com>
Cc: Luciano Coelho <coelho@ti.com>
Cc: libertas-dev@lists.infradead.org
Cc: linux-wireless@vger.kernel.org
---
drivers/net/wireless/libertas/if_spi.c | 1 -
drivers/net/wireless/p54/p54spi.c | 1 -
drivers/net/wireless/wl1251/spi.c | 1 -
drivers/net/wireless/wl12xx/spi.c | 1 -
4 files changed, 0 insertions(+), 4 deletions(-)
diff --git a/drivers/net/wireless/libertas/if_spi.c b/drivers/net/wireless/libertas/if_spi.c
index 728baa4..50b1ee7 100644
--- a/drivers/net/wireless/libertas/if_spi.c
+++ b/drivers/net/wireless/libertas/if_spi.c
@@ -1291,7 +1291,6 @@ static struct spi_driver libertas_spi_driver = {
.remove = __devexit_p(libertas_spi_remove),
.driver = {
.name = "libertas_spi",
- .bus = &spi_bus_type,
.owner = THIS_MODULE,
.pm = &if_spi_pm_ops,
},
diff --git a/drivers/net/wireless/p54/p54spi.c b/drivers/net/wireless/p54/p54spi.c
index 2d5cf5b..7faed62 100644
--- a/drivers/net/wireless/p54/p54spi.c
+++ b/drivers/net/wireless/p54/p54spi.c
@@ -700,7 +700,6 @@ static int __devexit p54spi_remove(struct spi_device *spi)
static struct spi_driver p54spi_driver = {
.driver = {
.name = "p54spi",
- .bus = &spi_bus_type,
.owner = THIS_MODULE,
},
diff --git a/drivers/net/wireless/wl1251/spi.c b/drivers/net/wireless/wl1251/spi.c
index eaa5f95..6248c35 100644
--- a/drivers/net/wireless/wl1251/spi.c
+++ b/drivers/net/wireless/wl1251/spi.c
@@ -319,7 +319,6 @@ static int __devexit wl1251_spi_remove(struct spi_device *spi)
static struct spi_driver wl1251_spi_driver = {
.driver = {
.name = DRIVER_NAME,
- .bus = &spi_bus_type,
.owner = THIS_MODULE,
},
diff --git a/drivers/net/wireless/wl12xx/spi.c b/drivers/net/wireless/wl12xx/spi.c
index 0f97186..12421a6 100644
--- a/drivers/net/wireless/wl12xx/spi.c
+++ b/drivers/net/wireless/wl12xx/spi.c
@@ -462,7 +462,6 @@ static int __devexit wl1271_remove(struct spi_device *spi)
static struct spi_driver wl1271_spi_driver = {
.driver = {
.name = "wl1271_spi",
- .bus = &spi_bus_type,
.owner = THIS_MODULE,
},
--
1.7.7.1
^ permalink raw reply related [flat|nested] 23+ messages in thread* Re: [PATCH 10/11] wireless: Remove redundant spi driver bus initialization
2011-11-24 15:29 ` [PATCH 10/11] wireless: " Lars-Peter Clausen
@ 2011-11-28 7:20 ` Luciano Coelho
0 siblings, 0 replies; 23+ messages in thread
From: Luciano Coelho @ 2011-11-28 7:20 UTC (permalink / raw)
To: Lars-Peter Clausen
Cc: linux-kernel, Dan Williams, John W. Linville, Christian Lamparter,
libertas-dev, linux-wireless
On Thu, 2011-11-24 at 16:29 +0100, Lars-Peter Clausen wrote:
> In ancient times it was necessary to manually initialize the bus field of an
> spi_driver to spi_bus_type. These days this is done in spi_driver_register(),
> so we can drop the manual assignment.
>
> The patch was generated using the following coccinelle semantic patch:
> // <smpl>
> @@
> identifier _driver;
> @@
> struct spi_driver _driver = {
> .driver = {
> - .bus = &spi_bus_type,
> },
> };
> // </smpl>
>
> Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>
> Cc: Dan Williams <dcbw@redhat.com>
> Cc: "John W. Linville" <linville@tuxdriver.com>
> Cc: Christian Lamparter <chunkeey@googlemail.com>
> Cc: Luciano Coelho <coelho@ti.com>
> Cc: libertas-dev@lists.infradead.org
> Cc: linux-wireless@vger.kernel.org
> ---
[...]
> diff --git a/drivers/net/wireless/wl1251/spi.c b/drivers/net/wireless/wl1251/spi.c
> index eaa5f95..6248c35 100644
> --- a/drivers/net/wireless/wl1251/spi.c
> +++ b/drivers/net/wireless/wl1251/spi.c
> @@ -319,7 +319,6 @@ static int __devexit wl1251_spi_remove(struct spi_device *spi)
> static struct spi_driver wl1251_spi_driver = {
> .driver = {
> .name = DRIVER_NAME,
> - .bus = &spi_bus_type,
> .owner = THIS_MODULE,
> },
>
> diff --git a/drivers/net/wireless/wl12xx/spi.c b/drivers/net/wireless/wl12xx/spi.c
> index 0f97186..12421a6 100644
> --- a/drivers/net/wireless/wl12xx/spi.c
> +++ b/drivers/net/wireless/wl12xx/spi.c
> @@ -462,7 +462,6 @@ static int __devexit wl1271_remove(struct spi_device *spi)
> static struct spi_driver wl1271_spi_driver = {
> .driver = {
> .name = "wl1271_spi",
> - .bus = &spi_bus_type,
> .owner = THIS_MODULE,
> },
For the wl12xx and wl1251 parts:
Acked-by: Luciano Coelho <coelho@ti.com>
--
Cheers,
Luca.
^ permalink raw reply [flat|nested] 23+ messages in thread
* [PATCH 11/11] can: Remove redundant spi driver bus initialization
2011-11-24 15:29 [PATCH 01/11] RTC: Remove redundant spi driver bus initialization Lars-Peter Clausen
` (8 preceding siblings ...)
2011-11-24 15:29 ` [PATCH 10/11] wireless: " Lars-Peter Clausen
@ 2011-11-24 15:29 ` Lars-Peter Clausen
2011-11-24 15:36 ` Marc Kleine-Budde
9 siblings, 1 reply; 23+ messages in thread
From: Lars-Peter Clausen @ 2011-11-24 15:29 UTC (permalink / raw)
To: linux-kernel; +Cc: Lars-Peter Clausen, Wolfgang Grandegger, linux-can
In ancient times it was necessary to manually initialize the bus field of an
spi_driver to spi_bus_type. These days this is done in spi_driver_register(),
so we can drop the manual assignment.
The patch was generated using the following coccinelle semantic patch:
// <smpl>
@@
identifier _driver;
@@
struct spi_driver _driver = {
.driver = {
- .bus = &spi_bus_type,
},
};
// </smpl>
Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>
Cc: Wolfgang Grandegger <wg@grandegger.com>
Cc: linux-can@vger.kernel.org
---
drivers/net/can/mcp251x.c | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/drivers/net/can/mcp251x.c b/drivers/net/can/mcp251x.c
index 330140e..5e10da5 100644
--- a/drivers/net/can/mcp251x.c
+++ b/drivers/net/can/mcp251x.c
@@ -1185,7 +1185,6 @@ MODULE_DEVICE_TABLE(spi, mcp251x_id_table);
static struct spi_driver mcp251x_can_driver = {
.driver = {
.name = DEVICE_NAME,
- .bus = &spi_bus_type,
.owner = THIS_MODULE,
},
--
1.7.7.1
^ permalink raw reply related [flat|nested] 23+ messages in thread* Re: [PATCH 11/11] can: Remove redundant spi driver bus initialization
2011-11-24 15:29 ` [PATCH 11/11] can: " Lars-Peter Clausen
@ 2011-11-24 15:36 ` Marc Kleine-Budde
0 siblings, 0 replies; 23+ messages in thread
From: Marc Kleine-Budde @ 2011-11-24 15:36 UTC (permalink / raw)
To: Lars-Peter Clausen; +Cc: linux-kernel, Wolfgang Grandegger, linux-can
[-- Attachment #1: Type: text/plain, Size: 1463 bytes --]
On 11/24/2011 04:29 PM, Lars-Peter Clausen wrote:
> In ancient times it was necessary to manually initialize the bus field of an
> spi_driver to spi_bus_type. These days this is done in spi_driver_register(),
> so we can drop the manual assignment.
>
> The patch was generated using the following coccinelle semantic patch:
> // <smpl>
> @@
> identifier _driver;
> @@
> struct spi_driver _driver = {
> .driver = {
> - .bus = &spi_bus_type,
> },
> };
> // </smpl>
>
> Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>
> Cc: Wolfgang Grandegger <wg@grandegger.com>
> Cc: linux-can@vger.kernel.org
Acked-by: Marc Kleine-Budde <mkl@pengutronix.de>
> ---
> drivers/net/can/mcp251x.c | 1 -
> 1 files changed, 0 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/net/can/mcp251x.c b/drivers/net/can/mcp251x.c
> index 330140e..5e10da5 100644
> --- a/drivers/net/can/mcp251x.c
> +++ b/drivers/net/can/mcp251x.c
> @@ -1185,7 +1185,6 @@ MODULE_DEVICE_TABLE(spi, mcp251x_id_table);
> static struct spi_driver mcp251x_can_driver = {
> .driver = {
> .name = DEVICE_NAME,
> - .bus = &spi_bus_type,
> .owner = THIS_MODULE,
> },
>
--
Pengutronix e.K. | Marc Kleine-Budde |
Industrial Linux Solutions | Phone: +49-231-2826-924 |
Vertretung West/Dortmund | Fax: +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de |
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 262 bytes --]
^ permalink raw reply [flat|nested] 23+ messages in thread