Re: [PATCH]: Added comments in fat.h

[Randy Dunlap <rdunlap@xenotime.net>]

On 11/24/2011 04:46 AM, Rahul Bedarkar wrote:
> Hi,
> 
>     Added comments in fat.h
> 
>     signed off by <rpal143@gmail.com>

Improper format for Signed-off-by: line.
See Documentation/SubmittingPatches, please.

and please Cc: the FAT fs maintainer.

> 
> [master b5334fc] Added comments in fat.h
>  1 files changed, 2 insertions(+), 1 deletions(-)
> 
> 
> diff --git a/fs/fat/fat.h b/fs/fat/fat.h
> index 1510a4d..3b64fe0 100644
> --- a/fs/fat/fat.h
> +++ b/fs/fat/fat.h
> @@ -75,7 +75,7 @@ struct msdos_sb_info {
>         struct fat_mount_options options;
>         struct nls_table *nls_disk;  /* Codepage used on disk */
>         struct nls_table *nls_io;    /* Charset used for input and display */
> -       const void *dir_ops;                 /* Opaque; default
> directory operations */

Your email client incorrectly split the above source line into 2 lines.
Maybe Documentation/email-clients.txt can help you.

> +       const void *dir_ops;         /* Opaque; default directory operations */
>         int dir_per_block;           /* dir entries per block */
>         int dir_per_block_bits;      /* log2(dir_per_block) */
> 
> @@ -179,6 +179,7 @@ static inline u8 fat_make_attrs(struct inode *inode)
>         return attrs;
>  }
> 
> +/* Sets the FAT attribute byte for thid inode */

thid should be third?  or this?

>  static inline void fat_save_attrs(struct inode *inode, u8 attrs)
>  {
>         if (fat_mode_can_hold_ro(inode))


-- 
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***