Re: [PATCH] kexec: do not call kmsg_dump in crashdump

Eric W. Biederman
2011-11-28T22:25:50Z

Dave Young <dyoung@redhat.com> writes:

> mtd/ram oops dumper will make more functions envolved. In case crash kexec,
> we should avoid kmsg dumper to ensure crashdump success.
>
> kill kmsg_dump callback while crash dumping

Agreed.

There is a similar? Or possibly the same patch already queued in
Andrews tree.

Eric

>
> Signed-off-by: Dave Young <dyoung@redhat.com>
> ---
> kernel/kexec.c | 2 --
> 1 file changed, 2 deletions(-)
>
> --- linux-2.6.orig/kernel/kexec.c 2011-11-18 16:34:18.000000000 +0800
> +++ linux-2.6/kernel/kexec.c 2011-11-24 16:05:08.138660500 +0800
> @@ -1094,8 +1094,6 @@ void crash_kexec(struct pt_regs *regs)
> if (kexec_crash_image) {
> struct pt_regs fixed_regs;
>
> - kmsg_dump(KMSG_DUMP_KEXEC);
> -
> crash_setup_regs(&fixed_regs, regs);
> crash_save_vmcoreinfo();
> machine_crash_shutdown(&fixed_regs);