Re: [PATCH] kexec: do not call kmsg_dump in crashdump

Dave Young
2011-11-25T10:01:49Z

On 11/25/2011 05:32 PM, Cong Wang wrote:

> On Fri, Nov 25, 2011 at 4:19 PM, Dave Young <dyoung@redhat.com> wrote:
>> mtd/ram oops dumper will make more functions envolved. In case crash kexec,
>> we should avoid kmsg dumper to ensure crashdump success.
>>
>> kill kmsg_dump callback while crash dumping
>
> https://lkml.org/lkml/2011/2/1/33

Thanks for give the link. So it's intend to be that.

I'm still confused with the KMSG_DUMP_KEXEC.

crash_kexec()
kmsg_dump(KMSG_DUMP_KEXEC)
kmsg_dump(KMSG_DUMP_PANIC)

Looks like it's equal to original logic, isn't it?

kmsg_dump(anything);
crash_kexec()

So why intruduce KMSG_DUMP_KEXEC? why not just kmsg_dump before crash_kexec?

thoughts?

--
Thanks
Dave