Re: [RFC PATCH 2/7] include/linux: add headers for drivers/zio

Greg KH
2011-11-30T06:21:26Z

On Mon, Nov 28, 2011 at 03:56:45PM +0100, Federico Vaga wrote:
> I don't reply to each point because I suppose the point is: "kobject
> or device for sysfs?", maybe I misunderstood.

That is correct.

> I know that it is not a good thing reply with a new question, but I
> think it can clarify the problem.
>
> Why device is it preferred to export some sysfs attributes when sysfs
> ask me kobject?

If your code is working properly, you don't have to ever make sysfs
calls, only driver core calls, for sysfs files. There might be a few
minor exceptions, but I think the coverage is all there now.

> As I tested both device and kobject, I'll do a parallel implementation
> with device.

As you are using a tree of devices, please use struct device, I can't
accept the code otherwise.

greg k-h