From: Lars-Peter Clausen <lars@metafoo.de>
To: Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: Liam Girdwood <lrg@ti.com>,
linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org,
drivers@analog.com, device-drivers-devel@blackfin.uclinux.org
Subject: Re: [PATCH 3/7] ASoC: AD193X: Make enum items const char * const
Date: Mon, 28 Nov 2011 20:01:38 +0100 [thread overview]
Message-ID: <4ED3DA92.6050704@metafoo.de> (raw)
In-Reply-To: <20111128185345.GA1586@opensource.wolfsonmicro.com>
On 11/28/2011 07:53 PM, Mark Brown wrote:
> On Mon, Nov 28, 2011 at 05:28:08PM +0100, Lars-Peter Clausen wrote:
>
>> -static const char *ad193x_deemp[] = {"None", "48kHz", "44.1kHz", "32kHz"};
>> +static const char * const ad193x_deemp[] = {"None", "48kHz", "44.1kHz", "32kHz"};
>
> Ideally this would be converted to a switch and the driver would
> automatically select the rate based on the current sample rate.
Ideally yes, but I'm not sure if this couldn't break some existing setup if it
expects to find that control.
- Lars
next prev parent reply other threads:[~2011-11-28 19:02 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-28 16:28 [PATCH 1/7] ASoC: ad193X: Use table based DAPM and controls setup Lars-Peter Clausen
2011-11-28 16:28 ` [PATCH 2/7] ASoC: ad193X: Provide dB ranges for the volume controls Lars-Peter Clausen
2011-11-28 16:28 ` [PATCH 3/7] ASoC: AD193X: Make enum items const char * const Lars-Peter Clausen
2011-11-28 18:53 ` Mark Brown
2011-11-28 19:01 ` Lars-Peter Clausen [this message]
2011-11-28 19:03 ` Mark Brown
2011-11-28 16:28 ` [PATCH 4/7] ASoC: ad193X: Remove non-functional DAPM route controls Lars-Peter Clausen
2011-11-28 16:28 ` [PATCH 5/7] ASOC: AD193X: Add sysclk DAPM supply Lars-Peter Clausen
2011-11-29 5:24 ` Mike Frysinger
2011-11-29 11:34 ` Mark Brown
2011-11-30 5:42 ` Mike Frysinger
2011-11-28 16:28 ` [PATCH 6/7] ASoC: AD193X: Use snd_soc_update_bits where appropriate Lars-Peter Clausen
2011-11-28 16:28 ` [PATCH 7/7] ASoC: AD193X: Convert to direct regmap API usage Lars-Peter Clausen
2011-11-28 18:57 ` [PATCH 1/7] ASoC: ad193X: Use table based DAPM and controls setup Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4ED3DA92.6050704@metafoo.de \
--to=lars@metafoo.de \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=device-drivers-devel@blackfin.uclinux.org \
--cc=drivers@analog.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lrg@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox