From: Li Zefan <lizf@cn.fujitsu.com>
To: Andy Whitcroft <apw@canonical.com>
Cc: Jonathan Nieder <jrnieder@gmail.com>,
Chris Mason <chris.mason@oracle.com>,
Josef Bacik <josef@redhat.com>, Miao Xie <miaox@cn.fujitsu.com>,
Ivan Vilata i Balaguer <ivan@selidor.net>,
linux-btrfs@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/1] btrfs: btrfs_calc_avail_data_space cope with no read/write devices V2
Date: Tue, 29 Nov 2011 09:26:01 +0800 [thread overview]
Message-ID: <4ED434A9.8020809@cn.fujitsu.com> (raw)
In-Reply-To: <20111128122416.GA25996@localhost>
Andy Whitcroft wrote:
> On Mon, Nov 28, 2011 at 06:11:06AM -0600, Jonathan Nieder wrote:
>> Hi,
>>
>> Andy Whitcroft wrote:
>>
>>> When we mount a btrfs filesystem from read-only media there will be no
>>> read/write devices; for example mounting an SD card with its lock enabled.
>>> This triggers an immediate BUG during mount:
>>>
>>> kernel BUG at .../fs/btrfs/super.c:984!
>> [...]
>>> BugLink: http://bugs.launchpad.net/bugs/816770
>>> Signed-off-by: Andy Whitcroft <apw@canonical.com>
>>> ---
>>
>> Fixes http://bugs.debian.org/649847
>> Tested-by: Ivan Vilata i Balaguer <ivan@selidor.net>
>>
>> This patch fixes a regression introduced by 6d07bcec969a ("btrfs: fix
>> wrong free space information of btrfs"), which hit mainline in
>> v2.6.38-rc1. Josef Bacik acked the patch, but I can't seem to find it
>> in linux-next, linux-btrfs, or Josef's btrfs-work tree. Maybe it was
>> just forgotten.
>>
>> What can I do to help this patch get unstuck?
>
> I had completely forgotten about this one. I wonder where it did get
> to. I seem to remember testing this in house successfully.
>
This patch has the same problem with your previous one, that it will set
f_bavail to 0. I've sent out a new patch yesterday.
next prev parent reply other threads:[~2011-11-29 1:24 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-01 13:38 [PATCH 1/1] btrfs: btrfs_calc_avail_data_space cope with no read/write devices V2 Andy Whitcroft
2011-08-01 15:24 ` Josef Bacik
2011-11-28 12:11 ` Jonathan Nieder
2011-11-28 12:24 ` Andy Whitcroft
2011-11-29 1:26 ` Li Zefan [this message]
2011-11-29 6:01 ` Jonathan Nieder
2011-11-30 15:40 ` Andy Whitcroft
2011-11-29 1:55 ` Miao Xie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4ED434A9.8020809@cn.fujitsu.com \
--to=lizf@cn.fujitsu.com \
--cc=apw@canonical.com \
--cc=chris.mason@oracle.com \
--cc=ivan@selidor.net \
--cc=josef@redhat.com \
--cc=jrnieder@gmail.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=miaox@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox