From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753613Ab1K2BYN (ORCPT ); Mon, 28 Nov 2011 20:24:13 -0500 Received: from cn.fujitsu.com ([222.73.24.84]:63230 "EHLO song.cn.fujitsu.com" rhost-flags-OK-FAIL-OK-OK) by vger.kernel.org with ESMTP id S1751530Ab1K2BYL (ORCPT ); Mon, 28 Nov 2011 20:24:11 -0500 Message-ID: <4ED434A9.8020809@cn.fujitsu.com> Date: Tue, 29 Nov 2011 09:26:01 +0800 From: Li Zefan User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.2.9) Gecko/20100921 Fedora/3.1.4-1.fc14 Thunderbird/3.1.4 MIME-Version: 1.0 To: Andy Whitcroft CC: Jonathan Nieder , Chris Mason , Josef Bacik , Miao Xie , Ivan Vilata i Balaguer , linux-btrfs@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/1] btrfs: btrfs_calc_avail_data_space cope with no read/write devices V2 References: <1312205910-13053-1-git-send-email-apw@canonical.com> <20111128121041.GA19498@elie.hsd1.il.comcast.net> <20111128122416.GA25996@localhost> In-Reply-To: <20111128122416.GA25996@localhost> X-MIMETrack: Itemize by SMTP Server on mailserver/fnst(Release 8.5.1FP4|July 25, 2010) at 2011-11-29 09:23:43, Serialize by Router on mailserver/fnst(Release 8.5.1FP4|July 25, 2010) at 2011-11-29 09:23:45, Serialize complete at 2011-11-29 09:23:45 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Andy Whitcroft wrote: > On Mon, Nov 28, 2011 at 06:11:06AM -0600, Jonathan Nieder wrote: >> Hi, >> >> Andy Whitcroft wrote: >> >>> When we mount a btrfs filesystem from read-only media there will be no >>> read/write devices; for example mounting an SD card with its lock enabled. >>> This triggers an immediate BUG during mount: >>> >>> kernel BUG at .../fs/btrfs/super.c:984! >> [...] >>> BugLink: http://bugs.launchpad.net/bugs/816770 >>> Signed-off-by: Andy Whitcroft >>> --- >> >> Fixes http://bugs.debian.org/649847 >> Tested-by: Ivan Vilata i Balaguer >> >> This patch fixes a regression introduced by 6d07bcec969a ("btrfs: fix >> wrong free space information of btrfs"), which hit mainline in >> v2.6.38-rc1. Josef Bacik acked the patch, but I can't seem to find it >> in linux-next, linux-btrfs, or Josef's btrfs-work tree. Maybe it was >> just forgotten. >> >> What can I do to help this patch get unstuck? > > I had completely forgotten about this one. I wonder where it did get > to. I seem to remember testing this in house successfully. > This patch has the same problem with your previous one, that it will set f_bavail to 0. I've sent out a new patch yesterday.