public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Maxim Uvarov <maxim.uvarov@oracle.com>
To: linux-nfs@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, rlove@rlove.org,
	eparis@parisplace.org, john@johnmccutchan.com,
	viro@zeniv.linux.org.uk, linux-fsdevel@vger.kernel.org
Subject: nfs no inotify IN_DELETE  event
Date: Tue, 29 Nov 2011 13:13:50 -0800	[thread overview]
Message-ID: <4ED54B0E.5030403@oracle.com> (raw)

Hello,

I'm looking on inotify02 test future in mainline kernel on nfs:

inotify_init()                          = 3
inotify_add_watch(3, ".", IN_ALL_EVENTS)
creat("test_file1", 0755)               = 5
rename("test_file1", "test_file2")      = 0
getcwd("/mnt/nfs2/tmp", 256)            = 14
rename("/mnt/nfs2/tmp", "/mnt/nfs2/tmp.rename1") = 0
unlink("test_file2")                    = 0

After unlink() if file sytem is not nfs there is event:
IN_DELETE               0x00000200      /* Subfile was deleted */
for file test_file2. If file system is nfs there is no such event.

For the first time I thought that this is nfs sever bug related to nfs 
"silly renamed files" feature. But logically - file test_file2 was not 
deleted. It was removed with his directory from event watch directory to
non event watch directory.

1. is it ok that unlink() in that test returns 0, not -1 ENOENT?

2. should we get IN_DELETE for all files and sub folders for event watch 
directory? Or there should be only one event that directory was removed?

To reproduce:
http://ltp.sourceforge.net/
make
cd testcases/kernel/syscalls/inotify
export TMPDIR=/mnt/nfs/tmp/
export TDIRECTORY=/mnt/nfs/tmp/
./inotify02

Best regards,
Maxim Uvarov.

                 reply	other threads:[~2011-11-29 21:15 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4ED54B0E.5030403@oracle.com \
    --to=maxim.uvarov@oracle.com \
    --cc=eparis@parisplace.org \
    --cc=john@johnmccutchan.com \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-nfs@vger.kernel.org \
    --cc=rlove@rlove.org \
    --cc=viro@zeniv.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox