linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Paul Gortmaker <paul.gortmaker@windriver.com>
To: Al Viro <viro@zeniv.linux.org.uk>
Cc: <linux-kernel@vger.kernel.org>, <linux-security-module@vger.kernel.org>
Subject: Re: [RFC][PATCH] trimming includes from linux/security.h
Date: Wed, 30 Nov 2011 19:39:44 -0500	[thread overview]
Message-ID: <4ED6CCD0.10201@windriver.com> (raw)
In-Reply-To: <20111130222903.GX2203@ZenIV.linux.org.uk>

On 11-11-30 05:29 PM, Al Viro wrote:

[...]

> 
> 
> Frankly, I would very much prefer to reduce these 3 functions to one
> (..._mm() variant, sans the WARN_ON()) and had callers pass current->mm
> explicitly.  I.e. something like this (preserving the current behaviour):

I dropped my scattered sched.h additions, and added this in to fix
the current->mm users.

I also had to macro-ize two static inlines in security.h to avoid
needing sched.h for incomplete types on task->real_cred, but that
meant I could drop the add of linux/cred.h to linux/security.h

Found one more trivial build error in selinux/hooks.c needing shm.h
but that was it.  I've got more builds running, but I've already built
a bunch of arm, mips, powerpc, and sparc without seeing any more fallout.

http://git.kernel.org/?p=linux/kernel/git/paulg/linux.git;a=shortlog;h=refs/heads/al-security-Nov30

If you want to squash the security.h commits all into one, change
commit logs, or anything like that, by all means, go ahead.

Paul.

      reply	other threads:[~2011-12-01  0:39 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-11-30  6:50 [RFC][PATCH] trimming includes from linux/security.h Al Viro
2011-11-30  7:09 ` Tetsuo Handa
2011-11-30  7:47   ` Al Viro
2011-11-30 20:41 ` Paul Gortmaker
2011-11-30 22:29   ` Al Viro
2011-12-01  0:39     ` Paul Gortmaker [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4ED6CCD0.10201@windriver.com \
    --to=paul.gortmaker@windriver.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-security-module@vger.kernel.org \
    --cc=viro@zeniv.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).