From: Steffen Maier <maier@linux.vnet.ibm.com>
To: Stratos Psomadakis <psomas@gentoo.org>
Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org,
gregkh@suse.de, linux-scsi@vger.kernel.org,
JBottomley@parallels.com, matthew@wil.cx, Martin.vGagern@gmx.net,
kernel@gentoo.org
Subject: Re: [SCSI] NULL pointer dereference in sym53c8xx (bisected)
Date: Sat, 03 Dec 2011 22:07:53 +0100 [thread overview]
Message-ID: <4EDA8FA9.8020004@linux.vnet.ibm.com> (raw)
In-Reply-To: <4ED8EE1C.4090404@gentoo.org>
On 12/02/2011 04:26 PM, Stratos Psomadakis wrote:
> After upstream commit 4e6c82b3614a18740ef63109d58743a359266daf ([SCSI]
> fix WARNING: at drivers/scsi/scsi_lib.c:1704), which is also included in
> 3.0-stable and 3.1-stable kernels, the kernel fails to boot (NULL
> pointer dereference in sym53c8xx_slave_destroy).
>
> Bug report at the Gentoo Bugzilla (reported and bisected by Martin von
> Gagern). [1] (stack trace [2])
>
> I think that the problem is that (after commit 4e6c82b)
> __scsi_remove_device() is called if slave_alloc() in scsi_alloc_sdev()
> fails. But __scsi_remove_device() calls slave_destroy(), which (I think)
> doesn't make much sense (ie to call slave_destroy() when slave_alloc()
> fails).
>
> For sym53c8xx, this results in a NULL pointer dereference (struct
> sym_lcb pointer) in slave_destroy().
>
> [1] https://bugs.gentoo.org/show_bug.cgi?id=392567
> [2] https://392567.bugs.gentoo.org/attachment.cgi?id=294381
To me this looks like the same thing we encountered in the zfcp LLD:
http://www.spinics.net/lists/linux-scsi/msg55575.html
James explained the pairing of slave_alloc and slave_destroy even if
slave_alloc returned early in which case slave_destroy needs to cope
with that:
http://www.spinics.net/lists/linux-scsi/msg55449.html
HTH
Steffen
Linux on System z Development
IBM Deutschland Research & Development GmbH
Vorsitzender des Aufsichtsrats: Martin Jetter
Geschäftsführung: Dirk Wittkopp
Sitz der Gesellschaft: Böblingen
Registergericht: Amtsgericht Stuttgart, HRB 243294
next prev parent reply other threads:[~2011-12-03 21:08 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-02 15:26 [SCSI] NULL pointer dereference in sym53c8xx (bisected) Stratos Psomadakis
2011-12-03 21:07 ` Steffen Maier [this message]
2011-12-04 0:11 ` Stratos Psomadakis
2011-12-04 17:36 ` Stratos Psomadakis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4EDA8FA9.8020004@linux.vnet.ibm.com \
--to=maier@linux.vnet.ibm.com \
--cc=JBottomley@parallels.com \
--cc=Martin.vGagern@gmx.net \
--cc=gregkh@suse.de \
--cc=kernel@gentoo.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=matthew@wil.cx \
--cc=psomas@gentoo.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox