public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Clemens Ladisch <clemens@ladisch.de>
To: Jeroen Van den Keybus <jeroen.vandenkeybus@gmail.com>
Cc: "Huang, Shane" <Shane.Huang@amd.com>,
	Borislav Petkov <bp@amd64.org>,
	"Nguyen, Dong" <Dong.Nguyen@amd.com>,
	linux-kernel@vger.kernel.org
Subject: Re: Unhandled IRQs on AMD E-450
Date: Sun, 04 Dec 2011 13:48:16 +0100	[thread overview]
Message-ID: <4EDB6C10.10102@ladisch.de> (raw)
In-Reply-To: <CAPRPZsAL=xUCjTKaSgq117zppvZS0S7fHB0Ebk-JqXvV1vTPCQ@mail.gmail.com>

Jeroen Van den Keybus wrote:
> [...]
> But to no avail. Both IRQ19 and IRQ16 keep becoming lost after a while.

You previously said that unloading e1000 made things better.  Did this
affect both IRQs 16 and 19?

Can you check if this problem (on either 16 or 19) happens when you are
not using the e1000 port (i.e., unplugged)?

> I'm adding a full /proc/interrupts and lspci -vv output at the bottom,
> all from the 3.0.0 Ubuntu kernel. Feel free to mention any bad guys
> you recognize in this log.

The /proc/interrupts doesn't show e1000, but lspci does.  ...?

Does the problem occur without fglrx?

To get the AHCI interrupt away from IRQ 19, try the patch below.
(But please don't show that ugly hack to any AMD guy. :)

> Is there any way of obtaining more output such as IO-APIC register
> states to verify that it is indeed a stuck IRQ input line and not an
> unsuccesful EOI ack ?

In theory, lspci's "Status: ... INTx+" shows an active interrupt line.


Regards,
Clemens


--- a/drivers/pci/quirks.c
+++ b/drivers/pci/quirks.c
@@ -2906,6 +2906,48 @@ DECLARE_PCI_FIXUP_HEADER(PCI_VENDOR_ID_INTEL, 0x65f8, quirk_intel_mc_errata);
 DECLARE_PCI_FIXUP_HEADER(PCI_VENDOR_ID_INTEL, 0x65f9, quirk_intel_mc_errata);
 DECLARE_PCI_FIXUP_HEADER(PCI_VENDOR_ID_INTEL, 0x65fa, quirk_intel_mc_errata);

+#if defined(CONFIG_PCI_MSI) && \
+	(defined(CONFIG_SATA_AHCI) || defined(CONFIG_SATA_AHCI_MODULE))
+static void __init sb7x0_ahci_msi_enable(struct pci_dev *dev)
+{
+	u8 rev, ptr;
+	int where;
+	u32 misc_control;
+
+	pci_bus_read_config_byte(dev->bus, PCI_DEVFN(0x14, 0),
+				 PCI_REVISION_ID, &rev);
+	if (rev < 0x3c) /* A14 */
+		return;
+
+	pci_read_config_byte(dev, 0x34, &ptr);
+	if (ptr == 0x70) {
+		where = 0x34;
+	} else {
+		pci_read_config_byte(dev, 0x61, &ptr);
+		if (ptr == 0x70)
+			where = 0x61;
+		else
+			return;
+	}
+
+	pci_read_config_byte(dev, 0x51, &ptr);
+	if (ptr != 0x70)
+		return;
+
+	pci_read_config_dword(dev, 0x40, &misc_control);
+	misc_control |= 1;
+	pci_write_config_dword(dev, 0x40, misc_control);
+
+	pci_write_config_byte(dev, where, 0x50);
+
+	misc_control &= ~1;
+	pci_write_config_dword(dev, 0x40, misc_control);
+
+	dev_dbg(&dev->dev, "AHCI: enabled MSI\n");
+}
+DECLARE_PCI_FIXUP_HEADER(PCI_VENDOR_ID_ATI, 0x4391, sb7x0_ahci_msi_enable);
+#endif
+
 static void pci_do_fixups(struct pci_dev *dev, struct pci_fixup *f,
 			  struct pci_fixup *end)
 {

  reply	other threads:[~2011-12-04 12:48 UTC|newest]

Thread overview: 40+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-11-29 21:44 Unhandled IRQs on AMD E-450 Jeroen Van den Keybus
2011-11-30  8:30 ` Clemens Ladisch
2011-11-30 15:44 ` Borislav Petkov
2011-12-01  8:01   ` Huang, Shane
2011-12-03 20:36     ` Jeroen Van den Keybus
2011-12-04 12:48       ` Clemens Ladisch [this message]
2011-12-04 13:36         ` Jeroen Van den Keybus
2011-12-04 13:54           ` Jeroen Van den Keybus
2011-12-04 14:08             ` Jeroen Van den Keybus
2011-12-04 15:06               ` Jeroen Van den Keybus
2011-12-04 16:59                 ` Clemens Ladisch
2011-12-06  0:06                   ` Jeroen Van den Keybus
2011-12-08 11:33                     ` Jeroen Van den Keybus
2011-12-08 12:45                       ` Clemens Ladisch
2011-12-08 21:27                         ` Jeroen Van den Keybus
2011-12-09  8:22                           ` Clemens Ladisch
2011-12-09 11:17                             ` Jeroen Van den Keybus
2011-12-09 12:55                               ` Clemens Ladisch
2011-12-10 12:10                                 ` Jeroen Van den Keybus
2011-12-10 17:58                                   ` Clemens Ladisch
2011-12-11 15:28                                     ` Jeroen Van den Keybus
     [not found] <fa.CZQqvHf3CBfYWzhSDPNOWxTTD9w@ifi.uio.no>
     [not found] ` <fa.Vmg5vDod2/oKvwyy9BcalhoT+Lo@ifi.uio.no>
2012-04-25  8:35   ` andymatei
2012-04-25  8:48     ` Clemens Ladisch
2012-04-27  8:22       ` Borislav Petkov
2012-04-27  8:29         ` Andrei Matei
2012-04-27 11:46         ` Jeroen Van den Keybus
2012-04-27 13:06           ` Josh Boyer
2012-04-27 13:28             ` Jeroen Van den Keybus
2012-04-27 13:49               ` Josh Boyer
2012-04-30  8:29                 ` Jeroen Van den Keybus
2012-04-30  9:57                   ` Clemens Ladisch
2012-04-30 10:41                     ` Jeroen Van den Keybus
2012-04-30 12:47                       ` Clemens Ladisch
2012-05-29 22:20                       ` Grant Likely
2012-04-30 10:21                   ` Borislav Petkov
2012-04-30 11:35                     ` Jeroen Van den Keybus
2012-05-29 23:36                       ` Grant Likely
2012-05-30  0:07                       ` Thomas Gleixner
2012-05-30 10:44                         ` Borislav Petkov
     [not found] <fa.Tzg9rJm1oEMGIL8eap99R7gLU4Q@ifi.uio.no>
     [not found] ` <fa.Yw7gRhZrXlfCxofC1BHK22C+oTk@ifi.uio.no>
     [not found]   ` <fa.l7CBcHbzr+l317AuKP87w9mccUk@ifi.uio.no>
     [not found]     ` <fa.VXfk4ts2TBVKqgBQtfGn6RQHemg@ifi.uio.no>
2012-04-25  8:48       ` andymatei

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4EDB6C10.10102@ladisch.de \
    --to=clemens@ladisch.de \
    --cc=Dong.Nguyen@amd.com \
    --cc=Shane.Huang@amd.com \
    --cc=bp@amd64.org \
    --cc=jeroen.vandenkeybus@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox