[PATCH] alpha: add io{read,write}{16,32}be functions

[PATCH] alpha: add io{read,write}{16,32}be functions

[Michael Cree]

These functions are used in some PCI drivers with big-endian
MMIO space.

Admittedly it is almost certain that no one this side of the
Moon would use such a card in an Alpha but it does get us
closer to being able to build allyesconfig or allmodconfig,
and it enables the Debian default generic config to build.

Signed-off-by: Michael Cree <mcree@orcon.net.nz>
---
 arch/alpha/include/asm/io.h |    5 +++++
 1 files changed, 5 insertions(+), 0 deletions(-)

diff --git a/arch/alpha/include/asm/io.h b/arch/alpha/include/asm/io.h
index 56ff965..6365ef2 100644
--- a/arch/alpha/include/asm/io.h
+++ b/arch/alpha/include/asm/io.h
@@ -490,6 +490,11 @@ extern inline void writeq(u64 b, volatile void __iomem *addr)
 }
 #endif
 
+#define ioread16be(p) be16_to_cpu(ioread16(p))
+#define ioread32be(p) be32_to_cpu(ioread32(p))
+#define iowrite16be(v,p) iowrite16(cpu_to_be16(v), (p))
+#define iowrite32be(v,p) iowrite32(cpu_to_be32(v), (p))
+
 #define inb_p		inb
 #define inw_p		inw
 #define inl_p		inl
-- 
1.7.4.3

Re: [PATCH] alpha: add io{read,write}{16,32}be functions

[Raúl Porcel]

On 11/30/2011 09:01 AM, Michael Cree wrote:
> These functions are used in some PCI drivers with big-endian
> MMIO space.
> 
> Admittedly it is almost certain that no one this side of the
> Moon would use such a card in an Alpha but it does get us
> closer to being able to build allyesconfig or allmodconfig,
> and it enables the Debian default generic config to build.
> 
> Signed-off-by: Michael Cree <mcree@orcon.net.nz>
> ---
[snip]

WFM on my DS20E using 3.2.0-rc4-00231-g958c6c2

so,

Tested-by: Raúl Porcel <armin76@gentoo.org>

Re: [PATCH] alpha: add io{read,write}{16,32}be functions

[Jonathan Nieder]

Hi Matt et al,

Michael Cree wrote:

> These functions are used in some PCI drivers with big-endian
> MMIO space.
>
> Admittedly it is almost certain that no one this side of the
> Moon would use such a card in an Alpha but it does get us
> closer to being able to build allyesconfig or allmodconfig,
[...]
> --- a/arch/alpha/include/asm/io.h
> +++ b/arch/alpha/include/asm/io.h
> @@ -490,6 +490,11 @@ extern inline void writeq(u64 b, volatile void __iomem *addr)
>  }
>  #endif
>  
> +#define ioread16be(p) be16_to_cpu(ioread16(p))
> +#define ioread32be(p) be32_to_cpu(ioread32(p))
> +#define iowrite16be(v,p) iowrite16(cpu_to_be16(v), (p))
> +#define iowrite32be(v,p) iowrite32(cpu_to_be32(v), (p))
> +
>  #define inb_p		inb

This patch has been in use in Debian's development branch since
January.  Does it look sensible to you?  (If so, I'd like to see it in
mainline eventually so we can more easily share bugfixes depending on
it in the future.)

Thanks,
Jonathan

Re: [PATCH] alpha: add io{read,write}{16,32}be functions

[Matt Turner]

On Tue, Apr 24, 2012 at 1:51 AM, Jonathan Nieder <jrnieder@gmail.com> wrote:
> Hi Matt et al,
>
> Michael Cree wrote:
>
>> These functions are used in some PCI drivers with big-endian
>> MMIO space.
>>
>> Admittedly it is almost certain that no one this side of the
>> Moon would use such a card in an Alpha but it does get us
>> closer to being able to build allyesconfig or allmodconfig,
> [...]
>> --- a/arch/alpha/include/asm/io.h
>> +++ b/arch/alpha/include/asm/io.h
>> @@ -490,6 +490,11 @@ extern inline void writeq(u64 b, volatile void __iomem *addr)
>>  }
>>  #endif
>>
>> +#define ioread16be(p) be16_to_cpu(ioread16(p))
>> +#define ioread32be(p) be32_to_cpu(ioread32(p))
>> +#define iowrite16be(v,p) iowrite16(cpu_to_be16(v), (p))
>> +#define iowrite32be(v,p) iowrite32(cpu_to_be32(v), (p))
>> +
>>  #define inb_p                inb
>
> This patch has been in use in Debian's development branch since
> January.  Does it look sensible to you?  (If so, I'd like to see it in
> mainline eventually so we can more easily share bugfixes depending on
> it in the future.)
>
> Thanks,
> Jonathan

I recently got my kernel.org tree set up again, so I just applied this.

Thanks, and please point me to any patches I should apply.

Matt

Re: [PATCH] alpha: add io{read,write}{16,32}be functions

[Jonathan Nieder]

Matt Turner wrote:

> I recently got my kernel.org tree set up again, so I just applied
> this.

Thanks!  Glad to see more DEC syscalls flowing in.