From: ANNIE LI <annie.li@oracle.com>
To: Ian Campbell <Ian.Campbell@citrix.com>
Cc: Paul Durrant <Paul.Durrant@citrix.com>,
"xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"konrad.wilk@oracle.com" <konrad.wilk@oracle.com>,
"jeremy@goop.org" <jeremy@goop.org>,
"kurt.hackel@oracle.com" <kurt.hackel@oracle.com>
Subject: Re: [PATCH 1/2] xen/granttable: Support sub-page grants
Date: Wed, 07 Dec 2011 18:27:39 +0800 [thread overview]
Message-ID: <4EDF3F9B.4030407@oracle.com> (raw)
In-Reply-To: <1323251849.23681.128.camel@zakaz.uk.xensource.com>
On 2011-12-7 17:57, Ian Campbell wrote:
> On Wed, 2011-12-07 at 08:59 +0000, Paul Durrant wrote:
>>> gnttab_v2_ops = {
>>> ...
>>> .access_subpage = access_subpage_v2;
>>> .access_ref_subpage = access_ref_subpage_v2; .access_trans =
>>> access_trans_v2; .access_ref_trans = access_ref_trans_v2; }
>>>
>>
>> Do you need ops for the ref and non-ref functions? I would have
>> thought you could just have the ref ones since the all the non-ref
>> variants do is allocate and then call the ref variant.
> Good point. It appears that all the existing ops are only present in the
> ref form.
So I will add two elements: access_ref_subpage and access_ref_trans into
gnttab_v2_ops.
Thanks
Annie
> Ian.
>
>
next prev parent reply other threads:[~2011-12-07 10:28 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-06 10:53 xen: patches for supporting sub-page and transitive grants ANNIE LI
2011-12-06 10:56 ` [PATCH 1/2] xen/granttable: Support sub-page grants annie.li
2011-12-06 11:42 ` Ian Campbell
2011-12-06 17:20 ` Jeremy Fitzhardinge
2011-12-07 3:36 ` ANNIE LI
2011-12-07 3:36 ` ANNIE LI
2011-12-07 8:59 ` Paul Durrant
2011-12-07 9:57 ` Ian Campbell
2011-12-07 10:27 ` ANNIE LI [this message]
2011-12-07 10:33 ` Ian Campbell
2011-12-07 10:50 ` ANNIE LI
2011-12-07 19:41 ` [Xen-devel] " Konrad Rzeszutek Wilk
2011-12-07 9:56 ` Ian Campbell
2011-12-07 10:27 ` ANNIE LI
2011-12-07 10:36 ` ANNIE LI
2011-12-06 10:57 ` [PATCH 2/2] xen/granttable: Support transitive grants annie.li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4EDF3F9B.4030407@oracle.com \
--to=annie.li@oracle.com \
--cc=Ian.Campbell@citrix.com \
--cc=Paul.Durrant@citrix.com \
--cc=jeremy@goop.org \
--cc=konrad.wilk@oracle.com \
--cc=kurt.hackel@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox